Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1436517imw; Sat, 16 Jul 2022 06:39:08 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uhD1HIsxA7g6/YvBmYWGakLqliLSy9DO/yScODBaJcJPzwtUaMXhhXpoOFR5B3wMvSZoOy X-Received: by 2002:a05:6402:4255:b0:43a:c03f:1aa4 with SMTP id g21-20020a056402425500b0043ac03f1aa4mr26313762edb.146.1657978748731; Sat, 16 Jul 2022 06:39:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657978748; cv=none; d=google.com; s=arc-20160816; b=CcB+Alio4uign+OxMXThs6d/kPoqpp2AW1+nYTGyE1P8JJFFAqwgNc02HwGMmpbS53 UoEl9COF4l0/+T78wIbgS0QjjeGwh7qP0TJJ2SCoURtP1dRzbd3LiK4H/sTQQBHEWC1I qLoAdf/gqsaga3cAy5vn1Pq8vTPovYWyuA2jwkjMWet2byGZ5DyyhjyL+rKjnSZo5A5Z ziYqGKk0pRycmTi3GBEJqZfTQ79tcGUwC6guW6E07J8uz6tZbsOdlNoNp8MIg4qjl/yq T0MP/kcwQT0JNkgqFwdVz5wSP0J4y2yjp6fiKB3Nz/xopRYVaSTKSX5FV2Ie+r5Yiz1y CfTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=+HNtxGQD7e4/sLkvDJa6jpv7jycfk922+wnC+RQcTIU=; b=Km67Ery8cxBeyo9Af7MwMjk7bYoLyP4x5NqFqrpbzXUbaT0vYwqa87754NHqoAtqT9 s+ovq0VRzvX86s5ycQ03OuBP0x5tzagTpLSAvKqpNR8Ov9YHqzsDlWPQe9qcqPBfPT49 Oyk1jWYLuvsRzDlZh14eCHryKY8KAzDU/o7Bi43MSZ3TdUnJfoiugXcnryOxu6ojnxOq 7XmJCWu8ACNzYTjwCqSO1r6o3339KzKIvZwbebd7/Q8ROXJYWJP8/j0JN8YjmfSX91s3 dTrZRTT0qPJiyBnjKLF1OfCkWKaXkMXI5Uv2NBOEg4WDUAxgoytNMzLjMV5+EAmxwscR v6nQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=lhLES4fy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d1-20020a1709061f4100b0072edee8a633si9209935ejk.187.2022.07.16.06.38.44; Sat, 16 Jul 2022 06:39:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=lhLES4fy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231241AbiGPNW2 (ORCPT + 99 others); Sat, 16 Jul 2022 09:22:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229502AbiGPNW0 (ORCPT ); Sat, 16 Jul 2022 09:22:26 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFB4A1EC6A for ; Sat, 16 Jul 2022 06:22:25 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id y14-20020a17090a644e00b001ef775f7118so14003156pjm.2 for ; Sat, 16 Jul 2022 06:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=+HNtxGQD7e4/sLkvDJa6jpv7jycfk922+wnC+RQcTIU=; b=lhLES4fyFR+FYNpd2+gkPC1xS8YjVsmI18JvmW1b4NK9N2QULLu/XV9WmjYaRxewjZ QLJ7fTK69VFbQpsEkQRUi9ClHMliLAYAb6Ww8oQzjGEsT7lo7yL9MpshT0upgJK6roYT yy4kbpalmj7mV69hMxwtHw/OZow1kKV7lw6edrGuedmbuYWbpj8f1bwh66+E4PrvTIa/ CMImqd7zDHqhqXWvNFx5oWubqBh03ea3iXZnmy+YSmyvymxi7f7yE75HOo7HA6dkCHiB im8dw3gYWVZk0M79ympBsaBmJm+lO/mkb52N5E6diCmb/5bfjw1XbT1vlK5PWXXXsyZ4 b0ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+HNtxGQD7e4/sLkvDJa6jpv7jycfk922+wnC+RQcTIU=; b=cWRuJypV1CeynZsMuhLuTRDockRCtQpNsQrFqTZadNY5HHrX0SSScJuFJe4YjZlgUV jmVFihUJEUXWPq7oOPyk83Hczhw9Mb5ZD+KhiB8Ne81qBpLQtyZ37Oa7OnWtFjbAAjDy hNICqwPvAr+R13vPCrr652a7DIycUqmEO95pcKkXwqxV0rQz4Ywgyz22gzxRbOh5TrsX gPmpBq7UiU8T9qp8+xKNQfL8vdpjXxbsdhd+V5CwjI3Zr9G1EQrTwvqYM8Qq/g+EJFVT kRw7oFijvTZQZjSmxa9LwCihHMdCN56RIFjJ3RHK02NaBbNAykBXAkpi9MtD//bpse8T 4BRA== X-Gm-Message-State: AJIora+yvhFGOqZ3FhQK2+AEWm6kFrq0KPnm2wuMf/+Q+I13IbsTbkeU hMFd7oAR2S2SZqsHAHrXBbXX2g== X-Received: by 2002:a17:90b:1e04:b0:1f0:61a4:d747 with SMTP id pg4-20020a17090b1e0400b001f061a4d747mr26953849pjb.58.1657977745202; Sat, 16 Jul 2022 06:22:25 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id g21-20020aa796b5000000b005289cade5b0sm5807094pfk.124.2022.07.16.06.22.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Jul 2022 06:22:24 -0700 (PDT) Message-ID: Date: Sat, 16 Jul 2022 07:22:23 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] ublk_drv: initialize ret variable Content-Language: en-US To: Tom Rix , nathan@kernel.org, ndesaulniers@google.com, ming.lei@redhat.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20220716131555.2014270-1-trix@redhat.com> From: Jens Axboe In-Reply-To: <20220716131555.2014270-1-trix@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/16/22 7:15 AM, Tom Rix wrote: > clang build fails with > drivers/block/ublk_drv.c:1304:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] > > When the call to ublk_get_device_from_id() fails, ret is used without being > initized. So initialize. Should already be fixed: https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.20/block&id=f2450f8a2c1ec3e88d6674f747b913aa5f21fa59 -- Jens Axboe