Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 16 Jul 2022 17:07:51 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Marek =?utf-8?B?QmVow7pu?= <kabel@kernel.org>,
        linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] ARM: dts: armada-38x: Fix compatible string for
 gpios
Message-ID: <20220716150751.6yaknmo3qwusyy5h@pengutronix.de>
References: <20220714115515.5748-1-pali@kernel.org>
 <20220714183328.4137-1-pali@kernel.org>
 <20220714183328.4137-3-pali@kernel.org>
 <20220716144028.rzwcn4wl5uyxepjd@pengutronix.de>
 <20220716145019.nps3oh4a22fsuzup@pali>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mbmakiw7qwh6ws4a"
Content-Disposition: inline
In-Reply-To: <20220716145019.nps3oh4a22fsuzup@pali>
Precedence: bulk


--mbmakiw7qwh6ws4a
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jul 16, 2022 at 04:50:19PM +0200, Pali Roh=E1r wrote:
> On Saturday 16 July 2022 16:40:28 Uwe Kleine-K=F6nig wrote:
> > On Thu, Jul 14, 2022 at 08:33:27PM +0200, Pali Roh=E1r wrote:
> > > Armada 38x supports per CPU interrupts for gpios, like Armada XP. Pre=
-XP
> > > variants like Armada 370 do not support per CPU interrupts for gpios.
> > >=20
> > > So change compatible string for Armada 38x from "marvell,armada-370-g=
pio"
> > > which indicates pre-XP variant to "marvell,armadaxp-gpio" which indic=
ates
> > > XP variant or new.
> > >=20
> > > Driver gpio-mvebu.c which handles both pre-XP and XP variants already
> > > provides support for per CPU interrupts on XP and newer variants.
> > >=20
> > > Signed-off-by: Pali Roh=E1r <pali@kernel.org>
> > > Fixes: 7cb2acb3fbae ("ARM: dts: mvebu: Add PWM properties for armada-=
38x")
> > > ---
> > >  arch/arm/boot/dts/armada-38x.dtsi | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >=20
> > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/ar=
mada-38x.dtsi
> > > index df3c8d1d8f64..9343de6947b3 100644
> > > --- a/arch/arm/boot/dts/armada-38x.dtsi
> > > +++ b/arch/arm/boot/dts/armada-38x.dtsi
> > > @@ -292,7 +292,7 @@
> > >  			};
> > > =20
> > >  			gpio0: gpio@18100 {
> > > -				compatible =3D "marvell,armada-370-gpio",
> > > +				compatible =3D "marvell,armadaxp-gpio",
> > >  					     "marvell,orion-gpio";
> >=20
> > If you can treat the XP variant as 370 and everything that is supposed
> > to work on 370 works then, then maybe the right incarnation is:
> >=20
> > 	compatible =3D "marvell,armadaxp-gpio", "marvell,armada-370-gpio", "ma=
rvell,orion-gpio";
> >=20
> > ?
>=20
> For pre-XP variants is "marvell,orion-gpio" enough and for XP + post-XP
> is needed "marvell,armadaxp-gpio" (with possible "marvell,orion-gpio"
> for backward compatibility).
>=20
> So I do not see reason why to add "marvell,armada-370-gpio" nor what
> value it brings.

If you boot an older kernel (i.e. one that doesn't support
marvell,armadaxp-gpio, but does support marvell,armada-370-gpio), it
will work better as there are relevant differences between
marvell,orion-gpio and marvell,armada-370-gpio. For example some
registers seem to have a different offset ...

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--mbmakiw7qwh6ws4a
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmLS1EMACgkQwfwUeK3K
7AkxzQf+JnWj+P369JeEqvihi0Qj5V7qPoBnMdsxxJcFW/lDUKlNfHlvbYTaiKPP
65Wkco8ncalzS1rFIfTXD9Kg4oc7CUft8x4OvgFug7GMkPnvdzYMzC1ey1rJBvUJ
8dPt8BcscOAaE3NegqnDwVw44Yg7/qHFaFpxkmvPGCFAY1g/c6cZGJd6CDOrT0Q6
czIEy2FpqhdcDJZ8yMHjqp5dImcZn277LMIY5dqziupIBVKFIh0YuV7MdksXu/XP
rjqP/FSKB71ZOX/lPTyzKa69FyV5P/+2f15LptLxLoM3qLbpfI+tXTd21uEZgw3f
IerhFelatP+M9dKpMSMFaMk8N/cQcg==
=UqHw
-----END PGP SIGNATURE-----

--mbmakiw7qwh6ws4a--