Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 16 Jul 2022 19:03:31 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Liam Beguin <liambeguin@gmail.com>
Cc:     geert@linux-m68k.org, peda@axentia.se, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 5/5] iio: test: rework Kconfig to support modules
Message-ID: <20220716190331.43f5bc03@jic23-huawei>
In-Reply-To: <20220710013109.3349104-6-liambeguin@gmail.com>
References: <20220710013109.3349104-1-liambeguin@gmail.com>
        <20220710013109.3349104-6-liambeguin@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat,  9 Jul 2022 21:31:09 -0400
Liam Beguin <liambeguin@gmail.com> wrote:

> Rework the IIO test Kconfig to support building KUnit tests as modules.
> This lets users execute tests at runtime in addition to the usual
> tools/testing/kunit/kunit.py script.
> 
> Signed-off-by: Liam Beguin <liambeguin@gmail.com>
One trivial comment inline.  Fixed that up and applied to the togreg branch
of iio.git. Not I'll only push out as testing for now as will be rebasing
the tree after rc1.

Jonathan


> ---
>  drivers/iio/test/Kconfig | 24 +++++++++++++++++-------
>  1 file changed, 17 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/iio/test/Kconfig b/drivers/iio/test/Kconfig
> index 7dbf51bc4934..82924727b2cc 100644
> --- a/drivers/iio/test/Kconfig
> +++ b/drivers/iio/test/Kconfig
> @@ -5,15 +5,25 @@
>  
>  # Keep in alphabetical order
>  config IIO_RESCALE_KUNIT_TEST
> -	bool "Test IIO rescale conversion functions"
> -	depends on KUNIT=y && IIO_RESCALE=y
> +	tristate "Test IIO rescale conversion functions" if !KUNIT_ALL_TESTS
> +	depends on KUNIT && IIO_RESCALE
>  	default KUNIT_ALL_TESTS
>  	help
> -	  If you want to run tests on the iio-rescale code say Y here.
> +	  build unit tests for the iio-rescale code.

Build

>  
> -	  This takes advantage of ARCH=um to run tests and should be used by
> -	  developers to tests their changes to the rescaling logic.
> +	  For more information on KUnit and unit tests in general, please refer
> +	  to the KUnit documentation in Documentation/dev-tools/kunit/.
> +
> +	  If unsure, say N.
>  
>  config IIO_FORMAT_KUNIT_TEST
> -        bool "Test IIO formatting functions"
> -        depends on KUNIT=y
> +	tristate "Test IIO formatting functions" if !KUNIT_ALL_TESTS
> +	depends on KUNIT
> +	default KUNIT_ALL_TESTS
> +	help
> +	  build unit tests for the IIO formatting functions.
> +
> +	  For more information on KUnit and unit tests in general, please refer
> +	  to the KUnit documentation in Documentation/dev-tools/kunit/.
> +
> +	  If unsure, say N.