Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: [PATCH net 0/5] net: lan966x: Fix issues with MAC table
Thread-Topic: [PATCH net 0/5] net: lan966x: Fix issues with MAC table
Thread-Index: AQHYl7kVzGUrNDShFEaiO4kUzeNKoa2BcM6A
Date:   Sat, 16 Jul 2022 20:10:45 +0000
Message-ID: <20220716201043.ps6z4mxlagluwtyw@skbuf>
References: <20220714194040.231651-1-horatiu.vultur@microchip.com>
In-Reply-To: <20220714194040.231651-1-horatiu.vultur@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?n5h4PL2J1CVMHhZYp+sPAlEp5XKovqs216F6eq2T7wR1FoOlq8fMWe9jjARd?=
 =?us-ascii?Q?ZHyIoYtROYkvqgHAu3popFmfOlyKh1WoG+DBT65mVLgNezNLa8ivf2q1XXdK?=
 =?us-ascii?Q?B3FZ/iU5woP98uI2O3wLZnwQRAb5kBqJKWPQO1gS1Nu/sGFaFD51g0uLc1u9?=
 =?us-ascii?Q?muy/VQzirwdaS9b22VnsSL0Xq0X9ETFf5Pnif2kUVO1acG4Nzb+wUYY8FwVB?=
 =?us-ascii?Q?lj6c/MjwevSI6F8FvFvhmsf9TRFCDpNqWikHe6bJKN9LdKMPyIkAex4mSMO3?=
 =?us-ascii?Q?frGGfk3XSrEG7/Zllsdpg7CXsP7W7hwfL03RCn5+CkWvxTZ5IS8n89cY0mcJ?=
 =?us-ascii?Q?iCsc6B/NMhW+jiTCpm8KDDXah2kLyCLfz5YWqKACCosAZhreme+wlXRbxQ2b?=
 =?us-ascii?Q?Kg5JeayyLVXEzS6wI4kfqSF7+Nsjc3HD0MK/+Y/DtXkJ5wguCC7PhrrJqJww?=
 =?us-ascii?Q?EVHa2RwImO8ztn9lo9Xp4Yv5jPWu5srTwQBaQChXfNCrtaMLqa5Eeavmj6jH?=
 =?us-ascii?Q?9NinK5qJPhzdJYGSj3f6nXUOdjABrr5hWMlk6wMhCyoZ3vzgMck631t/2a3y?=
 =?us-ascii?Q?kBGf9TsMdpc5tjsmlAbY+x2fTvhrkxoSKRfz9gAZAkqNklU37/PCu/LB64EC?=
 =?us-ascii?Q?L4coXa3PiQZYwcRWwxAY1NR/lV0yYyoh+XPCrD1NSXTtVRLjHDjsYwrlhFin?=
 =?us-ascii?Q?rPmv4x0bkCpv/1ZaS2hkbRry8Dfd5I1x0yl59Xwkv1lVynrwzTF94HiFwMG0?=
 =?us-ascii?Q?ICnQ5CQ3qLlqqtakc/8DVWl0KR002OEWtZHKkJxMQ4rnz6YU9bJ1+mamewGF?=
 =?us-ascii?Q?31DbrB7ZKzjkN0sqBB99SrTK6+g79fuoSxawkN3e6cWeZ4StmuM5bcJmzqYf?=
 =?us-ascii?Q?iZQYnDeH7LRXUwNRiSDtbxOz5j+hoCkIICSKaguyOM2k/5417PmR53pB0SRu?=
 =?us-ascii?Q?d60U87jaPNxGK/IIPZhwyzQgg8o4Jk0pYh7AG4bWTkFmCs86G0a8LTqh3QoY?=
 =?us-ascii?Q?YsXiR6yx+hFjLaKoSSPjtGMfPKtnkhhOav4slMBqIrG6ZmT3K/MNyTKAQCFf?=
 =?us-ascii?Q?Q2g2XrAJGt+us/ZAN7sDF5yeuS0BDDcQJbEfyrhHiLATtXbp6gEyjr98ibgX?=
 =?us-ascii?Q?Bj9TExWlFBrnUYp87sk/npQ4Zi/x1ogYgzAu2rRbBFTAskIUI/5znkOKWrVg?=
 =?us-ascii?Q?qqI9YUNbFG6Fy+ZMQyBanXOe0Ow6JofgZtLAT+7DU02l3R7TZZSiCMF+DEYc?=
 =?us-ascii?Q?X/UW7svhNjQCh/aJTpr8kFY9r+D8tIUEujhnNTR0z/tsJM9cMLdaWoyl0wzn?=
 =?us-ascii?Q?MApihCr1rwSFNvEYnS6WVjX4mdD3MJbMSUa8KX5uCqnVI4duJwFUOQZKfw81?=
 =?us-ascii?Q?3Dcr7wUYb2JYqsow9WvwNBDuHx4hIyyR+vCJN9iWLKMZvj3QgF5C2QMmKDN6?=
 =?us-ascii?Q?KBnGZOmblHKG1vHhzcc4m9yG6+coqonIEj+jacaX1HOoJ+fimA4wS9ZCX45a?=
 =?us-ascii?Q?H+sOp8aM1sLST7oNKiGXJS+tY1SEo562sEJIJYJDRnnQxjamUNNfDLBm2y7p?=
 =?us-ascii?Q?6bZBpxZZst+aV8FVrUueHK88uLB/DTMkpBIbNMWGvvW4xJ7n2l6gYhEA/mcY?=
 =?us-ascii?Q?gw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8E43A80FF3C0A743A89D61ACC2E6A47C@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5121.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a6aab58-f15c-4460-72f5-08da676744f2
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2022 20:10:46.1753
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gWuEXCAr5FgSTPhAWeA1ge4GqHzgqzehnnqy9ElmVG7MEpADTbuV1E5gsFhYDP1MRxQRM12cdY9h5lUM0pVKCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5298
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 14, 2022 at 09:40:35PM +0200, Horatiu Vultur wrote:
> The patch series fixes 2 issues:
> - when an entry was forgotten the irq thread was holding a spin lock and =
then
>   was talking also rtnl_lock.
> - the access to the HW MAC table is indirect, so the access to the HW MAC
>   table was not synchronized, which means that there could be race condit=
ions.

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>=