Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH net-next v3 07/47] net: phy: Add support for rate
 adaptation
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>, netdev@vger.kernel.org,
        Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        linux-arm-kernel@lists.infradead.org,
        Russell King <linux@armlinux.org.uk>,
        linux-kernel@vger.kernel.org,
        Alexandru Marginean <alexandru.marginean@nxp.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>
References: <20220715215954.1449214-1-sean.anderson@seco.com>
 <20220715215954.1449214-8-sean.anderson@seco.com> <YtMT8V4PNkxJ9lMm@lunn.ch>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <6f8e17cb-3f6b-9e89-51a4-9452d562204b@seco.com>
Date:   Sat, 16 Jul 2022 17:55:38 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
In-Reply-To: <YtMT8V4PNkxJ9lMm@lunn.ch>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXZvemNhQ3VxY2xKa21id0VJQjJLWENyQmIzRk1MSFgxUk9PcWQramJhTStv?=
 =?utf-8?B?dXdLRWpGOHNkd1NhR3JOWXZSOExLSWF4UGVaWUhYbkJZSUxWc0RVYWtlOUpM?=
 =?utf-8?B?aTZqTDl2bmJkRlI0NmhkZHFBTWZqUEN0enA4THJ3aDl2blQvMDRacTJrWXFP?=
 =?utf-8?B?T2g5M2pMZ1EyUW81Z0xuRGVSVjdHbGNwc1g3NTAwanpaQ2tPV3VoT1RmR2tE?=
 =?utf-8?B?VUJoOXlVZjVKTURxN3RwZUk3MG1KbXBMc2ZsOG1vQkh0Z01TcXQ5ZjVDNndo?=
 =?utf-8?B?cXRiYmIvZ3lHYWNRcmVnMGM2MkdsQnlUUHp3cmFTaDY4OE5tWTBRcUhqWGFV?=
 =?utf-8?B?MDNxR3RpcmQ5dExwbHpDYTFEcnl3S0NHdFpRQjdicnJZSUJ1a2RLQzNadU51?=
 =?utf-8?B?a2M4RlRRM0w1aGFTd1NjUUxWY3Zkd3NVa2NMYW1HWG1XN1JmQXFIZjJrN29D?=
 =?utf-8?B?dHZCRGdCSzBPelZRZEJCei8xaUJWZDRqeXdlanowdEhCQ0xMQkZ0L3FJV0tV?=
 =?utf-8?B?SnVKdkU2OWYvTjJWSnA2REtaOUo0VzVqZGJDbVVuTEFuNWovMDlQeWFmVmZk?=
 =?utf-8?B?M1Z3VnpuM21Fck5acFBKdXJMa0Y3cVlCbUNVOXdtQmc1VUtsQ254Q3BDQTls?=
 =?utf-8?B?UFIzS25iOXM5R2oyUXd2YnlFeWV6ZkYrSlZwTGdoL25Tc05rNHlKZjNJODVj?=
 =?utf-8?B?UDlZV2plTk9iOFRtNFJUaUIrcDhValNCOUd2YlhKOGFLU2hETC9LMHlVYktT?=
 =?utf-8?B?WVMrZTZKMWEvQWhFSGlsTm1pRUczdWVMczg0aC9IMXZUc0x6MjRqOGxFMFd4?=
 =?utf-8?B?MGlDbk5UaHdHS3hVSmRIRlVLSHZWQ2RQMmRZbWdlTlVNNGt3NTdRWEFGZnpt?=
 =?utf-8?B?YTUrb1g0RHgrNXdVVWN5SnBLMW81VzZlMzNkWk1NNnZsOC9HaUx2MlcyZHdE?=
 =?utf-8?B?ZTIrRjAyaXRRTkd3QlZNdTdjOWNDQnRmUkU0M3R0RXphdEZTYVpiVVdWYmpn?=
 =?utf-8?B?SWlJR1cybnJqN0d6RTAxa1RWZURkN2lEYWxLeHVJNUlTRXZodmk2aUZGZmFP?=
 =?utf-8?B?VU1EWnNSZGRxS1dBMkk2L3ZPWHY0R3Y1dlRreXVKNVZPSGMvbHoxaXFwejNi?=
 =?utf-8?B?ZUtrbFNLQTB3RUdGTHJoQitJTDdDekFvQUNFMnpqY0ZWcnpoZjZmT0NyY0dl?=
 =?utf-8?B?eDYwOVFVUXo2U254b0U1K2JQNGJrTWYrcGl2bFhrLzdhUHRrcFZnQU9HTHpl?=
 =?utf-8?B?cmRuaHg1ekF2Wm9ZREoycUZ3QjlQaDUrWWp1ZTBVUnVXelFyTVpiTjJaWUN6?=
 =?utf-8?B?cDc5Y0R3V0RRNUR5MWVuMkF2ZGlHTUx4NlRFVVNxOVZxZW1XU2V5REphQVhh?=
 =?utf-8?B?VTdjOGNjc2EvbHNtV1c2M2lMOU1mZFRWTnhlbmZyQ2JuRjJvT3JGQ0tDa3RP?=
 =?utf-8?B?QWtsK3B1d2tGVjEra2d5anVXd1VGRDhtS1d5U0x1ckJCREpBTlN6YXlSbFN3?=
 =?utf-8?B?M2pKZ2g1anB4UUorUUNoaXA5ZmNZNWYrUWV0NkE4NEJSSVcwcTluMUEvenF0?=
 =?utf-8?B?WmVXWERZeVlXWnRBTkxBNGFGUWR5eVJoQ3JwUGZ2c0xUa0o5cGdYZFhOQzRT?=
 =?utf-8?B?L2VINS83cjk1cXhpWGtSTFhuaDY4ZHVzbVVzcHJJWHNDTHdpZkR4K3A1Q0RP?=
 =?utf-8?B?OVh0cDVVaXhNWXZMamZNekZ5R3BpRnBnOUxOYjdYSkdNQXdSamNYY1RDTTZE?=
 =?utf-8?B?ZlE2M05uVUU5SW5Nd25DSzRsbnV5MGEzdDhpbzBrbStnR3ZjUEVyNC96WFdw?=
 =?utf-8?B?MkNYZXRlOXNnYm1yRm03TklTa2Z6eHdkWTFPblJyZG9SMVFrdlJ5NStDcVp1?=
 =?utf-8?B?ejRQalI1bDBHcm9ycDduUmI1ZWFhMVZkMHpDM0JTNVBHRVJmWmlBOG5NRHkw?=
 =?utf-8?B?cjgzWlJnMHU5NEJZNWM1d3l6RDk5RXI2QU8yQ0svdXkzQlQ0OW1LVkhTSGZs?=
 =?utf-8?B?QXZweEpIVWZUL1BvY3BYRUlBWkpPbDllQm5MRkV2T3FjVVdxeEtXREE3YXND?=
 =?utf-8?B?eisrRE1aNDVZcGVVVGttMXIwd1dsbjZrdmdiVFYrMmh6Smh1UnU0ckhIZ1lq?=
 =?utf-8?B?WVo3SzEvTFBFZng4Z05OZkZkeis5c3UxQnBqeXVVYjhTaUJhdXE5K0s4T0Zp?=
 =?utf-8?B?RkE9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4181b89d-67d6-4a99-b6c3-08da6775eed7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB4973.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2022 21:55:44.6514
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VJ8mhDINu12Hi8ESkWVVZCwPFMidsic/PHY6OZHxYjimwGd5djduqUh5QLsYNdPABkMI+4eXfwJxVCsjOxeKaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4904
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/16/22 3:39 PM, Andrew Lunn wrote:
>>   drivers/net/phy/phy.c | 21 +++++++++++++++++++++
>>   include/linux/phy.h   | 38 ++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 59 insertions(+)
>>
>> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
>> index 8d3ee3a6495b..cf4a8b055a42 100644
>> --- a/drivers/net/phy/phy.c
>> +++ b/drivers/net/phy/phy.c
>> @@ -114,6 +114,27 @@ void phy_print_status(struct phy_device *phydev)
>>   }
>>   EXPORT_SYMBOL(phy_print_status);
>>   
>> +/**
>> + * phy_get_rate_adaptation - determine if rate adaptation is supported
>> + * @phydev: The phy device to return rate adaptation for
>> + * @iface: The interface mode to use
>> + *
>> + * This determines the type of rate adaptation (if any) that @phy supports
>> + * using @iface. @iface may be %PHY_INTERFACE_MODE_NA to determine if any
>> + * interface supports rate adaptation.
>> + *
>> + * Return: The type of rate adaptation @phy supports for @iface, or
>> + *         %RATE_ADAPT_NONE.
>> + */
>> +enum rate_adaptation phy_get_rate_adaptation(struct phy_device *phydev,
>> +					     phy_interface_t iface)
>> +{
>> +	if (phydev->drv->get_rate_adaptation)
>> +		return phydev->drv->get_rate_adaptation(phydev, iface);
> 
> It is normal that any call into the driver is performed with the
> phydev->lock held.

Ah, so like phy_ethtool_get_strings.

>>   #define PHY_INIT_TIMEOUT	100000
>>   #define PHY_FORCE_TIMEOUT	10
>> @@ -570,6 +588,7 @@ struct macsec_ops;
>>    * @lp_advertising: Current link partner advertised linkmodes
>>    * @eee_broken_modes: Energy efficient ethernet modes which should be prohibited
>>    * @autoneg: Flag autoneg being used
>> + * @rate_adaptation: Current rate adaptation mode
>>    * @link: Current link state
>>    * @autoneg_complete: Flag auto negotiation of the link has completed
>>    * @mdix: Current crossover
>> @@ -637,6 +656,8 @@ struct phy_device {
>>   	unsigned irq_suspended:1;
>>   	unsigned irq_rerun:1;
>>   
>> +	enum rate_adaptation rate_adaptation;
> 
> It is not clear what the locking is on this member. Is it only safe to
> access it during the adjust_link callback, when it is guaranteed that
> the phydev->lock is held, so the value is consistent? Or is the MAC
> allowed to access this at other times?

The former. My intention is that this has the same access as link/interface/speed/duplex.

--Sean