Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 17 Jul 2022 00:47:52 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Schspa Shi <schspa@gmail.com>
Cc:     myungjoo.ham@samsung.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: Fix typo in power_supply_check_supplies
Message-ID: <20220716224752.zvee6zml42ezomjj@mercury.elektranox.org>
References: <20220705033244.5791-1-schspa@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2gzyvp2kaanvj5ev"
Content-Disposition: inline
In-Reply-To: <20220705033244.5791-1-schspa@gmail.com>
Precedence: bulk


--2gzyvp2kaanvj5ev
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Jul 05, 2022 at 11:32:44AM +0800, Schspa Shi wrote:
> It seems to be a typo, there is no actual BUG, but it's better to
> fix it to avoid any possible BUG after we change the type of
> supplied_from.
>=20
> Signed-off-by: Schspa Shi <schspa@gmail.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/power_supply_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/sup=
ply/power_supply_core.c
> index fad5890c899e..02228d68c599 100644
> --- a/drivers/power/supply/power_supply_core.c
> +++ b/drivers/power/supply/power_supply_core.c
> @@ -263,13 +263,13 @@ static int power_supply_check_supplies(struct power=
_supply *psy)
>  		return 0;
> =20
>  	/* All supplies found, allocate char ** array for filling */
> -	psy->supplied_from =3D devm_kzalloc(&psy->dev, sizeof(psy->supplied_fro=
m),
> +	psy->supplied_from =3D devm_kzalloc(&psy->dev, sizeof(*psy->supplied_fr=
om),
>  					  GFP_KERNEL);
>  	if (!psy->supplied_from)
>  		return -ENOMEM;
> =20
>  	*psy->supplied_from =3D devm_kcalloc(&psy->dev,
> -					   cnt - 1, sizeof(char *),
> +					   cnt - 1, sizeof(**psy->supplied_from),
>  					   GFP_KERNEL);
>  	if (!*psy->supplied_from)
>  		return -ENOMEM;
> --=20
> 2.29.0
>=20

--2gzyvp2kaanvj5ev
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmLTQBgACgkQ2O7X88g7
+pqkOhAAk8PjxHluM5z8cE5okLdna7x94NWtXT7DVCe0ryxWOSKQv9+1XFa4Motx
Mjdtb6z0OCXV2FgC1Ryyi0SvldhU/ywI+p5DkrMGubbFTQ7Q39s6/itFSNULOR9o
0WC6BIsbIexF3OnruM+EzGhNw6XOAE76rebJvd0C/LASB+G8QpsOiKcnFlemwjVk
WOoYT87wg5cItJsaJW0ORFKloL4O8kv3MNPJGi0poXB7pVpkGCPPUfWzGfcmRO+u
oGCDr6If/9Eg2PlfJMAdB5VJ1GO35xClHbt3OujQ8XRYyke48etTZAhX/ay6bi2f
nHc/jJsiCh2xa1v20ul3Ew5JsGL30N5zYXHrzIG+HkMTZDo9GMdIqPang4bThoS4
3hOPuUO6QzH5lD1NMPVR7FQXYv2WfLejKS/2zwn6tePR+xDDe6UmItZFAF4cJwGa
VWtwlYC9LTjajTTPReavCwHNDtzY9oUwvwMJzxuPTFkMtmSBAyuTi/Q24X5Ry2YO
o5v5M5xNo+ZWtL+1qQJ6oe/QqGcjpC6+Ixq+rh2yQLPPBooVgxV59eOPey/J/5B1
3tOTIpdifeVSSc6WNwn9xSqdSY3oTlcL0qiJnyRiKFKR8KEzZWL7f35G5vZtb89o
vYgRZWIsrh66XKjMKTLQIBLgojDKhb3bsXnINfwbex4i/H6wXA8=
=c38s
-----END PGP SIGNATURE-----

--2gzyvp2kaanvj5ev--