Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 17 Jul 2022 01:04:30 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Jiang Jian <jiangjian@cdjrlc.com>
Cc:     linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] power: supply: ab8500_fg: drop unexpected word 'is' in
 the comments
Message-ID: <20220716230430.qkv524wrlw5ct2nh@mercury.elektranox.org>
References: <20220622171410.5467-1-jiangjian@cdjrlc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="36qeumywz7deknmz"
Content-Disposition: inline
In-Reply-To: <20220622171410.5467-1-jiangjian@cdjrlc.com>
Precedence: bulk


--36qeumywz7deknmz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Jun 23, 2022 at 01:14:10AM +0800, Jiang Jian wrote:
> there is an unexpected word 'is' in the comments that need to be dropped
>=20
> file - drivers/power/supply/ab8500_fg.c
> line - 415
>=20
> * The capacity filter is is reset to zero.
>=20
> changed to:
>=20
> * The capacity filter is reset to zero.
>=20
> Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
> ---

Thanks, queued with shortened commit message. No need to describe
what exactly has changed, that's obvious from the patch diff...
Instead commit messages should say _why_ something changed, so in
this case something along the lines 'fix word duplication' is
enough.

-- Sebastian

>  drivers/power/supply/ab8500_fg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/power/supply/ab8500_fg.c b/drivers/power/supply/ab85=
00_fg.c
> index 4339fa9ff009..12eafeca83e1 100644
> --- a/drivers/power/supply/ab8500_fg.c
> +++ b/drivers/power/supply/ab8500_fg.c
> @@ -412,7 +412,7 @@ static int ab8500_fg_add_cap_sample(struct ab8500_fg =
*di, int sample)
>   * ab8500_fg_clear_cap_samples() - Clear average filter
>   * @di:		pointer to the ab8500_fg structure
>   *
> - * The capacity filter is is reset to zero.
> + * The capacity filter is reset to zero.
>   */
>  static void ab8500_fg_clear_cap_samples(struct ab8500_fg *di)
>  {
> --=20
> 2.17.1
>=20

--36qeumywz7deknmz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmLTQ/4ACgkQ2O7X88g7
+prKfA/+M7F7yHmV3yAcgrUDT3uYtFYOgQhzFSsm81UuEe9hl77uN/WVvvvYlipy
q1k4JT03zhzikZile6RI4UwkW6Dl2o0jikyWVktJHiC+ZhGSuaT0e4Scw3VKd+RG
wZESHtso+5DxPLzrsraXcxjASGgPrHNb5dzLB2BSEqNYs3iz2QFC5GCnzePgGc8J
1d8yof5B4WH7SrNDSaGABg3KP6pIHSmGfx2Ki0gTQ+wJUdKU2iXblkdw+/8bw/iy
lVlR6DA05QEO+i2F7M9ZcAcvuEw/cHYBzg8R7m3Xx2sEuSlloXZKM/o86QCohU33
fquWBamyKieRCwXhKbVP9sjRsNNNG/Nl7J7yPYU5hAB+JPb89cJZiLBU9fHvVsUS
mHZJzgHOlMWVCNN0c6m+2+eCGZRCeGMaK/wKw+ZqlNsQgtPPrz9GGJ6SMRZ7qOXd
zYfjGjl3QNFg3Xa3Qqqy3IXS4MyVPH4/1hxkqBbCWXTMOneZduu1UV1AfgSubeNG
u8UcW+8Drf5BbcqDBZaO4GegbEvPVHDVKprw1qZztc7DRfqZde2NvCh4vqZdX1TM
IE7VHvW+KfxfAALB8G45UdQxc4VmMaW6J59tFoJTJle8pf6gdQV3rskM1m/ML5pv
TaVQKymlaybvhDP0sIRBqczm+rQOT+XyjLmcbYqRwPpCDXH0Ssk=
=Mbza
-----END PGP SIGNATURE-----

--36qeumywz7deknmz--