Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1832266imw; Sat, 16 Jul 2022 16:20:10 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vI+kbh1icHsPa4vQH7yF+esTyZJ9GquSio+B/2U9Q3nQeQwkBV8tYBJhXg7xAG0C6euNFZ X-Received: by 2002:a05:6402:1658:b0:43a:91cd:2ffb with SMTP id s24-20020a056402165800b0043a91cd2ffbmr27408528edx.277.1658013610407; Sat, 16 Jul 2022 16:20:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658013610; cv=none; d=google.com; s=arc-20160816; b=ht48ArdG9AzSQh7RuYUHr26i9R/k9mCo8xRT5iim6coX95zuPE/WbaK1p5Dnw2az2m BxqqwPJzQYC0DhK9QRIBFtfd6OURVSRhzKHWzqEtnL6h90sPb0nA+ubKlSoNDnA02LlY XU6NezujubCAlvh9W+lFpPOXm8hA0tlCyoofvzziGnTRMl+pM6Z8O1ThkmomMHiaNP8W dEDSZ3UBFRbccgPL6sx6jbRTd/K4GyZ7KJhC5nChVZq045IgCZ6M5V9fJlLMmZOparXm in+f7K2edUvOslJLSy1MqepAVx9HQz5u+R/dUwZJxCZ6n5BQV1pZEYzTC1Z8Xk5uYuHC lzEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=HpmwuGNovGo47P809SY+5iM/RPE9nY5KEl2jrra4VzI=; b=recFdhC3yKcPGb99aC4atZL4pXaOQFHxjW+vgriVCcusc4fUmgCfg4Qvtws24E8zIV u/LOPAyLmccnTFHUoPITTlQRPX9YH0+gOd25i/OHS8ln7dTfRDEQ7qKw87+X1yM0xhaU uNO/jGdtkZk/wMiXujxcZTkA5LZgS857jTCCHDw4BfBO4vxo01Vl/AOrBUcshZ0vhuCk NCnG7BxvawW72rgpnV/cufeKQU5gG1GhU7CutXIqRuAGLVNY34TGPKNdwxGmqkGsmKei 2O37w8df5Aetb3gkDHjXMJ8pyNLlb9gKTgjcGt5y2YgIxx0Ie9+hRoHXDx4D2aI+HJHT 8eZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=skFOje2P; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w9-20020a05640234c900b00436c8577a9bsi11903432edc.464.2022.07.16.16.19.46; Sat, 16 Jul 2022 16:20:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=skFOje2P; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232841AbiGPXSC (ORCPT + 99 others); Sat, 16 Jul 2022 19:18:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232965AbiGPXRl (ORCPT ); Sat, 16 Jul 2022 19:17:41 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70D6423174 for ; Sat, 16 Jul 2022 16:17:32 -0700 (PDT) Message-ID: <20220716230953.385846695@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1658013449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=HpmwuGNovGo47P809SY+5iM/RPE9nY5KEl2jrra4VzI=; b=skFOje2PrLR0pdzlqKwbqANdn8WzvZLOy8Phznr0Jo/t1Bocx31+VVWh9hN5dFsEpuXdff BCapJFj4JPfdDoKHCGo7zOrSX3qnMQLA1r+6B9M3+747uP1Q6e5cOVQDura2n1qjQSL8WP 1L9QwUyy2E0Q6hG+r9FAprnCBPyzSSkQ/E+LulTvNYhjBPwCEcA89Coh7DnKaUrcug6K3f 0i85XosdVhbFsSm0jAaV/DaQXER+fJJP3XqXfUTRN10eoBQvH96Dxoscm/CIlEA9YSX68/ 5dMqn6cgcmHOxGA5x2KvOhEsX4AntonvlOTfx3hYt0J4gtINm3xGXBq0wENGzA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1658013449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=HpmwuGNovGo47P809SY+5iM/RPE9nY5KEl2jrra4VzI=; b=Y6ouY3ChRBWW4VLRhuyDj7T4uHASNMiMDjeRWDOZ05p/XoU+ZQBP6Z08vCEW75PuhBQ1mD rTjeAuMs85bj3TCg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Linus Torvalds , Tim Chen , Josh Poimboeuf , Andrew Cooper , Pawan Gupta , Johannes Wikner , Alyssa Milburn , Jann Horn , "H.J. Lu" , Joao Moreira , Joseph Nuzman , Steven Rostedt , "Peter Zijlstra (Intel)" Subject: [patch 12/38] x86/entry: Make sync_regs() invocation a tail call References: <20220716230344.239749011@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sun, 17 Jul 2022 01:17:29 +0200 (CEST) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra No point in having a call there. Spare the call/ret overhead. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Thomas Gleixner --- arch/x86/entry/entry_64.S | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -1060,11 +1060,8 @@ SYM_CODE_START_LOCAL(error_entry) UNTRAIN_RET leaq 8(%rsp), %rdi /* arg0 = pt_regs pointer */ -.Lerror_entry_from_usermode_after_swapgs: - /* Put us onto the real thread stack. */ - call sync_regs - RET + jmp sync_regs /* * There are two places in the kernel that can potentially fault with @@ -1122,7 +1119,7 @@ SYM_CODE_START_LOCAL(error_entry) leaq 8(%rsp), %rdi /* arg0 = pt_regs pointer */ call fixup_bad_iret mov %rax, %rdi - jmp .Lerror_entry_from_usermode_after_swapgs + jmp sync_regs SYM_CODE_END(error_entry) SYM_CODE_START_LOCAL(error_return)