Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7cb1bd2f-1361-ca6e-7c94-d82596a8a3be@fb.com>
Date:   Sat, 16 Jul 2022 19:04:40 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH bpf-next 4/5] samples: bpf: Unify memory address casting
 operation style
Content-Language: en-US
To:     Pu Lehui <pulehui@huawei.com>, bpf@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Quentin Monnet <quentin@isovalent.com>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>
References: <20220716125108.1011206-1-pulehui@huawei.com>
 <20220716125108.1011206-5-pulehui@huawei.com>
From:   Yonghong Song <yhs@fb.com>
In-Reply-To: <20220716125108.1011206-5-pulehui@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGNHNWdUbFdkeWRTd0sxK2VNSFZxT3JWKzFCSklnTk05VlE2ZTR3TnQzcmcr?=
 =?utf-8?B?TFZCeUNFSjRPVDQ1aXRDcGkzK2U5Z3AvcDhDdW1SVjV0MmI5b093dzFFWG1x?=
 =?utf-8?B?ZnEzMTJJTzVIanpvWDhMRlh5ZmJabzNHNFBTbHFoaDhXbFprNG9MRERXQm5n?=
 =?utf-8?B?bEkzeHRvczk5anZSTCs4V0VaRkhIWC91SWtiMmhhSGNRdGw4cGN5bDlrYWhJ?=
 =?utf-8?B?akRVbFJRMjgyUU90WTVhUVFXK3RBV2ZCaStEMGZONHlVcWtoQTZBSkZGOWRj?=
 =?utf-8?B?R1AyZm16OW5Tajd0WW5KMWlORmRtaXkrMERmQzk3RDBTeWszUktxQTUycE5q?=
 =?utf-8?B?ZWJoZ1RpclFwS2lyTXdmUmRRTmdlUFJ3Y3lsbFh5c1ZXNTRpUlkzeE5aVlhi?=
 =?utf-8?B?aTBhcFlDdmg1RE9BK00veGdpRWY4citZcWVIL3NuUE1wTitEamFGVEgrN1d5?=
 =?utf-8?B?WWtEVW9qOVl4bFF2TElQaGVqSFR1eGFQVEJucG04VmJaVFFiMVBBRVlQRGhE?=
 =?utf-8?B?UTNrYUZRanFVSXIxcmZ3RldwUFNzMy9pdytXVUdOUkhEMHczN0FYRUh0Tml6?=
 =?utf-8?B?U0FSNnBHc1p1dTBnMEhBQk51dXhUdkxkUS8vcytMRVZIcVVleDRPZE54WlJt?=
 =?utf-8?B?RndNNG9GbDBIUHpPUGoxd0VnaWF6cWZpWm1iT0g4L0JlNlVSVDlHTW51MEtz?=
 =?utf-8?B?NzZGM1pERVJvaU01a21CdzBNdXAzdVNnVVU1MHFOb0pRc1RSTlVISVZtbnRt?=
 =?utf-8?B?YlJWQmVQNzVIa0hrSTVPZXptUFdSOC9yRlhKNWg3ZWVZS3NhQWw1UjJNenhp?=
 =?utf-8?B?MjRITFdpQnE0T3BVcVFFWWZRWHh0OUhiZkxhUHk3WTM1Ty84aUVUcWthQk5k?=
 =?utf-8?B?SURTZ1RNTTg4QUJWTjI0YXZUbUVQZjl6M2FwcEduSGJ6dHI3SFlGSjYzNkxW?=
 =?utf-8?B?N2lMVmNJL3crSk9zdi82N1pKNGg2U044SnZxRWdQTWhTZTl5eFBnQWtjdDE4?=
 =?utf-8?B?V3BHTHNDc2xzU1VOVk51M1B3Y1NmVXJSVkZDeU1VTDZPYmlHbjZPNjdxVzds?=
 =?utf-8?B?Sk1VSmd1OWlZZ0Rlcys3NFB5VEgyTy84Q1lkZzBQM1pqdXRhTWQ0ZEcraW8z?=
 =?utf-8?B?aXNFb1ZZQ2E5eUZZdGhsK1lhYnNlWExtelUwd3Z1cjZiYlFMYW1LMmhwc3Y4?=
 =?utf-8?B?ZlRFTTA0WU9WOCtmOTRQeUhaMmZONjN5c3RMUlM0STRaU1pBcXliRlNLK0Zz?=
 =?utf-8?B?cmNzVnJVREhRVS9RTnRxV2ZrSnZ5MHdtZ2lFK2h3ZmNSd2VYWWhIcUVzNmdK?=
 =?utf-8?B?QjgwU2ZCbE1ENWEyREJvWitDbjZwSEJPam1nY25kdTU5T0MvVnpVakRTdTUy?=
 =?utf-8?B?and2SWFxcGFiejlJUmVlQ1dNbjVwMG5MYi9ndldCQ09ndkNUMnN5a0JVOVJv?=
 =?utf-8?B?V1RKR1VobHR1b0JJQkdOeUg0aTlhcGN5c0JySzdGRFNBdW8yQmRoQS9WR1Az?=
 =?utf-8?B?cDh2WUVkZTN6aTNXM2ZGTmpBRnFiaE9lYXFqYys2aFgwL1hCdVJFVjgxdktv?=
 =?utf-8?B?MjgzeEJXQWlzcEpMUHZTS1IzN0xmaVNnMzlneG5CZDgrUE5wRlNsblZGaStw?=
 =?utf-8?B?cUd5Sm1WVDMvQzRUTFE4WEM1VVIwSDBQNGk1NUNpb1NORjVFRjYyVlJJTnUz?=
 =?utf-8?B?M3h2SjhTYUc5cml0eGtrN3h4dEhjSlV6Nlo5ZThjNHUrcGlndDBZZlhIU1kr?=
 =?utf-8?B?Z1NhRm9uWDd6WE01aDFQMldUUXZ3QU5EYkRsc0lOcmJmcjdaMEswd2hXOVA4?=
 =?utf-8?B?VkwwdHJGSG1WZW94VkpKc2RYTmdLYlhzdUk0Z2s2ZzRvakNtYkx2WXMxUXJI?=
 =?utf-8?B?L1NKeHNwc0ZOeC8rRnUwMzFpOGc3WUx1WmFIM1JaZFZqdXYxNlFacWlEdmp0?=
 =?utf-8?B?Z3o4d295NzQ5WWdIbDhwTWljZm4vWnFHYXIwSkZwbjNBOEJEUHlqUnUrMkZ3?=
 =?utf-8?B?cVBXWDk1dWZ3VGdRbSswSVhGOVQvZW5IeUdZTXg5aU0zNXRPcXc1VG5hSmdQ?=
 =?utf-8?B?ZVRkQ3l3dnNWcWZ4N0NsZlFsVjgvTWIycW13UG92THRnd2FRMHBzeXMvRHlw?=
 =?utf-8?B?Q3NLN3NrMFFONE5kcHNZRGVEYVk3ZHpScXJhVC9ZWENKV2dkZ3dkYm1WTm1P?=
 =?utf-8?B?cnc9PQ==?=
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06b69235-0aa8-4e52-1ce3-08da6798b6ba
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2022 02:04:42.6717
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kylVHAJGnhVN3ZX/Cboau4HrXE8iJ7z7C5Nv45CGnEXPehuop7SvDVNMV7FzgqY6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1404
X-Proofpoint-GUID: LJMx8M-7vCtjA1Bl3YmFEoQZCwAwGxAZ
X-Proofpoint-ORIG-GUID: LJMx8M-7vCtjA1Bl3YmFEoQZCwAwGxAZ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-16_21,2022-07-15_01,2022-06-22_01
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/16/22 5:51 AM, Pu Lehui wrote:
> Memory addresses are conceptually unsigned, (unsigned long) casting
> makes more sense, so let's make a change for conceptual uniformity
> and there is no functional change.
> 
> Signed-off-by: Pu Lehui <pulehui@huawei.com>

Acked-by: Yonghong Song <yhs@fb.com>