Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5051267d-b163-a017-4c34-bcdd2d417a67@fb.com>
Date:   Sat, 16 Jul 2022 19:04:20 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH bpf-next 3/5] selftests: bpf: Unify memory address casting
 operation style
Content-Language: en-US
To:     Pu Lehui <pulehui@huawei.com>, bpf@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Quentin Monnet <quentin@isovalent.com>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>
References: <20220716125108.1011206-1-pulehui@huawei.com>
 <20220716125108.1011206-4-pulehui@huawei.com>
From:   Yonghong Song <yhs@fb.com>
In-Reply-To: <20220716125108.1011206-4-pulehui@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGsrdXdvVmhGZHNMMk8yakRvdXVmMDEzYURmVEVmZk1EWndxaW5saEpOREVB?=
 =?utf-8?B?SnVkSGVjM1FBN1hPQndYVTZZVEVkSXd0VHFjVXdXdDZFcDFQcG5USjk4bWxx?=
 =?utf-8?B?NFE5VnRkVmRFY0MrTzIwTDBvOXhDOWRFaUIvNnpMUzcvbC9CRHZ3K005TGZp?=
 =?utf-8?B?emZVSHN3a0JVR2ordkFITmtOY2VkUVpaNERqejIwc0NhUTJEQXdJekh2TnhU?=
 =?utf-8?B?YUhPVjZEZCswbXowZGN3UlR5VUVEWGJ0R051eTlkWXBVdGx4SlZzcXhWc29o?=
 =?utf-8?B?NnpjdHJYY1Yzc2JLY1l0MjhNMmVNOVNraTh1YWY4NFEwMEdBdlQveWZtdXdQ?=
 =?utf-8?B?V1ZkQlZmdlBnaFRlM2ZQcDFlcXFyZFY3enBXYVl4NTF2d00xclhQQTdLb1lG?=
 =?utf-8?B?eXM1ZXVLb3V6LzRYMUQ2b3ZSR3BuRGJndVdLOU9ja2tWR1N3UEpzZnAvbG50?=
 =?utf-8?B?dVhGK2gyaklKWU5qUmsvR0VBeHo0SjMrNUZzejZ0QUFqa2ZTYjBNOTlmVUVT?=
 =?utf-8?B?N1AxYisvYkdBTElKSWh5QlZlWGZ5QzdMZE9MYkJGZk52RkFzUE5zY1JhS3B6?=
 =?utf-8?B?Z3hRWS9KdHF5WWlPNFV2OFIzUXRKczFnT0daQXI2K3JGeEpkSUxrNUVPVDA0?=
 =?utf-8?B?bmlBNXlVWHl1MXc1Zy9iTE1Rb2xmYm5YdGhIQ21OVDVuRVJCdW8vZTNqYXlz?=
 =?utf-8?B?WktxTmNCMTExZHlVUzl4WjVDVDBiRWJ3bHVEbEQ0OTM1Wm5SVGRKZW4zL0s5?=
 =?utf-8?B?cE9aYXk1WDJpc3VNN0VQZkt3VzFoTjZwTXB0bDRhc2tLVVR3KytRSWN6RHp2?=
 =?utf-8?B?Z3lHWDgrMFVQZE1tYjlXMDBIY3RuanpmSVo3VUR0THpHd3JLeWdWaytKQ3BO?=
 =?utf-8?B?YjhiOTNEc3ZBeGRodHM2UW5hZFJqNk9lOGxyZ0tEeXlibDR1UHFraExTTW50?=
 =?utf-8?B?QytkemZmL3BDcXJXdWR5bnBaK2FncStwUGdzRVBWU3V5NkFJVk5LL25XNm9a?=
 =?utf-8?B?ajUvMEJERllYMjVTTytQVnpZdVpMbEJXdFozZWVGQ3gxRGp3TEI2aVRyck0x?=
 =?utf-8?B?SlhNSWl5NmhHeFNiR1JnMzNIMTBlUi9wYWNpOWU1QUFwZE5sRHh2TEk2anB1?=
 =?utf-8?B?cEc3Mkl5WHBmYllWU1dkSmFrRmJFWWg5K2dBdWdCekJNQW9oeUN0VXlaUjVT?=
 =?utf-8?B?NWs1MnhIV0dHUkFFL1lERFMxLzMyTU9vWXRka3RlclN1NGpRMzNNZHBpTWUz?=
 =?utf-8?B?amdoN25Sc0Zycll3cEoxbEs3dHFDenREZDZ1aHRqUXFzUEVvSk8yODVlOUlr?=
 =?utf-8?B?WTllZHNSOEFvbmVRT0NmOTNJU3BsaXprTHlNR2tsNFdFMzBQQ3BmQnRSZVk5?=
 =?utf-8?B?VUdLc2JycnJZSmJpRGdtb25vcjBURi81RVlUZzI2THBiNmM4MVIwTUNzWVJx?=
 =?utf-8?B?ZGlQbjZ2dis5bE9Eb0JYVzQxSkdiUTBmSWxsMkJzRDhPd2xZc3ZtcHZqcTRx?=
 =?utf-8?B?bzMwNzRLOElzMXB0WklFTmFpN0VUd3pzZEVBbm92UWZtNHZuakJyNlZyTkNv?=
 =?utf-8?B?WW55dC9ubkZCS0psTjZzY2M1N0dobzBxWFZ0U2ptYlpWY2tITGl2bldYVXNz?=
 =?utf-8?B?bWtsbTBuM21hQUo3dnZxS2w5Sk9TNXBWaUh6TUlZelZLUXRhdTlwWUxBMWZ2?=
 =?utf-8?B?V1hVMFJGWDVSN3BrbEQ3akVKd0taS1JOTmxuWVhhcmJaaEpiQzlETk5kdHdF?=
 =?utf-8?B?aTljYWhJeE5qa0w3SlB6bXQ0MFRtNHFlVVNKa0prTjZIR3NUQStmUE1rVUxw?=
 =?utf-8?B?ZHczMmZvc1pHMzdGZ2cyb2lJMFdqOGVKWDBTOVlrbVIzREJ1WE94UUpLZkdp?=
 =?utf-8?B?QzlYK3N2UFNEaDM5aCtRSjZxclRUdGxVU256dC9OVXFGVFZWQUJkcE43bHR4?=
 =?utf-8?B?YmRTTnJLSzkrWmZrV1NORnoxdnBQT3QwQjF2bndVMU1EYUt4TWtONG5Hem8w?=
 =?utf-8?B?c0FFelZxa09RK0I2dlBDSDFBTWk5ZEJ1aTh0UitHNE5OSC8rekxxQkludFlJ?=
 =?utf-8?B?TnorTGE3enBteU01VzgyczNhOGRXTTU3R0E4eTk0Z0YrQ08wbnJEZC9PcENJ?=
 =?utf-8?B?MldXS2d0NFVSWFVFMXdmMEVORDBHazQvU0tON2R2a0NLaVVNRThPZHZTV3ZR?=
 =?utf-8?B?S3c9PQ==?=
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1dac4eb-6dbe-4c31-ec70-08da6798ab0e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2022 02:04:23.0168
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bx2jGiNieXA67qQb+OnzyYclCW8RC5xxcgvkn+1ANEMEH3d3Oe6RmtzSoPvpb+Vd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1404
X-Proofpoint-GUID: kvUWAhhhAkEeDn0ve9b7cUxLS5lr-V6b
X-Proofpoint-ORIG-GUID: kvUWAhhhAkEeDn0ve9b7cUxLS5lr-V6b
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-16_21,2022-07-15_01,2022-06-22_01
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/16/22 5:51 AM, Pu Lehui wrote:
> Memory addresses are conceptually unsigned, (unsigned long) casting
> makes more sense, so let's make a change for conceptual uniformity
> and there is no functional change.
> 
> Signed-off-by: Pu Lehui <pulehui@huawei.com>

Acked-by: Yonghong Song <yhs@fb.com>