Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yu Zhao <yuzhao@google.com>, Hugh Dickins <hughd@google.com>
Subject: [PATCH v11 19/69] xen: use vma_lookup() in privcmd_ioctl_mmap()
Thread-Topic: [PATCH v11 19/69] xen: use vma_lookup() in privcmd_ioctl_mmap()
Thread-Index: AQHYmYdydKZaEL4iMUKumanZYpAkUg==
Date:   Sun, 17 Jul 2022 02:46:43 +0000
Message-ID: <20220717024615.2106835-20-Liam.Howlett@oracle.com>
References: <20220717024615.2106835-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220717024615.2106835-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Tr968TIgftuBWKYHZu1weDgk231DIMk/ukni9uqTOVZAmEBnDoyaR9MnnJ?=
 =?iso-8859-1?Q?sQ9hhe49C6D5E5YEA0EO+QUpeD6UMG1CyS9MaA8XtlabGFLfJSLW1zjaIy?=
 =?iso-8859-1?Q?13KN4axILZizqoz4xtfI5k7OXEwm1UnKuENAJOXPaOrakrx6E09UGBYFv8?=
 =?iso-8859-1?Q?wn8ToJY9DWL5AzuM5iOBgev/MO+eZ+6Et2CggLSzDnuiGw1DNaKf5eOj1/?=
 =?iso-8859-1?Q?6UgIn3fczxwVJIAzh3ANVqMWSIDtqTJWiVFhBdYb+BVo728ziF9iGOJCRJ?=
 =?iso-8859-1?Q?YI77rVwAReH1SRRBOv2XAd414nv3mU5VxMoP/CDtg0z2Cmkw6qeijN495y?=
 =?iso-8859-1?Q?/7MDbUsg1QWUFyqWuIre0KhQPwVzXSzoH/fCv96nVsduPvTJvQ5yPEefu/?=
 =?iso-8859-1?Q?ECLR4zCWpbXnInPI6pMiG+qHUYLDoNQZ5cjjUSQo+OJ1ojMg0TfdT2EzKM?=
 =?iso-8859-1?Q?fHRcV8VCWmHHkULCf4n043rJWtPd5uJl187qGusGfaJ+ILdp9jwISdGNx2?=
 =?iso-8859-1?Q?nh/sQyCNVIt8wipbl5B3i82UYLe1QUq6oAmQJ76XfiZsmUmCLn6iT7M+UC?=
 =?iso-8859-1?Q?NQeuwXOBdu2pHCXi6Fv3wMzrDXiS551QvrsfIY5VKcxxXfiH76VLr1zuEL?=
 =?iso-8859-1?Q?XhiPNl1WUCXyUGWXd9LRrflZILBlXpCjlpmQ/Ucep5H7u6lsmVRcV/80Lb?=
 =?iso-8859-1?Q?yf88mg+eCSV1Cw+2Zi8nkbwFZNV38Hx74nVR5C4Ks1HF+WrvX3ZcJQUSKK?=
 =?iso-8859-1?Q?id5HPpCNV1DcrKiGJ3lxJjXytlKxwnefQssR5SaYJMyRzpj3HpXQXXmfCp?=
 =?iso-8859-1?Q?wy/5gHL8MTvN5C1hGTAmbpM0sgZLMPfc9w8ypszDXR+OtRSiNF6mKRrBb8?=
 =?iso-8859-1?Q?wjhtPaREufILO6XtAPYwf39D2tTGGg/NFXHuMHsAXjB9Q5u2ITJqYdRUsW?=
 =?iso-8859-1?Q?dsE3AVZzt7nysJlnt7eZ7CV3HajITqT6+roJTN51BzMQS1KI7MiWbKIbCO?=
 =?iso-8859-1?Q?8+S7FyBbzUgdTx0iyWjoINsdjvHHX74g0J0Us53aLLdUHSTsziVUFT6w62?=
 =?iso-8859-1?Q?vuVoSLvVX6UT9O4l4KstL4XuUkwv4UUDmkOdRtZC+KjGncEUPNZE05BDxj?=
 =?iso-8859-1?Q?GCf0Ro9J+XqJ6rgRLuiluhjmvQMzg9wxbybJ2rYtIV4exTo8WjEVA/KPhG?=
 =?iso-8859-1?Q?+beC7+pqtKKc2p63rXQ95YPvsqt4PX/n6JRZhGm3Kfv9EZc1OVwIn/vJec?=
 =?iso-8859-1?Q?ouwNy8kU3qGlFslRLv8/SAkWBoa/xS20M1JZOcVDwVnFZF0s9YmxB1yl5x?=
 =?iso-8859-1?Q?kaucIQuGjMSyIO/knxi+Sa3i7ASijaLndzUZftrv3A1S3lbMVjzxZY5Mh6?=
 =?iso-8859-1?Q?QqThAv9tmfB9nBmH36iEflA+Mg/BHQNYFkUYIcT4WMfdM1d4iHlbx0IhQV?=
 =?iso-8859-1?Q?Qz4vs1CpJbG2yb4wk2kSbt1/hGzKU14gCvHEebxjXoTtgZQosJVmvWuhum?=
 =?iso-8859-1?Q?7iRR1yAOcXyTQeW9mS0o7TPFJqCrB+hWksu+mVJEdq/9aDfWAmMrud1WEQ?=
 =?iso-8859-1?Q?7AdaHasfAo8loUOWbog989h2V+bWHD+BIHy+Aao1OG9HCWodTOSpPB8eSV?=
 =?iso-8859-1?Q?ftWaifucgZ2D4H1OjA6Y7NWiNkIBTqeAcSQu5euKv0ZJgA11tHcfBGnA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee56d129-7e49-4bf2-e10e-08da679e9707
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2022 02:46:43.0062
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bEjIeVgibHynZoJu+gZY79EUBYFyzYQMilTB4sCN78Ip91lw9aDHTBje/cqj1cGnHbuXs61q1RFNo/uTpqeInA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2908
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-17_01,2022-07-15_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 mlxlogscore=999
 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207170010
X-Proofpoint-GUID: vOLhhk8-E_nB6ARXEO_yJ8ej8FncojFq
X-Proofpoint-ORIG-GUID: vOLhhk8-E_nB6ARXEO_yJ8ej8FncojFq
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>

vma_lookup() walks the VMA tree for a specific value, find_vma() will
search the tree after walking to a specific value.  It is more efficient
to only walk to the requested value since privcmd_ioctl_mmap() will exit
the loop if vm_start !=3D msg->va.

Link: https://lkml.kernel.org/r/20220504011345.662299-4-Liam.Howlett@oracle=
.com
Link: https://lkml.kernel.org/r/20220621204632.3370049-20-Liam.Howlett@orac=
le.com
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Howells <dhowells@redhat.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: SeongJae Park <sj@kernel.org>
Cc: Will Deacon <will@kernel.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
 drivers/xen/privcmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index 3369734108af..ad17166b0ef6 100644
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -282,7 +282,7 @@ static long privcmd_ioctl_mmap(struct file *file, void =
__user *udata)
 						     struct page, lru);
 		struct privcmd_mmap_entry *msg =3D page_address(page);
=20
-		vma =3D find_vma(mm, msg->va);
+		vma =3D vma_lookup(mm, msg->va);
 		rc =3D -EINVAL;
=20
 		if (!vma || (msg->va !=3D vma->vm_start) || vma->vm_private_data)
--=20
2.35.1