Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yu Zhao <yuzhao@google.com>, Hugh Dickins <hughd@google.com>
Subject: [PATCH v11 50/69] bpf: remove VMA linked list
Thread-Topic: [PATCH v11 50/69] bpf: remove VMA linked list
Thread-Index: AQHYmYd5wamGPPBm3U2JfrRAKWaldw==
Date:   Sun, 17 Jul 2022 02:46:53 +0000
Message-ID: <20220717024615.2106835-51-Liam.Howlett@oracle.com>
References: <20220717024615.2106835-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220717024615.2106835-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?vJii79FttELkkr92ZVNuOahcsgMrKKJynh2oG4p8sqnC0argw3+VuAzKdD?=
 =?iso-8859-1?Q?k+4FbBievMvBWqQoXzX9pK93lGx1EPHeTRmt2wjT+cE5B6xlOggaWClDlL?=
 =?iso-8859-1?Q?FMuYld9HoeZe+1ME4qsCn3+KP3nWlkTCDbbaMrMV9hcsr55+xqUITALmNz?=
 =?iso-8859-1?Q?XLkjZTUu+aSXhKojrQkNuj+vrPID3akf0tUE4yRD16ftPJS9U/yxSaM3/3?=
 =?iso-8859-1?Q?DImAjaRuZ9BcDolLHGL/4ygzi3H4C0gB+/XNWd693gZFN+J3kXX3uUJYJ3?=
 =?iso-8859-1?Q?R42i5OrUq6G8zcIigf02pgD8nvqsxKEhRNTy/iduKkjKEF9BobllDz9U6T?=
 =?iso-8859-1?Q?iajy+nhATn5BsMvM4d8zxH8mV5uMfH/F1UZg+MKb0vIgSSuoLQ/XcV1f/A?=
 =?iso-8859-1?Q?Lx6may0yRf9TId1TTxC99/2o2u0ucv7ILH0TVz82qIRSIR52fjIieoF+fC?=
 =?iso-8859-1?Q?3lA66CI6nufDvu6OHc+2kboi+VZA3+x4DGCOuxUqwXycrPj5yffdIJJhgr?=
 =?iso-8859-1?Q?BcZamGQSVKux1QxROn6KJvE023qPPeHbcly6D9plmWFodbjktp9vQKpwJO?=
 =?iso-8859-1?Q?G8bmSDtl8I4o2ikOiuq5XLuzhIrJXWu22vri+uyYuDvzfkKK7HMPnGpWBi?=
 =?iso-8859-1?Q?iH3125L5SxQG2qi5BiPzV+gygxHUVdndwrNU6m9o6p9bbPwB3wAcfi3vGE?=
 =?iso-8859-1?Q?0j1dckrxtl1JRgpdbwRrWkcj6+z36ZUKSMzjYsQKzbqLKybwkMMKMC2UQY?=
 =?iso-8859-1?Q?N3XTYjO1wyAEkSTmMbgIZKk6M101SZaBlPZMqruht/wHHfl0RX98eZ7hf4?=
 =?iso-8859-1?Q?L1fACd5k2Cp66gkjubm3+V+d6PeqRjXXMIyWkDXhNI3nqU8Tyu7uiTHjVc?=
 =?iso-8859-1?Q?U4OIB/zDJAiPafMJ/ZctzWRXFKzYxLA/MG5UqMxPmitLbE7WLYLxQyJSsc?=
 =?iso-8859-1?Q?SGRB9cE9nagD3MdoYvgf4Zj0Id562erB9/ZAPrSSQ04EFUFZMFFqaeB9F7?=
 =?iso-8859-1?Q?90GLOmHXruhsaGpAvHIGG07aaYIt3LzXTdRtbZoK4YEwzLd85tL0i5cXQ6?=
 =?iso-8859-1?Q?OwqsjJL1xfXnSvNXajcu6LxY3H9q1v3/yWAmEo2XxM0fvM3e/SN9k7iHPD?=
 =?iso-8859-1?Q?oLPOzZR4ZXiJvqJ7p1KLQAHvrc0bv7qe3CeK8y7qSqkTe2N+g/Bcqvm2q2?=
 =?iso-8859-1?Q?h/A0vJZyepf0CPT1Ys1TLObmKEkYEXG7H7mxSoyBPvampi++iAIWl3+uZf?=
 =?iso-8859-1?Q?LNKM81S3rMZJ8oM1hU86/X2oFCMePmbr8HfvsgL+IToEjb7dIZUg3DbqA2?=
 =?iso-8859-1?Q?DFJlCOrcCBWdy2LEzSMwVdOTuoRX78Ieo/NFKU6y62TAcoz5NwNjddmvdZ?=
 =?iso-8859-1?Q?5z0X3lFgdw2W89DV2l2G4mG6GjQCFJdzOyL9fyOy6yVnLLBNzY+IKyH3yP?=
 =?iso-8859-1?Q?UjzoNHm6gdvDPdzs0lvX5kzUNY6vDknnL1gY8uPJbrwGgb/OdhV4HcNvSn?=
 =?iso-8859-1?Q?LRDLcj/SC8hDnFQ2uIBwlK3zw1oAopoQE9jttn89FehBD/iAaoEwIB0wXW?=
 =?iso-8859-1?Q?TSfotZfiM9UHd00Dsg8a3SqqXs+xB/K9FJ0+s4ZFJgOvrsR9GUZq+bhJ6S?=
 =?iso-8859-1?Q?/ZNG2RMp0KY5o0ZNgf4Gu3JDSaNH3TRywx6SVfik1mYV3YEzNOxanCjg?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01e80d68-746c-40f2-d295-08da679eb169
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2022 02:46:53.7554
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oln5wCFD0d6trpJ4OhOvYeO5avKlNm3aLOwWE87x6/RofC/SIj/GotVAshKmQd3EN7DdJV2papJjFI0tk1wBDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4504
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-17_01,2022-07-15_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 mlxlogscore=999
 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207170010
X-Proofpoint-GUID: LoE4k_KlLtknNMYSmF5I5ZR6hIRb7Qw7
X-Proofpoint-ORIG-GUID: LoE4k_KlLtknNMYSmF5I5ZR6hIRb7Qw7
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>

Use vma_next() and remove reference to the start of the linked list

Link: https://lkml.kernel.org/r/20220504011345.662299-35-Liam.Howlett@oracl=
e.com
Link: https://lkml.kernel.org/r/20220621204632.3370049-51-Liam.Howlett@orac=
le.com
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Howells <dhowells@redhat.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: SeongJae Park <sj@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Will Deacon <will@kernel.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
 kernel/bpf/task_iter.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/bpf/task_iter.c b/kernel/bpf/task_iter.c
index 8c921799def4..1c8debd42dc9 100644
--- a/kernel/bpf/task_iter.c
+++ b/kernel/bpf/task_iter.c
@@ -299,8 +299,8 @@ struct bpf_iter_seq_task_vma_info {
 };
=20
 enum bpf_task_vma_iter_find_op {
-	task_vma_iter_first_vma,   /* use mm->mmap */
-	task_vma_iter_next_vma,    /* use curr_vma->vm_next */
+	task_vma_iter_first_vma,   /* use find_vma() with addr 0 */
+	task_vma_iter_next_vma,    /* use vma_next() with curr_vma */
 	task_vma_iter_find_vma,    /* use find_vma() to find next vma */
 };
=20
@@ -400,10 +400,10 @@ task_vma_seq_get_next(struct bpf_iter_seq_task_vma_in=
fo *info)
=20
 	switch (op) {
 	case task_vma_iter_first_vma:
-		curr_vma =3D curr_task->mm->mmap;
+		curr_vma =3D find_vma(curr_task->mm, 0);
 		break;
 	case task_vma_iter_next_vma:
-		curr_vma =3D curr_vma->vm_next;
+		curr_vma =3D find_vma(curr_task->mm, curr_vma->vm_end);
 		break;
 	case task_vma_iter_find_vma:
 		/* We dropped mmap_lock so it is necessary to use find_vma
@@ -417,7 +417,7 @@ task_vma_seq_get_next(struct bpf_iter_seq_task_vma_info=
 *info)
 		if (curr_vma &&
 		    curr_vma->vm_start =3D=3D info->prev_vm_start &&
 		    curr_vma->vm_end =3D=3D info->prev_vm_end)
-			curr_vma =3D curr_vma->vm_next;
+			curr_vma =3D find_vma(curr_task->mm, curr_vma->vm_end);
 		break;
 	}
 	if (!curr_vma) {
--=20
2.35.1