Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yu Zhao <yuzhao@google.com>, Hugh Dickins <hughd@google.com>
Subject: [PATCH v11 46/69] acct: use VMA iterator instead of linked list
Thread-Topic: [PATCH v11 46/69] acct: use VMA iterator instead of linked list
Thread-Index: AQHYmYd4gmBn0AwVuUqS9aAZQjbPrA==
Date:   Sun, 17 Jul 2022 02:46:52 +0000
Message-ID: <20220717024615.2106835-47-Liam.Howlett@oracle.com>
References: <20220717024615.2106835-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220717024615.2106835-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?SafM488FpLLM3nREN34mt89mBcfbzKlIXwDrQsrff9Ni8Rkt+VPgCLWWe6?=
 =?iso-8859-1?Q?FWN+xihiXGTY5u0vpwgxSGpfxbh9fQ7UD0pKw79TGzb9+pxeB/o/9HwVta?=
 =?iso-8859-1?Q?A6B1VNivnUJVj9UsMzMgasFwJM3GLhd0mGo+9ZeP4AQWQLvswuzdurh+wg?=
 =?iso-8859-1?Q?JUojbB1HuD4XlDF+X3xnKVAXzbzAbJHhgekhHzNVLcu6Cv1aiUM54CVo0B?=
 =?iso-8859-1?Q?tHjXxE3hv0+98JTmNvxffJ8ZmtpqtLDjpDlSt1rw7fra+92GdP/R9+fAhg?=
 =?iso-8859-1?Q?tTugm8xdLfPwppG7HevEFW25LSrAz6eU9N3v7PoE23Cootnb9amSKTKOvY?=
 =?iso-8859-1?Q?Syj7eKm7ygUMyG0rT+yK0+TeBuw92Ts5OxYM6+5AFiNoSTMohv9Ohbw72h?=
 =?iso-8859-1?Q?wZQSNB/gS6mUwuma9K1K9ow3qIrJk7sWwSmXrh/xKFig0f4E7z2y+Li8I8?=
 =?iso-8859-1?Q?bbpML2eBGksFvtA6Q4BKXtGJRBIP+vZnF5cY8Ak8xUxdnUcEssx48UqrHZ?=
 =?iso-8859-1?Q?BtJsmYRmoc6Q2aPqRHYOaJZbN6nHl6qQvkoBtPtGSbJZ8HidULy3dOKzIe?=
 =?iso-8859-1?Q?JENINPfX9LNuYvPPpFuofJg1ysnwM49U+2XDqq99hpvq1fvO0qw7osObEW?=
 =?iso-8859-1?Q?C1HM07M4gzwHu66ySe2zeSlXIbDmq1xF7PeBdDarmLCyhfXUvFNZYKuXbz?=
 =?iso-8859-1?Q?hothLAHyrQij3Vz/TjI1K0iXKXw5lla9T0REc7QUS75aWaWa1zUW6E1a/C?=
 =?iso-8859-1?Q?BbwqKpFrBHc3WK+xa7FWYOEAQXTmMs4oTvThgIppE8zd7OlA5tIWnDmuPR?=
 =?iso-8859-1?Q?jOX3z8H0icfu+pHxXUWNjXxwei0ASl5elDg1h9zkmwbLs45PVwFbYjNm0/?=
 =?iso-8859-1?Q?8yOLgOVbU0MewzThcb03VoPPktgujsV3Pu/Zn7xNNChTlAVWb6x3H/F1aZ?=
 =?iso-8859-1?Q?gtyMgUvAG1MZ9c6B4lJxGcC0Jw9cHJ+Xmw4Zdtl86n7ycu/EV3gF7/WmEu?=
 =?iso-8859-1?Q?c8f08CJ1LMVb+BFqXjhm/IKXK9VQ5lyYzZs3VkVdctAOPSArosg2h+OIY5?=
 =?iso-8859-1?Q?P8/ieoN8mDLQve52gUkajsguV8qjPVEDupl50WdRPeNXDMxzu/EqAaazHc?=
 =?iso-8859-1?Q?OBRn2sK48Qc2b32oF9BIGOR/9DdwYPGDBaJ/UkfTatYefNCg+2cKYIoA/I?=
 =?iso-8859-1?Q?ccWMUBiS59xxxtkzWIkNVXyw1Imolf091sZfksbjhQ8Y8cbmvqieBsiTce?=
 =?iso-8859-1?Q?3wLCABqmq+TT69XMLmSucCr9BiC6SUTR8K7e0KBa9kbElyTUKY6RG2340p?=
 =?iso-8859-1?Q?BuzZGNBW7NFg3NgkJgsyO8Uh1XZArXXEbqCAYUwmhC/Z3s1qsLiyTt4abf?=
 =?iso-8859-1?Q?HwT8cwHzbJQrkYw2FP7eKFmYMjY8V5nA4/PhCIb5ngamH2Ppi4rm0sbbr2?=
 =?iso-8859-1?Q?1zuf45n7HsA2GFQ7MnAlYkxlppKubdmgqZbI0Ajj1YEsSl9MejV2tccR/T?=
 =?iso-8859-1?Q?hnh0zdIEbT9b/Qdl1KHyq7ed8mIujmH1z2aTNbxtAwc7PkqSc/XD5GelLF?=
 =?iso-8859-1?Q?LSad9lW8U05OH7B3CHA17Ha8Wp6vljJg5j+c4Rp3uZfciS4g9YBf1MfICc?=
 =?iso-8859-1?Q?uc9rPYQJfFxTNQiUt10cEN7bclKT8iAwmPbUO2BIkVzZ9JPgph2SqQ8w?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c3f8a78-2238-4edd-2e36-08da679eb09f
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2022 02:46:52.5211
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: McaXO2k7+C3EH1nTT7FnAENZMICr+KNsdN+cnhuknwDsiJnKN2AlkNcTFFogUU5FPPFFhTfoKJVdeAEvj3Fn1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2799
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-17_01,2022-07-15_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 mlxlogscore=999
 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207170010
X-Proofpoint-GUID: SWuPzP10CciAeeZ8pIyZjasYHVJs3X8O
X-Proofpoint-ORIG-GUID: SWuPzP10CciAeeZ8pIyZjasYHVJs3X8O
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

The VMA iterator is faster than the linked list.

Link: https://lkml.kernel.org/r/20220504011345.662299-31-Liam.Howlett@oracl=
e.com
Link: https://lkml.kernel.org/r/20220621204632.3370049-47-Liam.Howlett@orac=
le.com
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Howells <dhowells@redhat.com>
Cc: SeongJae Park <sj@kernel.org>
Cc: Will Deacon <will@kernel.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
 kernel/acct.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/kernel/acct.c b/kernel/acct.c
index 13706356ec54..62200d799b9b 100644
--- a/kernel/acct.c
+++ b/kernel/acct.c
@@ -555,15 +555,14 @@ void acct_collect(long exitcode, int group_dead)
 	unsigned long vsize =3D 0;
=20
 	if (group_dead && current->mm) {
+		struct mm_struct *mm =3D current->mm;
+		VMA_ITERATOR(vmi, mm, 0);
 		struct vm_area_struct *vma;
=20
-		mmap_read_lock(current->mm);
-		vma =3D current->mm->mmap;
-		while (vma) {
+		mmap_read_lock(mm);
+		for_each_vma(vmi, vma)
 			vsize +=3D vma->vm_end - vma->vm_start;
-			vma =3D vma->vm_next;
-		}
-		mmap_read_unlock(current->mm);
+		mmap_read_unlock(mm);
 	}
=20
 	spin_lock_irq(&current->sighand->siglock);
--=20
2.35.1