Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1976077imw; Sat, 16 Jul 2022 20:52:29 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vZR+ELMm0JeNbKR+alGMb5tH+nftVW7FQVIUBqi/SK1z5j2aa9cOARF9cRC2cu6DyLis2L X-Received: by 2002:a17:907:6818:b0:72b:5bac:c3a3 with SMTP id qz24-20020a170907681800b0072b5bacc3a3mr20003371ejc.139.1658029949542; Sat, 16 Jul 2022 20:52:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658029949; cv=none; d=google.com; s=arc-20160816; b=dQZU6uCXOhrdSEH4OEQiyBUv1p2OI08NK0vbV2GcOvUSqzMBo87Tu3KDaFlqDSpX16 88hSISvj5rF3AeGUlHr7bL33dqrsMpA2mpXBENum0X0DMyMm8giesGfa4oZuF75VPyqA v4EdktTc18/+tFFSp4tEkvYcmVmTqbWr8jYmO8R3YZcqf73FEseQ3W7x57QNwkeUPOip DCPpkI48AwDRNFPz/ZLSwxxWnz0LZ1BbBZtWrMdGlAY0nqC9bVOygBZMZTsvgWemVeqm 5S1IqDJ+sXBI1+JnBeiFsbu2uKvVFIR1WpuHG5XXPVOJh0/7kSw6YlqLVUatIWlBFgjJ rW/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=21HY6wtQkPpfHZFWbTa1qvE3zEmY6IOji3PebPAf2LQ=; b=gdI+2NcqW4OmJOxSOYjyWtoAQybeXX8bILlDPeh1BOSXK9F3yiSHJX2QactSnVGeBl +XkTaiZ9V6wxUNG02i0+yXHKLYI0tyrlIhjBTyDs1zaQKiegBneiWB6a7SmejH/mYcCd 98jQ1lfDQ/4jYjDoiH/FTT6uUGGjg6TYUFC6XFNY/93mDSiHgpEYletIic6vFyFEM17/ bEvHretaNGTDFWhdgsEfMf8mvGuc0izN/qTa6vafukvPhVv5EDoaGZPrsLdJGOkyyvJw +G7IXrx88SNF/ioXrHDLLUbn3SByDS+2KAfAq97QgbqzHbwNFvRSml26kpfzHaEV1E7k GObA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bXo2IQlD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne1-20020a1709077b8100b0072b30f9df85si11201692ejc.675.2022.07.16.20.52.04; Sat, 16 Jul 2022 20:52:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bXo2IQlD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232964AbiGQDsU (ORCPT + 99 others); Sat, 16 Jul 2022 23:48:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232691AbiGQDsI (ORCPT ); Sat, 16 Jul 2022 23:48:08 -0400 Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F63E17E2A for ; Sat, 16 Jul 2022 20:48:07 -0700 (PDT) Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-10bf634bc50so15757475fac.3 for ; Sat, 16 Jul 2022 20:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=21HY6wtQkPpfHZFWbTa1qvE3zEmY6IOji3PebPAf2LQ=; b=bXo2IQlDVKcOFaIH1yTcLSmJgZp7Kecvs+uL31en3QWnmh+vQxvOYgRdAN9+BD2cb6 zrA2sBxbony9HyHcTYLVAuMn6njcPP1kb7ynSX9faXXxqVjbqyN8ZlSM1Jm0kmHd9IPp wcmfWaiIb3BdZfENiEo5UGOVXLXaKE8fyTJNK+DxDGDo2L+qZn7UdvVyjKaxIKLGjioz 0EVcjFa7/DM4gr+LWir8I842j3evv/7KHOD0vxcuc37FkzFPQ/L0z7qXm++r4DKMY2Is fTXJztpomi7COkPo1P9vbvQZVcjbJ+tepYIQ2w1Hnwe6/A0oPK1/tZhOfec2iAhSpEvX mVpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=21HY6wtQkPpfHZFWbTa1qvE3zEmY6IOji3PebPAf2LQ=; b=hdHXKlBmcNllpcY6FAJNbTl8wqHmSs6o/a01xEphUHKPYf7fJ7g4PAkZmADNqBp0KN wo1XZPFOBDhk2EAqUcqFDeNQmZ2cgM+Dk3DgQjr/7zbhDoervcHLkZn3MjNOhfuPqCIh FVrq0GJigBKMa0aV8xobuOYb62ipm9PF8SQcNzVfrJPuKWw6hyXd6SLxfLnvFc/b8z2B kIYXrwdpL3p9rU76ui+3DfO0KHXBSpVJsR6u/b3HgLJJBZ5G7400lkglw8y0NBgWNDW5 ap94WMujpNa/aErYq8BPEEklWOSwbV2uemCpHFr3De6/8/1/5E6hDqMncEifU8zb9SaL RgSg== X-Gm-Message-State: AJIora/2y1/6aQZ/nbrODvJ2VxrdtqyocyUcQ7Akq+ualekL2P2wSazt AdoAwX1rXf/8wLluDzkVJOh0yK+LUPVshA== X-Received: by 2002:a05:6808:23d4:b0:33a:1441:bf0 with SMTP id bq20-20020a05680823d400b0033a14410bf0mr13921813oib.26.1658029686511; Sat, 16 Jul 2022 20:48:06 -0700 (PDT) Received: from ripper.. (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id e65-20020aca3744000000b0033a169f9282sm3004515oia.52.2022.07.16.20.48.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jul 2022 20:48:05 -0700 (PDT) From: Bjorn Andersson To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Wolfram Sang Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/3] i2c: qcom-geni: Make it possible to run i2cdetect Date: Sat, 16 Jul 2022 20:50:24 -0700 Message-Id: <20220717035027.2135106-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Attempting to run i2cdetect shows that error handling in the GENI I2C driver could be better. The first issue is that errors aren't returned from the driver. Following this is an issue that if a timeout occurs the current operation is aborted, but the abort code races with the isr so the abort times out as well. Lastly when this happens, the driver is quite noisy, making it impossible to run i2cdetect on the serial console. With this series in place, I was able to run i2cdetect on the db845c and two sc8180x devices - and get useful output. Bjorn Andersson (3): i2c: qcom-geni: Use the correct return value i2c: qcom-geni: Propagate GENI_ABORT_DONE to geni_i2c_abort_xfer() i2c: qcom-geni: Silence NACK and GENI_TIMEOUT drivers/i2c/busses/i2c-qcom-geni.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) -- 2.35.1