Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Arthur Simchaev <Arthur.Simchaev@wdc.com>
To:     Arthur Simchaev <Arthur.Simchaev@wdc.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        Avi Shchislowski <Avi.Shchislowski@wdc.com>
Subject: RE: [PATCH] scsi: ufs-bsg: Remove ufs_bsg_get_query_desc_size
 function
Thread-Topic: [PATCH] scsi: ufs-bsg: Remove ufs_bsg_get_query_desc_size
 function
Thread-Index: AQHYhKDynvKkVtaQm0SrWhB5D1T9dq2Clh+w
Date:   Sun, 17 Jul 2022 11:28:07 +0000
Message-ID: <BY5PR04MB632776263A4B37AEB7373DE4ED8D9@BY5PR04MB6327.namprd04.prod.outlook.com>
References: <1655727966-31584-1-git-send-email-Arthur.Simchaev@wdc.com>
In-Reply-To: <1655727966-31584-1-git-send-email-Arthur.Simchaev@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bbDvEYYgte0m7W0dHSyTKXONLT7253off+g8F0+Eh8zYUokxNcDOdXIuT76h?=
 =?us-ascii?Q?9O9W4mv1bSID5zMtxrUJp12o4ctXo/CNaX15zg6DUkDCdJaYzG8T8dLNoi62?=
 =?us-ascii?Q?1CYnWdCcmPINlOmx0ATuMUc8U5/zAzzzl4Xy2f2GDz+Y0lv9dcl9KG0xvpBA?=
 =?us-ascii?Q?AE+kSE+Q7f5KjQ/lo4DOXoYRCHaAhgYTdhtFnnt+U1FbDGxpBIsdDD0qQr3Q?=
 =?us-ascii?Q?BDmZx8ZgHH51Q3++NcXPHa+UqY4pCxNdiTy4mng2Nj5u4YeEuWykMT0cSVNF?=
 =?us-ascii?Q?X40oRo4fXpG7eTJEySxHaSKBLWS0hyIRCrYUDznodboEqIXdRDTQIDYIHc3H?=
 =?us-ascii?Q?8LbDQX4/YaFdiA7mJrH1nA7VYrGQHV0ZjI/1pcHA9Q+HDyjY7k+Y7mDOKkHK?=
 =?us-ascii?Q?hCViNiXZV9Tm3GOOtPW0N3a1PFVJAl5putBqnW8pPmlLqK3XPtiQp9LHJ+22?=
 =?us-ascii?Q?QqkAfghtvqQg/dnyKWEk8dMlk+ujD/Bc5lBGx1+MneQXSsyZs4UnnYdvcPV7?=
 =?us-ascii?Q?arRSPzc69pglYL51AeYwGu+gxK8Szwv0pper4z65RrJI/e5chH2ZhI+bDWm/?=
 =?us-ascii?Q?cYhCPvbaRgJR1Cw/Whifs9Q2jVanQ9jAJQQHiQHRXERJ7rXW9eHpan7qL2xN?=
 =?us-ascii?Q?LKEQ8Tus67JWuAHWmBvRTlpy5JfuOBzG9iPmJQ5RA+xnj3b6dKQQAIQZyW9A?=
 =?us-ascii?Q?CiwoIRzCdTiQZGikS89W8N92LR9hKYlxCNpsAs9g/qVIBJdMWn1FdXfr78ef?=
 =?us-ascii?Q?V3IUsc3IsRL/5cQpt+vL79L8mk4nhnDrcBBheBzJAR8swYiR38DIEZhOhVVC?=
 =?us-ascii?Q?QknE7o8DzcTMhnV3ewHdTlulAhhbkINSf9ME4a+bJwQv2qhGfJFwliHS3aMg?=
 =?us-ascii?Q?iULHF2xjkmE98jUX7F5mzyxCintxbW94ycbYO7iNLX+12MOIj8NNlRhVJE1h?=
 =?us-ascii?Q?j+xUs37CM8w7KghZBYNVAd0qql9EXxJcp5tKDmodbJsEIewez22ltK1SUb9s?=
 =?us-ascii?Q?ofqg3AnGe2JvGrXTd0pnlLfQx5bUzOT4qz7DgM01oO2q9HOXACmB2vi4Cvue?=
 =?us-ascii?Q?3f84FI+gG4RONket4Nn90gU93lIIXZvSfwuauKLx+rAAcoruh+ez3+2op3GR?=
 =?us-ascii?Q?Ov4sK5YQ4F+wPZJ0j9Nw+9EvWqqAyASMyvKJKn6SG3jl1RIVYz+V95FC7Hs2?=
 =?us-ascii?Q?TKrcBMhJF2r8lyj0oQU7NgwIUeYvKwJWeQq540D2ACR0/lfLvXYZnsOaIcGo?=
 =?us-ascii?Q?VDA2U4EDOrQxPfqdDdusfdKfXPgjn5C3nsB2ORf+J+IFmgFdi/BbNIUC8DwD?=
 =?us-ascii?Q?zCN1mUjmrR+ozj0KOs6/G9MfYPk+sueR9Drr0sZ1yCih/VZja/L/zdi2Upbf?=
 =?us-ascii?Q?dsvX92MaQ2jw7084wSdl/HJ9iM1QYMPVxF4kYxJ+ftEXP/AtZTifcpZxgzqE?=
 =?us-ascii?Q?bEoYqzcF+rD9VnPpLWOZjGPhz1Ab9m/0iEoEihoKSx5vR4eH3R73Rv3owDg3?=
 =?us-ascii?Q?Cw/5dO3MJRbAZsmAW0zko1iim+gEPg64ybChTiZa4USaEIWgrR30tacCcTXL?=
 =?us-ascii?Q?8U3K19/wHFXPaKRSTx9q9BEcOp6YrYG59lA8dCPk?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6327.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c7b8389d-d348-4d51-4186-08da67e76bfb
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2022 11:28:07.2924
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4CW41O05pMSnODn2CZFnp7q1zoZAveb9Y7AiyLCXxdPyX3014vvu1Bu+0jAZFPiF7FBW5CAY9DQvLgIFMXralQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR04MB2334
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Martin

The bsg driver allows user space to send device management commands.
As such, it is often used by field application engineers to debug various p=
roblems, and as a test bed for new features as well.

Let's not bound ourself to hard coded descriptor sizes, as the new Descript=
ors that supports new features are not defined yet.

Please consider this patch series for kernel v5.20

Regards
Arthur

> -----Original Message-----
> From: Arthur Simchaev <Arthur.Simchaev@wdc.com>
> Sent: Monday, June 20, 2022 3:26 PM
> To: James; E.J.Bottomley; jejb@linux.vnet.ibm.com; Martin; K.Petersen;
> martin.petersen@oracle.com
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Bean; Huo;
> beanhuo@micron.com; Arthur Simchaev <Arthur.Simchaev@wdc.com>
> Subject: [PATCH] scsi: ufs-bsg: Remove ufs_bsg_get_query_desc_size functi=
on
>=20
> The bsg driver allows user space to send device management commands.
> As such, it is often used by field application engineers to debug various
> problems,
> and as a test bed for new features as well.
>=20
> Let's not bound ourself to hard coded descriptor sizes, as the new
> Descriptors that supports new features are not defined yet.
>=20
> Signed-off-by: Arthur Simchaev <Arthur.Simchaev@wdc.com>
> ---
>  drivers/scsi/ufs/ufs_bsg.c | 28 ++++------------------------
>  1 file changed, 4 insertions(+), 24 deletions(-)
>=20
> diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c
> index 39bf204..7c56eba 100644
> --- a/drivers/scsi/ufs/ufs_bsg.c
> +++ b/drivers/scsi/ufs/ufs_bsg.c
> @@ -6,24 +6,6 @@
>   */
>  #include "ufs_bsg.h"
>=20
> -static int ufs_bsg_get_query_desc_size(struct ufs_hba *hba, int *desc_le=
n,
> -				       struct utp_upiu_query *qr)
> -{
> -	int desc_size =3D be16_to_cpu(qr->length);
> -	int desc_id =3D qr->idn;
> -
> -	if (desc_size <=3D 0)
> -		return -EINVAL;
> -
> -	ufshcd_map_desc_id_to_length(hba, desc_id, desc_len);
> -	if (!*desc_len)
> -		return -EINVAL;
> -
> -	*desc_len =3D min_t(int, *desc_len, desc_size);
> -
> -	return 0;
> -}
> -
>  static int ufs_bsg_verify_query_size(struct ufs_hba *hba,
>  				     unsigned int request_len,
>  				     unsigned int reply_len)
> @@ -52,13 +34,11 @@ static int ufs_bsg_alloc_desc_buffer(struct ufs_hba
> *hba, struct bsg_job *job,
>  		goto out;
>=20
>  	qr =3D &bsg_request->upiu_req.qr;
> -	if (ufs_bsg_get_query_desc_size(hba, desc_len, qr)) {
> -		dev_err(hba->dev, "Illegal desc size\n");
> -		return -EINVAL;
> -	}
> +	*desc_len =3D be16_to_cpu(qr->length);
>=20
> -	if (*desc_len > job->request_payload.payload_len) {
> -		dev_err(hba->dev, "Illegal desc size\n");
> +	if (*desc_len <=3D 0 || *desc_len > QUERY_DESC_MAX_SIZE ||
> +	    *desc_len > job->request_payload.payload_len) {
> +		dev_err(hba->dev, "Illegal desc size %d\n", *desc_len);
>  		return -EINVAL;
>  	}
>=20
> --
> 2.7.4