Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?utf-8?Q?Christian_Kohlsch=C3=BCtter?= 
        <christian@kohlschutter.com>
Content-Type: text/plain;
        charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\))
Subject: Re: [PATCH] regulator: core: Fix off-on-delay-us for
 always-on/boot-on regulators
Date:   Sun, 17 Jul 2022 13:39:24 +0200
References: <E25D6465-6475-42B4-90EB-3D2C3CAF3B20@kohlschuetter.com>
To:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <E25D6465-6475-42B4-90EB-3D2C3CAF3B20@kohlschuetter.com>
Message-Id: <2B145293-BAAE-40AE-B408-FCFC4A80E46D@kohlschutter.com>
Precedence: bulk

This is _somewhat_ related to "[PATCH] regulator: core: Fix =
off-on-delay-us for always-on/boot-on regulators"
That other patch is the right solution for my specific problem, and no =
further fixes are necessary.

This change fixes an attempted "bandage" solution (adding an =
"off-on-delay-us") that we had initially tried to no avail.
While the cleanup not only reduces complexity, it may also prevent =
future code changes reintroducing the non-delayed cycling after =
registration.

from arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi:
vcc3v0_sd: vcc3v0-sd {
        compatible =3D "regulator-fixed";
        enable-active-high;
        gpio =3D <&gpio0 RK_PA1 GPIO_ACTIVE_HIGH>;
        pinctrl-names =3D "default";
        pinctrl-0 =3D <&sdmmc0_pwr_h>;
        regulator-always-on; // prevents setting last_off upon =
registration
        off-on-delay-us =3D <500000>; // would not be honored upon =
regulator_register
        regulator-min-microvolt =3D <3000000>;
        regulator-max-microvolt =3D <3000000>;
        regulator-name =3D "vcc3v0_sd";
        vin-supply =3D <&vcc3v3_sys>;
};

> Am 17.07.2022 um 13:30 schrieb Christian Kohlschuetter =
<christian@kohlschuetter.com>:
>=20
> Regulators marked with "regulator-always-on" or "regulator-boot-on"
> as well as an "off-on-delay-us", may run into cycling issues that are
> hard to detect.
>=20
> This is caused by the "last_off" state not being initialized in this
> case.
>=20
> Fix the "last_off" initialization by setting it to the current kernel
> time upon initialization, regardless of always_on/boot_on state.
>=20
> Signed-off-by: Christian Kohlsch=C3=BCtter =
<christian@kohlschutter.com>
> ---
> drivers/regulator/core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index c4d844ffad7a..48ed33ad48c8 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1522,6 +1522,9 @@ static int set_machine_constraints(struct =
regulator_dev *rdev)
> 		}
> 	}
>=20
> +	if (rdev->desc->off_on_delay)
> +		rdev->last_off =3D ktime_get();
> +
> 	/* If the constraints say the regulator should be on at this =
point
> 	 * and we have control then make sure it is enabled.
> 	 */
> @@ -1549,8 +1552,6 @@ static int set_machine_constraints(struct =
regulator_dev *rdev)
>=20
> 		if (rdev->constraints->always_on)
> 			rdev->use_count++;
> -	} else if (rdev->desc->off_on_delay) {
> -		rdev->last_off =3D ktime_get();
> 	}
>=20
> 	print_constraints(rdev);
> --=20
> 2.36.1
>=20
>=20


--=20
Dr. Christian Kohlsch=C3=BCtter