Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 17 Jul 2022 14:43:19 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     Naresh Solanki <naresh.solanki@9elements.com>
Cc:     linux-kernel@vger.kernel.org,
        Patrick Rudolph <patrick.rudolph@9elements.com>
Subject: Re: [PATCH 5/5] leds: max597x: Add support for max597x
Message-ID: <20220717124319.GK14285@duo.ucw.cz>
References: <20220705122244.472894-2-Naresh.Solanki@9elements.com>
 <20220705122244.472894-6-Naresh.Solanki@9elements.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="iSeZnk6FyAS3EJ1y"
Content-Disposition: inline
In-Reply-To: <20220705122244.472894-6-Naresh.Solanki@9elements.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--iSeZnk6FyAS3EJ1y
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index a49979f41eee..682748097276 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -598,6 +598,16 @@ config LEDS_ADP5520
>  	  To compile this driver as a module, choose M here: the module will
>  	  be called leds-adp5520.
> =20
> +config LEDS_MAX597X
> +	tristate "Maxim 597x leds"
> +	depends on I2C
> +	depends on OF
> +	depends on LEDS_CLASS
> +	select MFD_MAX597X
> +	help
> +	  This driver controls a Maxim 5970/5978 indication led via I2C bus.
> +	  The MAX5970/5978 is a smart switch with 4 indication leds

led->LED.

Add "to compile this driver as a module, choose M here: the module will
be called ..".

Add "." at end of sentence.

> +++ b/drivers/leds/leds-max597x.c
> @@ -0,0 +1,130 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Device driver for regulators in MAX5970 and MAX5978 IC

?

> +static int max597x_led_set_brightness(struct led_classdev *cdev,
> +				      enum led_brightness brightness)
> +{
> +	struct max597x_led *led =3D cdev->driver_data;
> +	int ret;
> +
> +	if (!led || !led->regmap)
> +		return -1;

-ERRNO.

> +static int max597x_led_probe(struct platform_device *pdev)
> +{
> +
> +
> +	struct max597x_data *max597x =3D dev_get_drvdata(pdev->dev.parent);
> +	struct device_node *np =3D dev_of_node(pdev->dev.parent);

Delete empty lines.

> +	struct device_node *led_node;
> +	struct device_node *child;
> +	int ret =3D 0;
> +
> +

One empty line would be enough.

> +module_platform_driver(max597x_led_driver);
> +
> +
> +MODULE_AUTHOR("Patrick Rudolph <patrick.rudolph@9elements.com>");

One empty line would be enough.

Best regards,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--iSeZnk6FyAS3EJ1y
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYtQD5wAKCRAw5/Bqldv6
8iukAKC6i4x6xTqhiPFDDmaurBP8cJPungCfYHpHAGZD40duQYsZB3oSNH8JPlg=
=S/0y
-----END PGP SIGNATURE-----

--iSeZnk6FyAS3EJ1y--