Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Yu Zhao <yuzhao@google.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH v11 00/69] Introducing the Maple Tree
Thread-Topic: [PATCH v11 00/69] Introducing the Maple Tree
Thread-Index: AQHYmYdscyeMwVIPS0CbwXe7JFDqlq2B9iIAgAAa8wCAAHEsgA==
Date:   Sun, 17 Jul 2022 12:42:27 +0000
Message-ID: <20220717124221.qwc4pvx6xsiwgefn@revolver>
References: <20220717024615.2106835-1-Liam.Howlett@oracle.com>
 <20220716212050.562604df2a48683dfbcc7e57@linux-foundation.org>
 <CAOUHufaxubu3_Ee-G8q3o02fkRoTf6M7-5=85_B_PUtsWbNa8Q@mail.gmail.com>
In-Reply-To: <CAOUHufaxubu3_Ee-G8q3o02fkRoTf6M7-5=85_B_PUtsWbNa8Q@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UVNZs70+EftVL7Zy9p4l0wJIQpcTCSZJvI3cksDRmBeq8ClAefWp0ZVlWpo8?=
 =?us-ascii?Q?rqFsVFPWIaVc9aLU0G0TQlPNuOfmAJmUw7sAgvdhrSt6e6QA9R6y4LPNcTuW?=
 =?us-ascii?Q?hzhamrXYbCdReopDkWgVoKvhAWlTjOa5itZ3PjqdSqTVwjg87HJaxkzS8aEL?=
 =?us-ascii?Q?nEboQylg4Mfo5WYMEuttib++lDm8d5W6Hk8I5dS/uqu/QfGPYfNM6GHevaHI?=
 =?us-ascii?Q?MJqgVZZkciO7DOISk2EtQcCfRLyYtNZx+wOU7hSsNLE6Y1pT9Zwc3X7RXlyT?=
 =?us-ascii?Q?6zLrxplHkPEBURT1pcCm6lzXEUhzKp5ruFi6CxwtzpqQkYqnlLUjMyoJH6MP?=
 =?us-ascii?Q?B0sJ8/6aHATDEA7GsHFSHftrfvzYDgMylaVOUIHtspZtiT20+SoNKJym9H3w?=
 =?us-ascii?Q?fovjm0P9KZpuR9KLlU09JfTDtViFQ7ytKkbCpyHkgcR8KicVo5C7aFSypF8Q?=
 =?us-ascii?Q?HijmHMRLKAQdjerZAvDPGIFE4OWQA/8bkPY8inxgKxiWOUAad58Fo/Kym45X?=
 =?us-ascii?Q?4vFR6XQzy1N5XeDkpCwzICT+IClsK9RQ4nGi5y69V0W7Txc9TwZdk9xbpIM/?=
 =?us-ascii?Q?P1z1zohMRJQbFZ8XovIzM9R6B+SXbfFEdOxCwTZDxotEZhN3Ks0zq47A/TjL?=
 =?us-ascii?Q?drbQGefNzhBvz5BzSQaKBAULTmfMN5nzq2oMRwkeSO8woaNCWBhMfc1sMlt6?=
 =?us-ascii?Q?H9bLQQhXJUEDx0MWrkwJ/i/cJ6gZGa5XCtj3yioMPA2SFozU3GD7t0sbKPIv?=
 =?us-ascii?Q?28OUV8Qtx3+qYmoG9vYdvhSB34a5JX02ho3BJa0AZhI9YNI3Lsu2boDhN166?=
 =?us-ascii?Q?SY0qCreqAXxPqk/JM8StiCkzxlMAjRh6P+vhazWD01+grTcuBmCfLtYmBcHt?=
 =?us-ascii?Q?fJ2s6VtfxogdUlGSyGmk+SsZAw496l7Y/K7y8O+jFkkESDWD9w70pw2/HTnK?=
 =?us-ascii?Q?PyO43SEwFZYQOxU7tyN26YS/R15wn5Mh92E3PmcPNjz5MYAfZg66UgAa8PnC?=
 =?us-ascii?Q?ADvmdpmEr//l8zUhReeAal8nQWNnFep9A24vLmOhtZNCB63XrR4hIFH1yl5a?=
 =?us-ascii?Q?gfdzPe4FEIrKX89fFwbu6fWdL5EjHwuCZsOzSgUWDCr7CKV6MUjJ+7ItGqPf?=
 =?us-ascii?Q?7onwelZioFB/pZcut7XhydG2/ZPW3d188kEr64cdPwE9KxZ7VVU4ydtuTsu2?=
 =?us-ascii?Q?9Ko6kOS8jauiGBgBLOLLIZAknxyXCwBLuCwMnbNGzSa8BGhXOaKuVFLG+Lgb?=
 =?us-ascii?Q?2aIAxQcTgC0+jTpqQHEYH27A8eZqdkrtgwiqdu2LkCBu2yFXkjAk36B9GlLD?=
 =?us-ascii?Q?bHkRHTKrbHfVnCecvpqtQra0QwYEGlcAQSgxz545/ynh2qOPBdezvXDhffoZ?=
 =?us-ascii?Q?C9Uwat9oga8KWdd5JjXp27nFu9xNxPiTbZUetxoe2N5rnxXF8wu2a5x9v0pL?=
 =?us-ascii?Q?7cbcIQekRBfOkAPZTENYgVywhQ3jPnFTGSHOhjaOnO68dbgIyw/cFK5QpQpE?=
 =?us-ascii?Q?iatFS230AUzXj6NPnKkhV5Zn5wa4UH01EnZPxWTSjy4becPtvyr8ZU7l1FPZ?=
 =?us-ascii?Q?TjyHxN705jdGi1PzV3HHM4vnQh9PdMKmBRC2bJrelCoR5DXHqbO8zoDTwaoj?=
 =?us-ascii?Q?Bw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BD62999133B06D418E62AAC6639360A4@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75eb7b7b-f7bf-4537-375c-08da67f1cedf
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2022 12:42:28.1392
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tCe123ZT2Yc8cRdCyZsiK6IVchSXENuCeHHO+UD4dsag6shRRGRnAOCHV30nGUrp0fooxo32U4dNNKP9yjMxmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3429
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-17_06,2022-07-15_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0
 suspectscore=0 mlxlogscore=918 adultscore=0 spamscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207170061
X-Proofpoint-GUID: hcK5WjTjgowEMzJRU50B6H6mKdkl28CY
X-Proofpoint-ORIG-GUID: hcK5WjTjgowEMzJRU50B6H6mKdkl28CY
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Yu Zhao <yuzhao@google.com> [220717 01:58]:
> On Sat, Jul 16, 2022 at 10:20 PM Andrew Morton
> <akpm@linux-foundation.org> wrote:
> >
> > On Sun, 17 Jul 2022 02:46:32 +0000 Liam Howlett <liam.howlett@oracle.co=
m> wrote:
> ...
> >         gap =3D mas.index;
> >         gap +=3D (info->align_offset - gap) & info->align_mask;
> > -       VM_BUG_ON(gap + info->length > info->high_limit);
> > -       VM_BUG_ON(gap + info->length > mas.last);

What arch did you hit these on?  David asked for me to restore some of
the BUG_ONs in these functions and I guess I got it wrong.

>=20
> These VM_BUG_ONs are new, and I hit the second one quickly:
>=20
>   kernel BUG at mm/mmap.c:1631!
>   RIP: 0010:vm_unmapped_area+0xdb/0x1c0
>   Call Trace:
>    <TASK>
>    arch_get_unmapped_area+0x1ee/0x220
>    arch_get_unmapped_area_topdown+0x25a/0x290
>    get_unmapped_area+0x92/0x100
>    do_mmap+0x13f/0x560
>    vm_mmap_pgoff+0xcd/0x170=