Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Yu Zhao <yuzhao@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH v11 00/69] Introducing the Maple Tree
Thread-Topic: [PATCH v11 00/69] Introducing the Maple Tree
Thread-Index: AQHYmYdscyeMwVIPS0CbwXe7JFDqlq2B9iIAgAAa8wCAAHEsgIAABqAA
Date:   Sun, 17 Jul 2022 13:06:07 +0000
Message-ID: <20220717130604.twluuseaopnkifct@revolver>
References: <20220717024615.2106835-1-Liam.Howlett@oracle.com>
 <20220716212050.562604df2a48683dfbcc7e57@linux-foundation.org>
 <CAOUHufaxubu3_Ee-G8q3o02fkRoTf6M7-5=85_B_PUtsWbNa8Q@mail.gmail.com>
 <20220717124221.qwc4pvx6xsiwgefn@revolver>
In-Reply-To: <20220717124221.qwc4pvx6xsiwgefn@revolver>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SIl4dvcX3FF4pQ9gHRoSSt7NCV2o5TIOklTkSBAKHphLRC6SbNswuWzM63kE?=
 =?us-ascii?Q?WvZEFX4oHnxquAQ08WZ3t6Yfn26cwiA1DRpEyeKb8lhBemrdeVdcAOSCW7v9?=
 =?us-ascii?Q?iKS43AQFrytpdGG7sGtMyvaAT3Ka2Rv9KmXW1qWvHJphF3TqeGz2URAC/oCS?=
 =?us-ascii?Q?cLNhm0ijmMtYMcgmP4RUnRLrhY1aeXeIKcZz5b7sEnCsQQqtWx4zQ09a6OiS?=
 =?us-ascii?Q?Px7USdtRcmfW1nGUvpE0imWfFGH8sv5x8V9OVUjNiV5mte/h7jR/CRjRwzE7?=
 =?us-ascii?Q?+vrPbTFtnqxmBCI/lxJwCWALXb5SQ9D9PEGxSs2jE1bpK2Chju7xTLxRhyfC?=
 =?us-ascii?Q?e4177vlBPRJxFlvqTzC5vi8xLl1+1yNcJkHH3iw+OOzep0vUP1tpbIB2lnvj?=
 =?us-ascii?Q?cz7Nd5zY1kOBHdUVxuBYcwfb6/yd1vF/Z0pOvaXUW5HBdUfd8/SSvPeOmaYn?=
 =?us-ascii?Q?QZoulAoeBWeX2FRoUbL9Pn5NP7Guka6sFyzC7otmNrb6yFQww3NjdQiU8g0h?=
 =?us-ascii?Q?b3LYXUNeeQfiqmltj5I72HyRK/okmsG3X3PAIdQiaattA0M9Kum69Kc9RV7W?=
 =?us-ascii?Q?0/ItvyYEqiHw/ZtOLsLezNvEYQp9RHDO0YGAUxhhjujwhG4M/ZEeiUiHcsvH?=
 =?us-ascii?Q?s8ujDWYkbsnvyrnNahWW5IU9TJO1azQhZnl0pQhmxLugn+3nv3I2uhHCQ8KM?=
 =?us-ascii?Q?DiyZotFRAahOMpVy9R1Hcz7XFWX4TtJ1YiX1c+3GsWWT5Qz8b2P/YTrJt7hg?=
 =?us-ascii?Q?VjVTM7Rf3fYCFEcMaJBE0od6hDWDiASFQwm1XkJek2imSf0IEMgkypDD+zVa?=
 =?us-ascii?Q?NPl9gMVlD70LZ9kV9LQQJrrtAV1/6wbtc4/jLwoogIbt+93c1EbDzbHgbvtr?=
 =?us-ascii?Q?bvLpDM62eqAI4/3xt0Y/04/tsvuCAJNP2dYYNyW8gzF2AkAfEskavfOLTwdy?=
 =?us-ascii?Q?18U5U5dacD+zZaSFIkwuMJ0aNKT6a5jHb0G49zo32Cc6/SPT/dmVaiomOTBm?=
 =?us-ascii?Q?Wpq9ah+d76bgrfni0+tZThGQ8z0X9qV39+hAxDsks3vg5txJmwu9eTx7DeGd?=
 =?us-ascii?Q?wtLTXn0WsNxSRSixiGbkpNUhwGUqE8fvSNC5z7unPVA2gwk8VTQN8GD4CkaO?=
 =?us-ascii?Q?FgeXLMK3aifd+IUR7FSpYIy9GgQcl/ohjgchfJK9y7FXch6Fh5IOKQ0NTgs6?=
 =?us-ascii?Q?HSNfQ9BEB04xzeZwHxhDfZpw9kqsA8QH0yJdqDEiNzO/73TzDb08l+/YsFZp?=
 =?us-ascii?Q?THLyiwY2uD+JqcLYLHMSO5znV3us4Tni/HhkiTga///knyczUQRSWS+XjXQV?=
 =?us-ascii?Q?hlryeNES7fMdKChzIMOCKLBaAfhJr4AvJsjicMh0SBaxwcCyPhGeqxsbDNLh?=
 =?us-ascii?Q?UlGoSZDQi5mglh9n5Bm7Wk1RNcFyFSgIns1346pxAxi+8Viq24clveJ9pIXa?=
 =?us-ascii?Q?6KJ0K/9QiI66pxhZBHaq5yb9JN0nl9Dsz7KHagD7oFfxXBAkjVLMz0JDSIsx?=
 =?us-ascii?Q?l0BHTpTtit5Pfk4RaftEuRDAAdVCuPTcgvATHtXlGoKBMEeBAK9VF+wYh4D4?=
 =?us-ascii?Q?tL9V8B0gZAxp9H/tvS6fO+GoE4JUHgyHuNTC2g2uL4wjM379VGxkF+ATxSbh?=
 =?us-ascii?Q?3A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B9E354BB7EEDA94EB020DFA8525E4926@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d504d888-5dd6-4e5b-3d96-08da67f51ce2
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2022 13:06:07.5271
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nyBPncRI5xOD+FpcUqsNKED918fRaFsYJeQDY9kmnK5jVlAYjy77EThaFNykESTCWRF9LMbbaMSEeFzbmqW9Gg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5837
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-17_06,2022-07-15_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207170064
X-Proofpoint-GUID: -uYRu0FWWEOQfCVqRZ0gHfP1GF3JCqUm
X-Proofpoint-ORIG-GUID: -uYRu0FWWEOQfCVqRZ0gHfP1GF3JCqUm
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Liam R. Howlett <Liam.Howlett@Oracle.com> [220717 08:42]:
> * Yu Zhao <yuzhao@google.com> [220717 01:58]:
> > On Sat, Jul 16, 2022 at 10:20 PM Andrew Morton
> > <akpm@linux-foundation.org> wrote:
> > >
> > > On Sun, 17 Jul 2022 02:46:32 +0000 Liam Howlett <liam.howlett@oracle.=
com> wrote:
> > ...
> > >         gap =3D mas.index;
> > >         gap +=3D (info->align_offset - gap) & info->align_mask;
> > > -       VM_BUG_ON(gap + info->length > info->high_limit);
> > > -       VM_BUG_ON(gap + info->length > mas.last);
>=20
> What arch did you hit these on?  David asked for me to restore some of
> the BUG_ONs in these functions and I guess I got it wrong.

I think these should be removed until I better test them.

>=20
> >=20
> > These VM_BUG_ONs are new, and I hit the second one quickly:
> >=20
> >   kernel BUG at mm/mmap.c:1631!
> >   RIP: 0010:vm_unmapped_area+0xdb/0x1c0
> >   Call Trace:
> >    <TASK>
> >    arch_get_unmapped_area+0x1ee/0x220
> >    arch_get_unmapped_area_topdown+0x25a/0x290
> >    get_unmapped_area+0x92/0x100
> >    do_mmap+0x13f/0x560
> >    vm_mmap_pgoff+0xcd/0x170=