Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220716230344.239749011@linutronix.de> <20220716230952.787452088@linutronix.de>
 <0bec8fe2-d1e3-f01c-6e52-06ab542efdd8@citrix.com>
In-Reply-To: <0bec8fe2-d1e3-f01c-6e52-06ab542efdd8@citrix.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun, 17 Jul 2022 08:20:46 -0700
Message-ID: <CAHk-=wiAF9KF5x8A8QW+=k_XFyaMgjS74h7gmHRYBB+PXkQ2rQ@mail.gmail.com>
Subject: Re: [patch 02/38] x86/cpu: Use native_wrmsrl() in load_percpu_segment()
To:     Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Josh Poimboeuf <jpoimboe@kernel.org>,
        Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
        Johannes Wikner <kwikner@ethz.ch>,
        Alyssa Milburn <alyssa.milburn@linux.intel.com>,
        Jann Horn <jannh@google.com>, "H.J. Lu" <hjl.tools@gmail.com>,
        Joao Moreira <joao.moreira@intel.com>,
        Joseph Nuzman <joseph.nuzman@intel.com>,
        Steven Rostedt <rostedt@goodmis.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Jul 16, 2022 at 5:22 PM Andrew Cooper <Andrew.Cooper3@citrix.com> wrote:
>
> It's only 32bit where the percpu pointer is tied to the GDT.  On 64bit,
> gsbase is good before this, and remains good after.

That sounds sensible to me, but somebody should check that there's
nothing that accidentally relied on the MSR_GS_BASE setting (or the
segment selector clearing, for that matter).

Not that I can necessarily see how anything could work with it wrong, but..

           Linus