Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\))
Subject: Re: [PATCH] arm64: dts: rockchip: rk3399-nanopi4: Fix voltage
 regulator config
From:   =?utf-8?Q?Christian_Kohlsch=C3=BCtter?= 
        <christian@kohlschutter.com>
In-Reply-To: <963AF33B-54B7-4172-92D1-E2898E256A7E@kohlschutter.com>
Date:   Sun, 17 Jul 2022 21:32:23 +0200
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <750501EB-8A79-459B-89B8-E9064632A68B@kohlschutter.com>
References: <963AF33B-54B7-4172-92D1-E2898E256A7E@kohlschutter.com>
To:     Robin Murphy <robin.murphy@arm.com>, wens@kernel.org,
        =?utf-8?Q?Heiko_St=C3=BCbner?= <heiko@sntech.de>,
        Markus Reichl <m.reichl@fivetechno.de>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        Linux MMC List <linux-mmc@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Precedence: bulk

This patch obviously requires "regulator: core: Resolve supply name =
earlier to prevent double-init" and obsoletes "[PATCH v5] arm64: dts: =
rockchip: Fix SD card init on rk3399-nanopi4".
The latter patch may still be useful for existing kernels where one can =
recompile the device tree separately.

> Am 17.07.2022 um 21:29 schrieb Christian Kohlsch=C3=BCtter =
<christian@kohlschutter.com>:
>=20
> A series of issues exist around the "vcc3v0_sd" voltage regulator that
> made it necessary to mark it "always-on".
>=20
> With the patch "regulator: core: Resolve supply name earlier to =
prevent
> double-init", this option is no longer necessary.
>=20
> Removing this option not only prevents a hang when rebooting Nanopi =
R4S,
> it also ensures that bootloaders like u-boot can boot from an SD card
> right away, without out-of-tree patches that re-initialize voltage =
levels.
>=20
> Signed-off-by: Christian Kohlsch=C3=BCtter =
<christian@kohlschutter.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>=20
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi =
b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
> index 8c0ff6c96e03..55b93eac2f99 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
> @@ -70,7 +70,6 @@ vcc3v0_sd: vcc3v0-sd {
> 		gpio =3D <&gpio0 RK_PA1 GPIO_ACTIVE_HIGH>;
> 		pinctrl-names =3D "default";
> 		pinctrl-0 =3D <&sdmmc0_pwr_h>;
> -		regulator-always-on;
> 		regulator-min-microvolt =3D <3000000>;
> 		regulator-max-microvolt =3D <3000000>;
> 		regulator-name =3D "vcc3v0_sd";
> --=20
> 2.36.1
>=20
>=20