Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6d70460d-0a85-4104-9abc-dd100af99e6f@intel.com>
Date:   Mon, 18 Jul 2022 08:58:17 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [LKP] Re: [io_uring] 584b0180f0:
 phoronix-test-suite.fio.SequentialWrite.IO_uring.Yes.Yes.1MB.DefaultTestDirectory.mb_s
 -10.2% regression
Content-Language: en-US
To:     Jens Axboe <axboe@kernel.dk>,
        kernel test robot <oliver.sang@intel.com>
CC:     LKML <linux-kernel@vger.kernel.org>, <io-uring@vger.kernel.org>,
        <lkp@lists.01.org>, <lkp@intel.com>
References: <20220527092432.GE11731@xsang-OptiPlex-9020>
 <2085bfef-a91c-8adb-402b-242e8c5d5c55@kernel.dk>
 <0d60aa42-a519-12ad-3c69-72ed12398865@intel.com>
 <26d913ea-7aa0-467d-4caf-a93f8ca5b3ff@kernel.dk>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <26d913ea-7aa0-467d-4caf-a93f8ca5b3ff@kernel.dk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXJuayswTUtXV0JZb0pmNjFnTWpqemhBQlRabmZNeWR4UGhNSFNaMWNTN3R3?=
 =?utf-8?B?dVkrcTZjbXBHbUlGZzd1bGdLcFhGaXhJaU13UEZKQ3hvRUJ6U2hxNk5aSmRD?=
 =?utf-8?B?ZWFQb01ZV2w4b2pTYzJRc2FyRlNxNmt4Tk5WM3pYdCsrM0dPUVBPdXN6V3c4?=
 =?utf-8?B?TTJBSWJFeHo0YzkyY1NETU9ZSFJCcTFuTmpFdTdwK3p0bTNhY1JFZVBEQmgy?=
 =?utf-8?B?QlNQM1Uyb0lBcW8vK3V6cms1TE1BeGFBWE5nYXlJMzZpZjhJdUNpd2ZlUjFJ?=
 =?utf-8?B?UG5xYmxNWDgzcEtIM0ZZVFZVNmJWNDg3QytGV1RVdSs1Nll3RFRQUEpUeGNX?=
 =?utf-8?B?eHFQa01PWWhBazZxRS9NWVNqa0o5UDJCbG8wTDdZeEVXUHNJQ3RnUzFqKzF5?=
 =?utf-8?B?N3plV1A3R1hObnUvMnlYZTIxRTRWZHhJWE1jVXp4b3lVa09KNkF4U1Vncllw?=
 =?utf-8?B?ZEFVU3ZnUU9sbjN0aTJuTzBIZVEwcU4rOGNGR042VHZUUlkrd1V2RFNPRTdP?=
 =?utf-8?B?TG1XVDJzTzZ1czNISkx5bklrUlVFMC9nS0l0YTVTMXdMQk9HMjRrK1hlV3c4?=
 =?utf-8?B?TlpOaCtzbEpsNHJZNHgrYU4vNXh3LzAwUzRVc1U0cXkrUDM1VWw5dW9SOHNM?=
 =?utf-8?B?ckNwWUFOU0tHczlNay9xZHZLN2xGTTErYmFmZnlPbVp5a3ZWV1JEWnk3QW9k?=
 =?utf-8?B?dDNQMVo2NFBacDd5VFdRMy9PYjBBUkNoZUpWZ2V0bk54SVpSSVdPcmRIRkJh?=
 =?utf-8?B?Y0tSWElLclBuZjVleWFwTjdqZ1JwdkFYVXlrbHJIUDk3cEN3d2s0c0NWbGdt?=
 =?utf-8?B?RXRRRDJFRTdSMXBYNTYyODlnUEUrSFJJMW1WbFQ5UlpyVnQ3Y1preTNId0pp?=
 =?utf-8?B?NVI2Wm91dEM4THcxY1h2WEhzcUNuTXk4THpXeUFxalM2Nm81WFliYmVQMThm?=
 =?utf-8?B?MElIWGZTMUNjWlMySHJva0RhUzhMdHJVVXJsQ2hjNWZtNXBLdDNCMXZYYU1T?=
 =?utf-8?B?d01xbmw1ZnlOU001aTE4N09RdTBLdGViNjNNbGRxRllYRkZFcVJHYjU3VDkw?=
 =?utf-8?B?RnEyV1c0ZWJDR2JEYUMxTzh1dm11ZjFYaFFYN1hXb1IrWndENEpBWGtVdUVl?=
 =?utf-8?B?alVlaEU1SHNJYk9KWko2SVRPYlk0cmRsam5WZ1B0WjFEemxhcXlZTzdHY1Jj?=
 =?utf-8?B?Q3hVakU0MHFkNmcyWU9UN2ZzLzEzTVNEWFJjMm5ycWEyRUJFNGFQNFNiYTA1?=
 =?utf-8?B?VldNbVJ1MkgyZ2QyRnU4ZFdLUHFSL3JIOFZyWEZZdXU5QWNLVER1Q1NVQlZm?=
 =?utf-8?B?bzJBYXQzc2hBcVhhNWl0N2xabWdydEtzVXZOeVF5dllVTkJQeGNjMDhBNUM3?=
 =?utf-8?B?R0s1UEROQnNIYTJvNTdaNW45S3djL3BJdUFvZ3l2NXN4VUc4R0ZOSklOZWFY?=
 =?utf-8?B?dml3SHpkRFlLSGlLOXdTYWlMWUJvK1N5TWFzTlpYU1JIMGZESFBjSks5citW?=
 =?utf-8?B?T3BLemRoTUhDNVNyOWtLUVN6eWlKdTZJSk1GVTZ3U3hQcWtCakU3Rk4xTWF4?=
 =?utf-8?B?SDFnTWN0QmFZTTlzdm5lWEttaUY2Y1VKRzErZDlvWWFKa0xkNThIMU00UjIz?=
 =?utf-8?B?MjBVNm9oTmNVMDl6anJpeElXcGxsZHZubFhsVkUrdTBTbCtBeFovQkNVdzZI?=
 =?utf-8?B?enQxQld1TUExblBXUVlUNEVHd0t5dFpoQUo0UTNZcmxrekNSL2VRNUZEVnJB?=
 =?utf-8?B?Y0dHRUhTaXhteW1RMGhUSFo4MFZ4bUEyUzhhU3hmWTZGMVhEUkFoRW9mdXRQ?=
 =?utf-8?B?UjJsU3JkU3k5QTlUcmNrTlZ0QTJXTFhlUVNrazBqdzluUmI2S3BNcDAxenY5?=
 =?utf-8?B?T2pmbHdWSUtiRnJxOWVXVnJJOEZmYWFQeUhhMGJLUWo3ZkxXM3dYdlRjYWVD?=
 =?utf-8?B?YTdqdVV0UHVBQnhSdkdIenBCbWJkT0VSZWJlRXJQRnNEQXh2aTBTN0lLYWVI?=
 =?utf-8?B?SmtYTUdzaWpudmU0K0NFZ0NGMVFPVDYxNi9pSkJoNzlnZjAwNVFYVk1Kait0?=
 =?utf-8?B?bjI5MDdEcmdnZDVYeURhN29MbHhieHBRcnkvZHRYVDdic1U2Q0l6VWR5Y3hP?=
 =?utf-8?Q?7CAXNO55qVghAPyEm8VN7OubO?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e85b0044-e857-46b7-c74a-08da68589f16
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 00:58:26.5253
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VAfyi4Einkn9F4l66iwn/yfBNpT9m21tUg0J9xAOkPnCVi1EH9kRjv1zDBJCJHDOjpGGBkHNNpaIpOaPyYc7AA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5136
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/15/2022 11:58 PM, Jens Axboe wrote:
> I can't really explain that either, at least not immediately. I tried
> running with and without that patch, and don't see any difference here.
> In terms of making this more obvious, does the below also fix it for
> you?
I will try the fix and let you know the result.

> 
> And what filesystem is this being run on?
I am using ext4 and LKP are also using ext4. Thanks.


Regards
Yin, Fengwei

> 
> 
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index a01ea49f3017..797fad99780d 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -4269,9 +4269,6 @@ static int io_rw_init_file(struct io_kiocb *req, fmode_t mode)
>  	if (unlikely(!file || !(file->f_mode & mode)))
>  		return -EBADF;
>  
> -	if (!io_req_ffs_set(req))
> -		req->flags |= io_file_get_flags(file) << REQ_F_SUPPORT_NOWAIT_BIT;
> -
>  	kiocb->ki_flags = iocb_flags(file);
>  	ret = kiocb_set_rw_flags(kiocb, req->rw.flags);
>  	if (unlikely(ret))
> @@ -8309,7 +8306,13 @@ static bool io_assign_file(struct io_kiocb *req, unsigned int issue_flags)
>  	else
>  		req->file = io_file_get_normal(req, req->cqe.fd);
>  
> -	return !!req->file;
> +	if (unlikely(!req->file))
> +		return false;
> +
> +	if (!io_req_ffs_set(req))
> +		req->flags |= io_file_get_flags(file) << REQ_F_SUPPORT_NOWAIT_BIT;
> +
> +	return true;
>  }
>  
>  static int io_issue_sqe(struct io_kiocb *req, unsigned int issue_flags)