Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5f6dc0a9-02ef-5bd2-d864-ab4b2c4c4820@bytedance.com>
Date:   Mon, 18 Jul 2022 10:32:40 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH v2] sched/fair: Remove unused parameter idle of
 _nohz_idle_balance()
To:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, vschneid@redhat.com
Cc:     linux-kernel@vger.kernel.org
References: <20220710101910.8413-1-jiahao.os@bytedance.com>
From:   Hao Jia <jiahao.os@bytedance.com>
In-Reply-To: <20220710101910.8413-1-jiahao.os@bytedance.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


gentle ping.

On 2022/7/10 Hao Jia wrote:
> Commit 7a82e5f52a35 ("sched/fair: Merge for each idle cpu loop of ILB")
> has been merged. The parameter idle of _nohz_idle_balance()
> is not used anymore so we can remove it.
> 
> Signed-off-by: Hao Jia <jiahao.os@bytedance.com>
> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>

Hi Peter,
The patch got Reviewed-by from Vincent.
If you have time, please review the patch.

Regards,
Hao

> ---
>   kernel/sched/fair.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 77b2048a9326..8d4be2a95e37 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -10682,8 +10682,7 @@ static bool update_nohz_stats(struct rq *rq)
>    * can be a simple update of blocked load or a complete load balance with
>    * tasks movement depending of flags.
>    */
> -static void _nohz_idle_balance(struct rq *this_rq, unsigned int flags,
> -			       enum cpu_idle_type idle)
> +static void _nohz_idle_balance(struct rq *this_rq, unsigned int flags)
>   {
>   	/* Earliest time when we have to do rebalance again */
>   	unsigned long now = jiffies;
> @@ -10798,7 +10797,7 @@ static bool nohz_idle_balance(struct rq *this_rq, enum cpu_idle_type idle)
>   	if (idle != CPU_IDLE)
>   		return false;
>   
> -	_nohz_idle_balance(this_rq, flags, idle);
> +	_nohz_idle_balance(this_rq, flags);
>   
>   	return true;
>   }
> @@ -10818,7 +10817,7 @@ void nohz_run_idle_balance(int cpu)
>   	 * (ie NOHZ_STATS_KICK set) and will do the same.
>   	 */
>   	if ((flags == NOHZ_NEWILB_KICK) && !need_resched())
> -		_nohz_idle_balance(cpu_rq(cpu), NOHZ_STATS_KICK, CPU_IDLE);
> +		_nohz_idle_balance(cpu_rq(cpu), NOHZ_STATS_KICK);
>   }
>   
>   static void nohz_newidle_balance(struct rq *this_rq)