Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp2903095imw; Sun, 17 Jul 2022 20:22:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vlmfFIQGnD5GJ40Lrw4319rMaqWHTmoh+suFrOUn1d80w7p9jbRA1OjK0S0rlRL78VbWkF X-Received: by 2002:a17:90a:e7c8:b0:1f0:c82:c89d with SMTP id kb8-20020a17090ae7c800b001f00c82c89dmr30100540pjb.108.1658114578597; Sun, 17 Jul 2022 20:22:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658114578; cv=none; d=google.com; s=arc-20160816; b=NwluDmERDiNSOY+OTY82SVNf7HFecXLOo511feL7gC+TgsvqGh+hJ5T1NmqYcO9HzW RDvbHD36i0E2a9x7J+B0qcJ5wwlHLXiBOie+boD1twTXkTFfjS41a2B5ZrKkJ0+1EdVk 8rBlDGx9dMxHsPbflLWLuNB9BTy7VIH3JO6OHiGcL2C9b+trfbA3Sag8pu66E1NHGHMH hrbrVzoS8pBb6sCJgx6icQyxhzvmpLx0FvGRgq+EKzB/18PxYzLIjXuhJGI0Jem5a+rM 6140S4ivKe2Pzf4aAF5DR9Ick+NSs2NAnY/H7tv0q03af1RONNpGyw68erDcL/0d34Eo G4CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AGLBLaaaI8tYrb0uYQh2/7PHoDH01u1OT0eBjw8uHxc=; b=yeDdSOkvoBe7yb9LLLHm7uWP/eaGRi35PEMSgiu8ETfP1T1Ir5sg7sNXh+OUQmqp2K 0u1/eG8Mc1vWq+Ej4GEYuLsssr3Rqg9XmWhkB4fRph0cUiSq2oYtyE9L5iycQlz9kkOM rX++RwNzJp+Uq2ke2xIzXt+NAk61Coo+KGlYKu8WUNIGL9c618P4gZkqwFgMGJ887l0J kcTLgV8DVrzYS6h66eNoiKNYDVGgGPax3seEx8cVslJTk/IxsNgh9OwIV4ziovb7zJy3 L6FS1nmN9KgQ+/rnnyqSTmnV/JIa2x6HJSxnZO5TbqlbVkEsTLIR9zsDoa8sqcsoiEg2 weOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J8OOiTJa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l62-20020a639141000000b0041678569fcbsi13477321pge.503.2022.07.17.20.22.43; Sun, 17 Jul 2022 20:22:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J8OOiTJa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231346AbiGRDU4 (ORCPT + 99 others); Sun, 17 Jul 2022 23:20:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbiGRDUy (ORCPT ); Sun, 17 Jul 2022 23:20:54 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68D0810551 for ; Sun, 17 Jul 2022 20:20:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1BBDCB80860 for ; Mon, 18 Jul 2022 03:20:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A7AEC3411E; Mon, 18 Jul 2022 03:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658114450; bh=RcYWaF4+2Ao+VJQR+EOrodpthSRqlZ5w8sHpzG/tp4Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J8OOiTJag1aph8kvOB0LuctzbhAPOAyBznZgkHa6WO0tewEpT7CdmiPkXbOuw92fI RHRqoAUfZgbrhwMsnS80gdKhH8radqHHrdyADIIbsearvJ7Zr1e/T2S+Rw91xR+3qj gVzNh+R7m//h6v99+0LohFVEbCfxPgpI8dnAmeVkEspbpGuQoYjv8pN8FhCMR5evkY /WwG27cR8Eqlddytz+UfOVAmOXHPoRIbnTOnO5agPbz8sooP7ioR2KhyEJOoKwrCm+ ZZbku/AqTxlAI9mwLc7dOR/nUT4PeOrkwPhYNqcCHeyuVm7oyH9mITLM9k7XY6JnTH PcuetesU+4TuQ== Date: Mon, 18 Jul 2022 03:20:47 +0000 From: Tzung-Bi Shih To: Patryk Duda Cc: Benson Leung , Guenter Roeck , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, upstream@semihalf.com Subject: Re: [PATCH] platform/chrome: cros_ec_proto: Update version on GET_NEXT_EVENT failure Message-ID: References: <20220714160951.9364-1-pdk@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220714160951.9364-1-pdk@semihalf.com> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2022 at 06:09:51PM +0200, Patryk Duda wrote: > @@ -750,6 +750,7 @@ int cros_ec_get_next_event(struct cros_ec_device *ec_dev, > u8 event_type; > u32 host_event; > int ret; > + u32 ver_mask = 0; Drop the initialization. Ideally, `ver_mask` wouldn't be touched if `ret` is less than 0.