Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9df150bb-f4fd-7857-aea8-b2c7a06a8791@intel.com>
Date:   Mon, 18 Jul 2022 11:30:34 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [LKP] Re: [io_uring] 584b0180f0:
 phoronix-test-suite.fio.SequentialWrite.IO_uring.Yes.Yes.1MB.DefaultTestDirectory.mb_s
 -10.2% regression
Content-Language: en-US
To:     Jens Axboe <axboe@kernel.dk>,
        kernel test robot <oliver.sang@intel.com>
CC:     LKML <linux-kernel@vger.kernel.org>, <io-uring@vger.kernel.org>,
        <lkp@lists.01.org>, <lkp@intel.com>
References: <20220527092432.GE11731@xsang-OptiPlex-9020>
 <2085bfef-a91c-8adb-402b-242e8c5d5c55@kernel.dk>
 <0d60aa42-a519-12ad-3c69-72ed12398865@intel.com>
 <26d913ea-7aa0-467d-4caf-a93f8ca5b3ff@kernel.dk>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <26d913ea-7aa0-467d-4caf-a93f8ca5b3ff@kernel.dk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azM0Z0R4SytZT3FUa21vUVk4VDBrVFR2NElwYXg1QmFrVHpjQVNEM2hVUUIr?=
 =?utf-8?B?NGFROXZ0ZzNmbWRFYUlRN2hnd2RzamkwL3BqbkZGUG9Id0hVcDRMV3laNi9B?=
 =?utf-8?B?SVA2S0k1Qk15MXliYTc3Zk03VnlaMWwxNXd3dUpIRFFnL3BPaDNIUEY2TEtS?=
 =?utf-8?B?QXRvcXllOXFBQm9yUDh2ZUZQMm1CMFlzSlFjS1Q3MGFyQjNVaDFTVEllc3d5?=
 =?utf-8?B?Y29vdDA2TFRRRkhQNXN4bmR4N0ZiSDB2ZGpaUmNJNXlSaURUbFV4bkcrcEJ5?=
 =?utf-8?B?dEg0WjYxdVBoRlhMUHllNEVHUkVRRkpyM0F1Yng1bW15bDhWRmRlajdGUURJ?=
 =?utf-8?B?ek1xY3dROVVMVXpPd3RzNStwZTZyaENmSkZKSDVtbXhxUmp5d1JXYmRVTE0r?=
 =?utf-8?B?V1pTU2lHR0o4akxzVTdEWStKQTExMU5Fdjl2SVp0M2FZRnVuNjl1dEMyZUVN?=
 =?utf-8?B?SVduY285OUg5UWh6am8zWUM4bkxZM2JqdWRSNm1BM0NLK3ZxN25iMEsxcHd3?=
 =?utf-8?B?R2dpK3RaODJoN0hubExGSkZmRFYreG0rcFl5cHRodUpLNTVjU25VcTVHaUwv?=
 =?utf-8?B?TVBvSHZpWXZ4aWx3WTBWNjgvbXV1SVQ2bG1jRXJ2SnZtcVZMcDgxUkg5RHcx?=
 =?utf-8?B?bzNhNkZvWmtNRlZKWGR5UEtGbVJhZS92YWw2QmtNRFArNFB4YXZjWUVZN01r?=
 =?utf-8?B?aEtOY1oyNy9NNnNJYndZVUlXUGxRSFFadXZ1OVpqVVlDMWxEb1kyNmpHMUZt?=
 =?utf-8?B?c2R6Y3JxdWtYaDgxRDk2Vy9jWGl1cHJRc2RZRzRyckJyM1Zva2tVaDYxZkll?=
 =?utf-8?B?UjdHU29wTmR6YUt6NTJQNGo2cFJSQ0czOFdKbmhadE5ORTlITGpYRlowWnVI?=
 =?utf-8?B?ZUtleGJ6VStQZE8xOUd6SFF1QTI2d1czM2QxQ3dzTlVmSTZ4NkU0VlBZRlJw?=
 =?utf-8?B?N2V3V0FJaUJ5QTdZMEFpOGdEaFM5S1E2SEhjYkZ6Y2FIczlXK3l3WGlwZWRy?=
 =?utf-8?B?YnRyV25MTWx3UkVDTU5MZmdDOFZ2VWh0b052enVLNTN0NEYrRnR5Q0FjOS9t?=
 =?utf-8?B?aUYwckFucVQ1WUUxcDBqWDJzWXJhWCsvaEU3b2NtMmZUa05LdFdJeWZaV2VM?=
 =?utf-8?B?RlZhaHZTeVFrdzVFa1VjcksxbU1JbFo1bHJiQjUvbGxlTjI4ajlFSHdqOEdI?=
 =?utf-8?B?Tnl0dHZwUmFnRnVBbElaNUR1Mzd6U3JuejdJT3I1RTlmQW1JK2hOeVQ2aEZE?=
 =?utf-8?B?VUtxN0ZBaDNKZ2x6clBJdEtjUytCTitZNGpNOTgyN0JsUFdMNyt4Nmxad0F2?=
 =?utf-8?B?azZPaDhBb0ZVekZ6SDJaZ0FEWlpadVpPZVNkVXgrNDg1dmo3UXJXMkxsSThO?=
 =?utf-8?B?SThRWVhnZDd6ekJHZ0tLNDRTcGlQZ3lTOXQ2bEVGRklpa0duNVBZOWdLZVhq?=
 =?utf-8?B?ZkRmRjNjd200MG0va0MyL1pmQm1YNUVlWXM1S3BTZzFiOW85aG9oZWhIU2k2?=
 =?utf-8?B?c0J6cUg0MW5NMmUyYWk1Sm5WOENBUTI0MFNxWHdhWWs2WWRWenVUSkVMZXpM?=
 =?utf-8?B?L3dBYmlxcjZMMmRHSFVmcnVJejF5Nmk0dTB4bEtLQUdGTU5vbVFzbHVkSFlG?=
 =?utf-8?B?UTVRbDZjQ09sVHVrcnFwZElTY3VzczVOMVFIQThad3ZyMVhJejRYbzlFTjYw?=
 =?utf-8?B?Q3ZuT2o3dW9ySC9vR3Fpb1JGT0Jtc3ZYVkhNWGlrMnJreWN4Qk1lMjJkckJp?=
 =?utf-8?B?NjMxWTlUVm4vWjhoTldBZnBEdjNld2JUVForV1lLMzRrUUxJaG9jUFdMRndq?=
 =?utf-8?B?S05YeTVQWVZYNVBSUHozTU9aMng3SGFwT05KcFFGVDBJYkt3NVYyQ0J4MGtp?=
 =?utf-8?B?cHRlVkFpL05RNHZFYjlxNVVpOWozVTliRHZFQ2xUcjV2eVlSWTc5YTRnNmRT?=
 =?utf-8?B?dFpWMWl0NER5RCtJczBZMUttQW9kcGpUMFl5Vkxsbm5ITXFSYjFqVzl3aEkz?=
 =?utf-8?B?ekh3V2lUTFkrL1pUVTAwRUpZVjFXdzZpTnZhcjFqdTh2L0ZpT1U0V0o3SzJu?=
 =?utf-8?B?SXEwemNsRlptSHhPbVptSVVlanRQYk5zRmFmQmxCeHNxci9jKzFmaXdkbTkw?=
 =?utf-8?Q?zgD7oJGAhvBZXFoFxMCT55ZWA?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 22fc08b8-2ad3-4b3b-174e-08da686de4af
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 03:30:42.6719
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3SF8YSnxadt7Afjz27wyeuZGrenJ1PMyiRqfQeY5FQxkNx3zMfhsO5PcDZGEKyV+jkHiU8AXpR6XCzn6uMUB2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3554
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jens,

On 7/15/2022 11:58 PM, Jens Axboe wrote:
> In terms of making this more obvious, does the below also fix it for
> you?

The regression is still there after applied the change you posted.


Your change can't be applied to v5.18 (the latest commit on master branch).
I changed it a little bit to be applied:

diff --git a/fs/io_uring.c b/fs/io_uring.c
index e0823f58f7959..0bf7f3d18d46e 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -3762,9 +3762,6 @@ static int io_rw_init_file(struct io_kiocb *req, fmode_t mode)
        if (unlikely(!file || !(file->f_mode & mode)))
                return -EBADF;

-       if (!io_req_ffs_set(req))
-               req->flags |= io_file_get_flags(file) << REQ_F_SUPPORT_NOWAIT_BIT;
-
        kiocb->ki_flags = iocb_flags(file);
        ret = kiocb_set_rw_flags(kiocb, req->rw.flags);
        if (unlikely(ret))
@@ -7114,8 +7111,13 @@ static bool io_assign_file(struct io_kiocb *req, unsigned int issue_flags)
                req->file = io_file_get_fixed(req, req->fd, issue_flags);
        else
                req->file = io_file_get_normal(req, req->fd);
-       if (req->file)
+       if (req->file) {
+               if (!io_req_ffs_set(req))
+                       req->flags |= io_file_get_flags(req->file) <<
+                                               REQ_F_SUPPORT_NOWAIT_BIT;
+
                return true;
+       }

        req_set_fail(req);
        req->result = -EBADF;


Regards
Yin, Fengwei