Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp2958631imw; Sun, 17 Jul 2022 22:02:52 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u0fCmGFmqKlF+i4YwlY8s5+wemmhdLQQpGdA2jV+Bg9Rupkmay3yn7+jizz7v9MNHLm3jb X-Received: by 2002:a17:902:cad1:b0:16c:9816:648a with SMTP id y17-20020a170902cad100b0016c9816648amr24771219pld.166.1658120571949; Sun, 17 Jul 2022 22:02:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658120571; cv=none; d=google.com; s=arc-20160816; b=xCZZJefr53zIVbwgoBGJefznnLPoN9MzzdH6Ui5C8WGiioiMkL6YrviIwqRyVYl8Af LrLXQNah5wZroLPU43/831ULVZp+VPqvEF7zhpbtGEszc99CtkAfeT1+ENitisdL3nc1 mVCRg4oVBHVq3OvgcI70JtgVpmwELs6qydNxDJpvnAkUGHFNfa0PffNWVUkLK7p+mJqO DJG/eKVd29BBwu470Jn2PDlT+1AZLsarvUiehwtSUGYK1UuiFl+LebBXfuSHY/iqOApB NvSJwL369TND7Zvwx6q2yWSBrOoewob4AXM9SK0u7kDcCbnC0D4pMqR16wneW31XveXz hHVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=PJGZghyUiQePHBonFW3MIUSnC6/CE48ju67sSDQu/Pk=; b=EyQnFOKpBS07PDS3VxSN68szGliwIcjWMo2DbOo3yZEJuQNAcnjFz1P+uc5DQX2DAk zksE1FtGM02N9swGesysPro82SHuCc72vPEV8r4kaM/tUwecYNtHglfrZA7gWuMn4g8p MqqA84QdoLmle2J76+M8NHUVveOXgazSHbLV32g+U1BCVpTmix8hVKdzJSwxPkA2Uir6 uC4MFJSD4Ev6RFNHWrJ4IkR/eLsJF8h0oI5XZwwAs48l26e8zO3X8Df5iNnSj8F3Ai+U ZtamNsTWKKzFtsCIzBd2xMUBqjdsQ0huoBvuZZmSyolA/F/CHGSffFTMQwxBuAKNplm1 qw8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IOGe+5Yi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mq5-20020a17090b380500b001ef8f853cafsi22839813pjb.176.2022.07.17.22.02.30; Sun, 17 Jul 2022 22:02:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IOGe+5Yi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232908AbiGREnN (ORCPT + 99 others); Mon, 18 Jul 2022 00:43:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbiGREnM (ORCPT ); Mon, 18 Jul 2022 00:43:12 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A55DF10551 for ; Sun, 17 Jul 2022 21:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658119390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PJGZghyUiQePHBonFW3MIUSnC6/CE48ju67sSDQu/Pk=; b=IOGe+5Yie7HGeZNXeGXBAiHPYGYmA/CiW9vCZA/M3VEywE7C5sBF2G9pJastLKaAa+eV+5 YvTrTDDZAHeyGHBz4Y79flG1mJh7X2fkODtHi3CPgAhI4RKQbCl1lzVWbLugLScKCcSYNx EcyVtfUj0eqma/Xhh6Nyv/8VNqW2+7I= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-250-hm-2lRIaPqGlawZ9S1fbHg-1; Mon, 18 Jul 2022 00:43:05 -0400 X-MC-Unique: hm-2lRIaPqGlawZ9S1fbHg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ACEFD3C0CD42; Mon, 18 Jul 2022 04:43:04 +0000 (UTC) Received: from gshan.redhat.com (vpn2-54-37.bne.redhat.com [10.64.54.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7C3F11121314; Mon, 18 Jul 2022 04:43:02 +0000 (UTC) From: Gavin Shan To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, shan.gavin@gmail.com Subject: [PATCH] arm64: numa: Don't check node against MAX_NUMNODES Date: Mon, 18 Jul 2022 14:42:32 +0800 Message-Id: <20220718064232.3464373-1-gshan@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the NUMA nodes are sorted by checking ACPI SRAT (GICC AFFINITY) sub-table, it's impossible for acpi_map_pxm_to_node() to return any value, which is greater than or equal to MAX_NUMNODES. Lets drop the unnecessary check in acpi_numa_gicc_affinity_init(). No functional change intended. Signed-off-by: Gavin Shan --- arch/arm64/kernel/acpi_numa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/acpi_numa.c b/arch/arm64/kernel/acpi_numa.c index fdfecf0991ce..e51535a5f939 100644 --- a/arch/arm64/kernel/acpi_numa.c +++ b/arch/arm64/kernel/acpi_numa.c @@ -109,7 +109,7 @@ void __init acpi_numa_gicc_affinity_init(struct acpi_srat_gicc_affinity *pa) pxm = pa->proximity_domain; node = acpi_map_pxm_to_node(pxm); - if (node == NUMA_NO_NODE || node >= MAX_NUMNODES) { + if (node == NUMA_NO_NODE) { pr_err("SRAT: Too many proximity domains %d\n", pxm); bad_srat(); return; -- 2.23.0