Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wu, Hao" <hao.wu@intel.com>
To:     "matthew.gerlach@linux.intel.com" <matthew.gerlach@linux.intel.com>,
        "Xu, Yilun" <yilun.xu@intel.com>,
        "Weight, Russell H" <russell.h.weight@intel.com>,
        "Muddebihal, Basheer Ahmed" <basheer.ahmed.muddebihal@intel.com>,
        "trix@redhat.com" <trix@redhat.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Zhang, Tianfei" <tianfei.zhang@intel.com>
Subject: RE: [PATCH v3 2/2] fpga: dfl-pci: Add IDs for Intel N6000, N6001 and
 C6100 cards
Thread-Topic: [PATCH v3 2/2] fpga: dfl-pci: Add IDs for Intel N6000, N6001 and
 C6100 cards
Thread-Index: AQHYkhMVsoLbDKGMDkCQj83FX47Tpq2Dl6/g
Date:   Mon, 18 Jul 2022 04:27:54 +0000
Message-ID: <DM6PR11MB381961FEAAEC946E46562C83858C9@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <20220707150549.265621-1-matthew.gerlach@linux.intel.com>
 <20220707150549.265621-3-matthew.gerlach@linux.intel.com>
In-Reply-To: <20220707150549.265621-3-matthew.gerlach@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HlMpPQrnJ5/fjxom91cFRLVqb+yJVdRjcLHOO9wgEwVi2Lwi1OgNhsqv+ljw?=
 =?us-ascii?Q?Z4c2KaBaDOZd3D1RMW9KJcDqGUiKXA5GM76n839QPuzn6dCinuTdjJi0oZKD?=
 =?us-ascii?Q?WhJDfVdW0pwyyKM0bFqpAHy0kEziTmxp3HZ+mFeSZou/6YqXs2A7stqeaOEa?=
 =?us-ascii?Q?KWGH000vxpW0BqlS1hAeTVTBdROiJxPyEEhTf9uH+PZQXBe5BgtROX0y7wDd?=
 =?us-ascii?Q?fTGyyFHi+f9cJYJN8/HonEoa3dE1ec04iFKtmzlf3E7yEEBU+x8gNAzneWKi?=
 =?us-ascii?Q?meIQaahjW+I8Angv6EJG8I9hco9+InKVUSn9TX9RoL/pmdZzYRuhXhvKNgHl?=
 =?us-ascii?Q?WGrkdLsR5+XfX1NJDmFB+MH1IVbgpVoIr0xi6cXGo8+/vQzkTv93VsZocmJL?=
 =?us-ascii?Q?MVLHDoaI7a88UK44/HEzDGUZ/zcSACiuH0FERPTleI0eck5NWR9o0qjMkLmj?=
 =?us-ascii?Q?I63EHDNbZCCOPPh774jmwBREBIt7D1geHrt2vzbhy/wMNWOyIpuu9YasZU03?=
 =?us-ascii?Q?Ari1bA393Fgtx/unEggQT8f9MZgCk5KeFIWTN9O/dEYM2U0SSF2NEVZ4CDC8?=
 =?us-ascii?Q?syoXNZrw7ir4O9OzY0Ktp+/EQI0RZMuFCKOmUrNXE6CoRA2H1M1Io5Kcgard?=
 =?us-ascii?Q?y5ie/Ik2Gc7XCZUnnP4iSf6NnYbAym/FJZQ6K9GZQ1/GkQRQIL2q5+KgRwlz?=
 =?us-ascii?Q?wIW19ASZFcdLUZ0K2mQU7HlSXfL7SEFY9BTqIoEYnTqmg/iK82rtGWeg97Jp?=
 =?us-ascii?Q?hUarl/g7lQBqDHe4GPYq4yKCMFsDCrS+5yy9j2vTo5MCvE5wG37kUsblBU2e?=
 =?us-ascii?Q?sRTJY2Sh0bcNCBX7zK/e6A5C1eGA34HIuB8eq/mscvIBO6mJMIf8DCeFjynu?=
 =?us-ascii?Q?GxYHTVbUmS5cpsBA6OclaWUbOlC9fMAv++vMFFq3YSoVvx550jEq2WoTS/VN?=
 =?us-ascii?Q?+WWLTKcYs7XqTHPMfdf/89GmLkB8iYMdNG4mUjwnGKWVgAUqdTO7Z7ZPCLQq?=
 =?us-ascii?Q?TH369Od+8kxmDL00j7Utr3rbhdzOPYWIo7ZqAKp4WfpK46HEHzLiVNFb41Iu?=
 =?us-ascii?Q?Ps1u5dKHM78H0QZHxLEqcB0bIj5cUv6L0CSOtLIsFZRcsahpd7ZAveE9fgy6?=
 =?us-ascii?Q?OCDTWwpzyUDEH7gYf4ORGkv/ShR9lR6C5XJgrdlnYSjAa/kUHf41OK2fX/ZD?=
 =?us-ascii?Q?xehWjraYSpZtR0wQqNjFuNTrAc32OQ4OOtpxiMIZ4pJxnS7giTsadnaFwMp1?=
 =?us-ascii?Q?FRGorPudyS67F7hhnulC15UNIrCkd2YfEZyHjRQeqsZ5r5w92xWETov0j7ps?=
 =?us-ascii?Q?WfsS7udGma0dqIS4BjL2CCErPlTWTEyAmg2KAOgLO7/A6LXRHgRjikxKoESX?=
 =?us-ascii?Q?EoN9tcSneIl05emv+C8aSqqPm5kgW+9DceaHkhvdpg34MAw93KYIZvoHcSM9?=
 =?us-ascii?Q?ELMoVZJ6FqI0sxwa88KL+hlCMUw/LDj7qQCfOZpRXPiSBPn6HfgQ7t2CxK5F?=
 =?us-ascii?Q?+WAQZ0+ZkXB2GkxHBgP/AsSv4hWcQ4DYFPPK3KWtXZ4fxvlyfe9kNLoUY0i+?=
 =?us-ascii?Q?oEg8yeUkCck4Z/ThxGU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3819.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b5f38b8-f98a-4df9-5ec4-08da6875e28f
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 04:27:54.7386
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LL+/LgRU8BxhTzcvDEFuQAmdbe1qQsxe5vaWy9MERLU80OnJTkRhRDeVYUw+bxjPDQ+Y5rF9CkB98AeKyUTR5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5567
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: matthew.gerlach@linux.intel.com <matthew.gerlach@linux.intel.com>
> Sent: Thursday, July 7, 2022 11:06 PM
> To: Wu, Hao <hao.wu@intel.com>; Xu, Yilun <yilun.xu@intel.com>; Weight,
> Russell H <russell.h.weight@intel.com>; Muddebihal, Basheer Ahmed
> <basheer.ahmed.muddebihal@intel.com>; trix@redhat.com;
> mdf@kernel.org; corbet@lwn.net; linux-fpga@vger.kernel.org; linux-
> doc@vger.kernel.org; linux-kernel@vger.kernel.org; Zhang, Tianfei
> <tianfei.zhang@intel.com>
> Cc: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Subject: [PATCH v3 2/2] fpga: dfl-pci: Add IDs for Intel N6000, N6001 and
> C6100 cards
>=20
> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>=20
> Add pci_dev_table entries supporting the Intel N6000, N6001
> and C6100 cards to the dfl-pci driver.
>=20
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> ---
> v3: added necessary subdevice ids
>     removed 'drivers: ' from title
>=20
> v2: changed names from INTEL_OFS to INTEL_DFL
> ---
>  drivers/fpga/dfl-pci.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>=20
> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> index fd1fa55c9113..94eabdf1d2f7 100644
> --- a/drivers/fpga/dfl-pci.c
> +++ b/drivers/fpga/dfl-pci.c
> @@ -77,12 +77,19 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
>  #define PCIE_DEVICE_ID_INTEL_PAC_D5005		0x0B2B
>  #define PCIE_DEVICE_ID_SILICOM_PAC_N5010	0x1000
>  #define PCIE_DEVICE_ID_SILICOM_PAC_N5011	0x1001
> +#define PCIE_DEVICE_ID_INTEL_DFL		0xbcce
>=20
>  /* VF Device */
>  #define PCIE_DEVICE_ID_VF_INT_5_X		0xBCBF
>  #define PCIE_DEVICE_ID_VF_INT_6_X		0xBCC1
>  #define PCIE_DEVICE_ID_VF_DSC_1_X		0x09C5
>  #define PCIE_DEVICE_ID_INTEL_PAC_D5005_VF	0x0B2C
> +#define PCIE_DEVICE_ID_INTEL_DFL_VF		0xbccf
> +
> +/* PCI Subdevice ID */
> +#define PCIE_SUBDEVICE_ID_INTEL_N6000		0x1770
> +#define PCIE_SUBDEVICE_ID_INTEL_N6001		0x1771
> +#define PCIE_SUBDEVICE_ID_INTEL_C6100		0x17d4

Please move SUBDEVICE_ID above together with DEVICE_ID.=20
If we add new SUBDEVICE to some other device like this, it will
be hard to distinguish them.

With above change.
Acked-by: Wu Hao <hao.wu@intel.com>

Thanks
Hao