Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 12.22.5.235 as permitted sender) receiver=protection.outlook.com;
 client-ip=12.22.5.235; helo=mail.nvidia.com; pr=C
Message-ID: <f4dc33b6-4023-1ac3-9365-c51175375bc7@nvidia.com>
Date:   Mon, 18 Jul 2022 11:05:06 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] cpufreq: tegra194: Staticize struct tegra_cpufreq_soc
 instances
Content-Language: en-US
To:     Viresh Kumar <viresh.kumar@linaro.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        "Jonathan Hunter" <jonathanh@nvidia.com>
CC:     <linux-pm@vger.kernel.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        kernel test robot <lkp@intel.com>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Sumit Gupta <sumitg@nvidia.com>
References: <5c1a9b405d96848f2dac9aefcef121ad178872f4.1658109927.git.viresh.kumar@linaro.org>
From:   Sumit Gupta <sumitg@nvidia.com>
In-Reply-To: <5c1a9b405d96848f2dac9aefcef121ad178872f4.1658109927.git.viresh.kumar@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 05:35:12.8861
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 14f03849-5ed0-4439-d798-08da687f498e
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[12.22.5.235];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT023.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB4786
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 18/07/22 07:35, Viresh Kumar wrote:
> External email: Use caution opening links or attachments
> 
> 
> Fix sparse warnings by marking these structures static.
> 
> Fixes: 273bc890a2a8 ("cpufreq: tegra194: Add support for Tegra234")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

Reviewed-by: Sumit Gupta <sumitg@nvidia.com>

> ---
>   drivers/cpufreq/tegra194-cpufreq.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c
> index 2a6a98764a8c..1216046cf4c2 100644
> --- a/drivers/cpufreq/tegra194-cpufreq.c
> +++ b/drivers/cpufreq/tegra194-cpufreq.c
> @@ -162,7 +162,7 @@ static struct tegra_cpufreq_ops tegra234_cpufreq_ops = {
>          .set_cpu_ndiv = tegra234_set_cpu_ndiv,
>   };
> 
> -const struct tegra_cpufreq_soc tegra234_cpufreq_soc = {
> +static const struct tegra_cpufreq_soc tegra234_cpufreq_soc = {
>          .ops = &tegra234_cpufreq_ops,
>          .actmon_cntr_base = 0x9000,
>          .maxcpus_per_cluster = 4,
> @@ -430,7 +430,7 @@ static struct tegra_cpufreq_ops tegra194_cpufreq_ops = {
>          .set_cpu_ndiv = tegra194_set_cpu_ndiv,
>   };
> 
> -const struct tegra_cpufreq_soc tegra194_cpufreq_soc = {
> +static const struct tegra_cpufreq_soc tegra194_cpufreq_soc = {
>          .ops = &tegra194_cpufreq_ops,
>          .maxcpus_per_cluster = 2,
>   };
> --
> 2.31.1.272.g89b43f80a514
>