Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d75d1339-4539-330a-680b-2d940e603a72@kernel.org>
Date:   Mon, 18 Jul 2022 09:02:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 2/2] tty: serial: fsl_lpuart: writing a 1 and then a 0 to
 trigger a break character
Content-Language: en-US
To:     Michael Walle <michael@walle.cc>, Sherry Sun <sherry.sun@nxp.com>
Cc:     gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org, dl-linux-imx <linux-imx@nxp.com>
References: <20220715025944.11076-1-sherry.sun@nxp.com>
 <20220715025944.11076-3-sherry.sun@nxp.com>
 <509669b26b5899088e9b77ed94d103ee@walle.cc>
 <AS8PR04MB840448675E64E4FCDEEF91A1928B9@AS8PR04MB8404.eurprd04.prod.outlook.com>
 <e2560f01fd1731ea2422d82c97efcc6f@walle.cc>
 <AS8PR04MB8404B8E3EB0FFCEE8ADDA283928B9@AS8PR04MB8404.eurprd04.prod.outlook.com>
 <61c525fc87d6586c024cd6e42fcf876d@walle.cc>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <61c525fc87d6586c024cd6e42fcf876d@walle.cc>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 15. 07. 22, 13:52, Michael Walle wrote:
>> Seems we have the different understanding of the break_ctl(port,ctl)
>> callback. The original break_ctl(tty,-1) in lpuart will not send the
>> break signal until we call break_ctl(tty,0).
> 
> That is not correct. The TX linue goes low as soon as the SBK bit
> is set. See below.

In that case…

>> Per my understanding of
>> "If ctl is nonzero, the break signal should be transmitted", call
>> break_ctl(tty,-1) is enough the send one break signal, now my patch
>> makes the behavior align with my understanding.
> 
> As I said, Greg should clarify here.
> 
> In any case, I've checked the hardware (LS1028A) and as soon as you
> set the SBK bit, the TX line goes low (TTL levels) as expected. It
> will go to high again as soon as you clear the bit again.
> 
> So to me it seems there is nothing wrong here. Also have a look
> at man ioctl_tty:
> 
>         TIOCSBRK
>                Turn break on, that is, start sending zero bits.
> 
>         TIOCCBRK
>                Turn break off, that is, stop sending zero bits.
> 
> So to send one break "character", you need to do ioctl(TIOCSBRK)
> followed by an ioctl(TIOCCBRK).

… you're right.

regards,
-- 
js