Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <4B9D76D5-C794-4A49-A76F-3D4C10385EE0@kohlschutter.com>
In-Reply-To: <4B9D76D5-C794-4A49-A76F-3D4C10385EE0@kohlschutter.com>
From:   Miklos Szeredi <miklos@szeredi.hu>
Date:   Mon, 18 Jul 2022 11:14:02 +0200
Message-ID: <CAJfpegs1Kta-HcikDGFt4=fa_LDttCeRmffKhUjWLr=DxzXg-A@mail.gmail.com>
Subject: Re: [PATCH] ovl: Handle ENOSYS when fileattr support is missing in
 lower/upper fs
To:     =?UTF-8?Q?Christian_Kohlsch=C3=BCtter?= 
        <christian@kohlschutter.com>
Cc:     overlayfs <linux-unionfs@vger.kernel.org>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Content-Type: multipart/mixed; boundary="000000000000a2f11305e410ca32"
Precedence: bulk

--000000000000a2f11305e410ca32
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 4 Jul 2022 at 20:36, Christian Kohlsch=C3=BCtter
<christian@kohlschutter.com> wrote:
>
> overlayfs may fail to complete updates when a filesystem lacks
> fileattr/xattr syscall support and responds with an ENOSYS error code,
> resulting in an unexpected "Function not implemented" error.

Issue seems to be with fuse: nothing should be returning ENOSYS to
userspace except the syscall lookup code itself.  ENOSYS means that
the syscall does not exist.

Fuse uses ENOSYS in the protocol to indicate that the filesystem does
not support that operation, but that's not the value that the
filesystem should be returning to userspace.

The getxattr/setxattr implementations already translate ENOSYS to
EOPNOTSUPP, but ioctl doesn't.

The attached patch (untested) should do this.   Can you please give it a tr=
y?

Thanks,
Miklos

--000000000000a2f11305e410ca32
Content-Type: text/x-patch; charset="US-ASCII"; name="fuse-ioctl-translate-enosys.patch"
Content-Disposition: attachment; 
	filename="fuse-ioctl-translate-enosys.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_l5qj3i030>
X-Attachment-Id: f_l5qj3i030

LS0tCiBmcy9mdXNlL2lvY3RsLmMgfCAgIDE1ICsrKysrKysrKysrKystLQogMSBmaWxlIGNoYW5n
ZWQsIDEzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgotLS0gYS9mcy9mdXNlL2lvY3Rs
LmMKKysrIGIvZnMvZnVzZS9pb2N0bC5jCkBAIC05LDYgKzksMTcgQEAKICNpbmNsdWRlIDxsaW51
eC9jb21wYXQuaD4KICNpbmNsdWRlIDxsaW51eC9maWxlYXR0ci5oPgogCitzdGF0aWMgc3NpemVf
dCBmdXNlX3NlbmRfaW9jdGwoc3RydWN0IGZ1c2VfbW91bnQgKmZtLCBzdHJ1Y3QgZnVzZV9hcmdz
ICphcmdzKQoreworCXNzaXplX3QgcmV0ID0gZnVzZV9zaW1wbGVfcmVxdWVzdChmbSwgYXJncyk7
CisKKwkvKiBUcmFuc2xhdGUgRU5PU1lTLCB3aGljaCBzaG91bGRuJ3QgYmUgcmV0dXJuZWQgZnJv
bSBmcyAqLworCWlmIChyZXQgPT0gLUVOT1NZUykKKwkJcmV0ID0gLUVOT1RUWTsKKworCXJldHVy
biByZXQ7Cit9CisKIC8qCiAgKiBDVVNFIHNlcnZlcnMgY29tcGlsZWQgb24gMzJiaXQgYnJva2Ug
b24gNjRiaXQga2VybmVscyBiZWNhdXNlIHRoZQogICogQUJJIHdhcyBkZWZpbmVkIHRvIGJlICdz
dHJ1Y3QgaW92ZWMnIHdoaWNoIGlzIGRpZmZlcmVudCBvbiAzMmJpdApAQCAtMjU5LDcgKzI3MCw3
IEBAIGxvbmcgZnVzZV9kb19pb2N0bChzdHJ1Y3QgZmlsZSAqZmlsZSwgdW4KIAlhcC5hcmdzLm91
dF9wYWdlcyA9IHRydWU7CiAJYXAuYXJncy5vdXRfYXJndmFyID0gdHJ1ZTsKIAotCXRyYW5zZmVy
cmVkID0gZnVzZV9zaW1wbGVfcmVxdWVzdChmbSwgJmFwLmFyZ3MpOworCXRyYW5zZmVycmVkID0g
ZnVzZV9zZW5kX2lvY3RsKGZtLCAmYXAuYXJncyk7CiAJZXJyID0gdHJhbnNmZXJyZWQ7CiAJaWYg
KHRyYW5zZmVycmVkIDwgMCkKIAkJZ290byBvdXQ7CkBAIC0zOTMsNyArNDA0LDcgQEAgc3RhdGlj
IGludCBmdXNlX3ByaXZfaW9jdGwoc3RydWN0IGlub2RlCiAJYXJncy5vdXRfYXJnc1sxXS5zaXpl
ID0gaW5hcmcub3V0X3NpemU7CiAJYXJncy5vdXRfYXJnc1sxXS52YWx1ZSA9IHB0cjsKIAotCWVy
ciA9IGZ1c2Vfc2ltcGxlX3JlcXVlc3QoZm0sICZhcmdzKTsKKwllcnIgPSBmdXNlX3NlbmRfaW9j
dGwoZm0sICZhcmdzKTsKIAlpZiAoIWVycikgewogCQlpZiAob3V0YXJnLnJlc3VsdCA8IDApCiAJ
CQllcnIgPSBvdXRhcmcucmVzdWx0Owo=
--000000000000a2f11305e410ca32--