Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3141718imw; Mon, 18 Jul 2022 02:55:19 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tmQ00PQtdCTDenY9RIu3aSi6tYRVRinj5Q5jl6DQyBouw3B7NlZ1L03Xrto5q8HPgKoGF0 X-Received: by 2002:a17:906:6c82:b0:709:f868:97f6 with SMTP id s2-20020a1709066c8200b00709f86897f6mr24524525ejr.555.1658138118602; Mon, 18 Jul 2022 02:55:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658138118; cv=none; d=google.com; s=arc-20160816; b=mhaObLlsKWmQJDXlGh5pQ/YDeAwfZz9AzL6u8tEjWPe+ebYti0XwqLNdfPqXHCq+0C bc4R9DIg71xn5UfTQvrcJVs96M3CA0vGOmx7idOkgb4fmMnIcr+iay1eNfQ5dFWma9ju YmlgbxNkVmRpYG9vx/2tqoJ0X727EQV216u6M64TFVth3KfeQjjyQVoPVK0zAdE6mdUL dvN3jpJu5rGUaeDCvzkHcjUPcffrxjAz5YcuIu/vLV8MjnkOqDN3Vy1oKkUtR8+ihZCM +P7K5ZbHD/XvWVXiRa06D6UM4G+MWWU9FfcamawwlCZ/2AuKmCdCubyZiM864p2zlFF4 6tJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Um6tQ7ZbIk6/SLu0gTbqf7n6ewcb0e4sta2uEmym+rI=; b=RLu8IXksLjf03SxJO+QTaKrmq+Rtg78oREj4e1F2U1DzXhiwozdDx9xnt4mS9E6ks8 CdYJwP7b1xgbmlYgphXxcxg8c4CFQpGPfOH1Ak6UhVjFZeKU+MipjghZOuSQXfctlSkw 9hbVtHp9uDdGQI9Fl/czsa0/l4tBce452C5WXnt7z0u9A8XwR1G5pibzncYNOtB38KW3 UUR8Fl8bJ3IBywsGIMjjDbLL5bbH6GRLh9/eCGJKAkk8jGS0lUjXIDh1jc6jZY9H5R4R sBLxBwmFSgp2t0hFzlXok5v1YNsiTUmy5TFsKf3f+zqhT2y2AmkyEtlFDIOyzGbBMx/h sa8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KBCLwm9x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd38-20020a17090762a600b00726b031a475si14994726ejc.758.2022.07.18.02.54.49; Mon, 18 Jul 2022 02:55:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KBCLwm9x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234071AbiGRJ2q (ORCPT + 99 others); Mon, 18 Jul 2022 05:28:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234087AbiGRJ2p (ORCPT ); Mon, 18 Jul 2022 05:28:45 -0400 Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58A191A06F for ; Mon, 18 Jul 2022 02:28:44 -0700 (PDT) Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-31dfe25bd49so63171897b3.2 for ; Mon, 18 Jul 2022 02:28:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Um6tQ7ZbIk6/SLu0gTbqf7n6ewcb0e4sta2uEmym+rI=; b=KBCLwm9x4+fLjkyddez8bnY48JwDx33er4U9UiZDXU6UrrEqW9mCVimFlCFqkPxMgC hx3W+qAiiZ+BfyB0AGUcsMwf3z+CQfAycCbKx0If9anpXS55BC0vurh/+mu4WXqUktn+ MnBITM2XoRXWcSCrT6K5MHV54CxJCPLbr5qv62i13guK09LM4vY6jdSZfujRFwCUwqEg AK7f84n3SvLhaILuS598eszpJZ3x33tm21xMaVyM2c1uyFOLcRRtvlm8GkFuxNEAahA2 KFmTBAi/4gOUfkiL7JpW+c9T5WS29Ogq6mOkbbxH86Yv5lgn12K//fmMNuf7Hj645Pdd Llhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Um6tQ7ZbIk6/SLu0gTbqf7n6ewcb0e4sta2uEmym+rI=; b=FaAqOdUQENpBPkYEt3IpcbRPsb9tRr3daOypIeiyrFnLzIhDybw9dd75oz5UNplmVT rvFDqrs815aGCkuxWW1sryu0a9o8prf5iUf5p5IrQEjptI4+FxCqIpT/kg9YutewveHs KkQIKJEeQAy19UCjgKZAdg2PVcnYraBAiDXi4zIo5wr1P3FLEW3ZVrR1EIcgPYFwjz/L jSTPnBC3tLcKCKqeCjubBk4uwFY1YRJSsK3zikr7JEMTEvYOFtP2+2hmcv560Nx8uL8f 7fPtL22+/XGop3A2bGiHVzXd5zpdNe3aK96p7G+JFUW0MAwey0A2Ri5qoHWy1qX9fhDt A46Q== X-Gm-Message-State: AJIora81VIr9hOfGEPt/fnyJMf/EMsjsIGNLzaJKC7Rx86EWhdMRq3PD ERF2IYyy2lVQPuEHJ723UKX7Xci13mh2RdlX4bt6OQ== X-Received: by 2002:a0d:d997:0:b0:31d:669c:5bd7 with SMTP id b145-20020a0dd997000000b0031d669c5bd7mr29282562ywe.340.1658136523467; Mon, 18 Jul 2022 02:28:43 -0700 (PDT) MIME-Version: 1.0 References: <20220714020319.72952-1-warthog618@gmail.com> <20220714020319.72952-2-warthog618@gmail.com> In-Reply-To: <20220714020319.72952-2-warthog618@gmail.com> From: Linus Walleij Date: Mon, 18 Jul 2022 11:28:31 +0200 Message-ID: Subject: Re: [PATCH v2 1/6] gpiolib: cdev: simplify linereq_free To: Kent Gibson Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, dipenp@nvidia.com, andy.shevchenko@gmail.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2022 at 4:03 AM Kent Gibson wrote: > The edge detector is only ever started after the line desc has been > determined, so move edge_detector_stop() inside the line desc check, > and merge the two checked regions into one. > > Signed-off-by: Kent Gibson > Reviewed-by: Andy Shevchenko Ooops reviewed v1 because of too deep mailbox. Reviewed-by: Linus Walleij Yours, Linus Walleij