Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3143158imw; Mon, 18 Jul 2022 02:57:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vts4XVitG6Ly7bQ6FhU3JfVFeQlXtQqrssa4dzv2GPuRdTROeABruLf/zuKYXUp7t+bBy/ X-Received: by 2002:a05:6402:3708:b0:433:2d3b:ed5 with SMTP id ek8-20020a056402370800b004332d3b0ed5mr35506205edb.246.1658138222617; Mon, 18 Jul 2022 02:57:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658138222; cv=none; d=google.com; s=arc-20160816; b=uHnL3O5d8fBJCC5wLhrhJaqUWW7SrU7DAgs9C+b8XN0LNGa/lf4rUshMmtHV0/pdDu REkQf7rDpXntjbXu+GHB8ujd1mlkchn6kIxRAfa7lUzlsOsTQs3r+00WmUbbP8oZzOS6 Xl5BeUlpxUUqOCpahQKfq/L84dtbocib2RV1FjVwJh9Q1/iXrHA+Humg7eK6WDOBHJsU Z1uJscwiD1G+LzMbZ+VdEe8KBd78fI4LGQ9PYZVAxSMHfZMbhnD8pMZj6pMYu9P5n/Ot U/7Ze5mhXodT/Doai7haceef9cqBBLSUqTgcVhlArwOJM0Ib16Xoe47zAs50MT85Vajl ZpPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oTmOB8yo+CeOW/x2gXHKwKJKdaB20O3po3tWH5tWy+0=; b=QX4wYc4+3m31hAU+CbbkvlwEMinAHZC5xeJ2ISbxXThRanhFjVmmNWbPQbq0DQpfk7 APjJ+ClyMfdAngi4dgkDR4+fgCFxzOgZkc72aEcKTcDt96nF6B6XQucRGAiIIIwlwaz8 VskY9aKNEII5lABLNbMnQM1W8X5Dkbf6BLa7iAiidOBHPpJYmNvu5OTHMm6tulCe/zdI u+O+c84ehtZidPWpz4Wkp8Et59zIqOCA0aBZ3FwM93HB0EwERlvkdjT4YgtS0+D+zpei H3GYJbzOsU8esnXdi+U5PcqeqFv9hql0+nYYzsoaFKcvBaS7BCCn0RbsTeJEs0viEka7 g5lA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=okoNEbVF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga4-20020a1709070c0400b00726ab8af824si17365329ejc.788.2022.07.18.02.56.37; Mon, 18 Jul 2022 02:57:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=okoNEbVF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233885AbiGRJL2 (ORCPT + 99 others); Mon, 18 Jul 2022 05:11:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230491AbiGRJL0 (ORCPT ); Mon, 18 Jul 2022 05:11:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67563120BA; Mon, 18 Jul 2022 02:11:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0D9BEB81081; Mon, 18 Jul 2022 09:11:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4271BC341C0; Mon, 18 Jul 2022 09:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658135483; bh=Jic7A95Hn12mCrYPi0y/G4oO9/zECmm3bYpr4pbBPXw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=okoNEbVFp5P4XVu8vEiMBS9uJ6YHPgaFDESrYgzdCv1QZVnz4oTkZHb/dJe106pUP uD9eBTNUzBTmSYcZQ5byWtBmeb1mHastOHHpnppKeZ568ZNkl2AdBC7pHB1InIM1ZD rJIEmk+fIWGFA7U2YOh9dwx5RaE4FpFX21HSS3T56WKyU+AFAKmZYk8rMvdml5ge7+ 0hA2cgEcJ676mgwda0hOfofo62wialinH4BywAo26I8qxmKG+bE/w3Cp+JXuN7rwLj n1qX5KAy+tOPC5Zg/erri6vvqAdsddda8iycrzJ4b7X59BL3QolqXvnI0Lcp3IXP6R +6sEr2iP6A0kw== Date: Mon, 18 Jul 2022 12:11:19 +0300 From: Leon Romanovsky To: Andrey Strachuk Cc: Bernard Metzler , Jason Gunthorpe , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] RDMA: remove useless condition in siw_create_cq() Message-ID: References: <20220711151251.17089-1-strochuk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220711151251.17089-1-strochuk@ispras.ru> X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 11, 2022 at 06:12:51PM +0300, Andrey Strachuk wrote: > Comparison of 'cq' with NULL is useless since > 'cq' is a result of container_of and cannot be NULL > in any reasonable scenario. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Andrey Strachuk > Fixes: 303ae1cdfdf7 ("rdma/siw: application interface") > --- > drivers/infiniband/sw/siw/siw_verbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied.