Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Jul 2022 17:46:20 +0800
From:   Kent Gibson <warthog618@gmail.com>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        brgl@bgdev.pl, dipenp@nvidia.com, andy.shevchenko@gmail.com
Subject: Re: [PATCH v2 5/6] gpiolib: cdev: consolidate edge detector
 configuration flags
Message-ID: <20220718094620.GA96704@sol>
References: <20220714020319.72952-1-warthog618@gmail.com>
 <20220714020319.72952-6-warthog618@gmail.com>
 <CACRpkdZ5O7iNOaJgq5D8hpQDO207DsQkqjRu_m1aZSPy5_qoJA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACRpkdZ5O7iNOaJgq5D8hpQDO207DsQkqjRu_m1aZSPy5_qoJA@mail.gmail.com>
Precedence: bulk

On Mon, Jul 18, 2022 at 11:33:48AM +0200, Linus Walleij wrote:
> On Thu, Jul 14, 2022 at 4:04 AM Kent Gibson <warthog618@gmail.com> wrote:
> 
> > Combine the polarity_change flag, struct line eflags, and hte enable
> > flag into a single flag variable.
> >
> > The combination of these flags describes the configuration state
> > of the edge detector, so formalize and clarify that by combining
> > them into a single variable, edflags, in struct line.
> >
> > The edflags is a subset of the GPIO_V2_LINE_FLAGsb relevant to
> 
> What is that "b" at the end of GPIO_V2_LINE_FLAGsb?
> Oh well no big deal. Bart can fix when applying if it is disturbing.
> 

Yeah, typo or something - no idea what that is doing there, but it has
been there since v1. ¯\_(ツ)_/¯
Bart - please do fix that if you don't mind.

Thanks for the review.

Cheers,
Kent.