Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3168146imw; Mon, 18 Jul 2022 03:25:06 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sPLJIU/Ub3eQwHOgpeL0iZ++pH1xtOiVD1cgfNN6CBMBh3iXFYu4LsXRUbj20tVHvII1w0 X-Received: by 2002:a05:6402:40c9:b0:43a:a20d:3fe5 with SMTP id z9-20020a05640240c900b0043aa20d3fe5mr35957225edb.154.1658139906772; Mon, 18 Jul 2022 03:25:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658139906; cv=none; d=google.com; s=arc-20160816; b=iFx9Vn0e96Ag8sma5EO+Fvb9S8KQDsTiItNFs8EPyLCThXst4xzJdAz1CVVVvGSx7C RjUYK+xcqjbyVG9Vyn5VmoT50uTkUAVyvSWC3hS/muJKivKqZ7PElibqVd8gCy+nh3Kp S9GdHk+V8sanMaWV+mQQq4h046/KH+DT3ro71mh+xwjT5Z9xLHz8LnDB8k01bDjFo9Cn rPBaBrxlQRD90Vqwf83ppmHv0JlplWhINjhgc1X0U6S4O1FvTYAlV4btfu4yTFTv8Tgt dQqhNdYN2OXSMx9E3D1pbcAq1jWOY4etmpdpcWeCmxRSyAA5fy6Ywd5ByH73o5B5xmGn iFkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=+icv+IJ1TJ8/3xu2M4sP7/7AeCsZ4gFWLPwS5u9SNFg=; b=OqamHKFlkyzxdpt67xzxrN0fPGFk327V5zaUrwbcALLLL64aWmhkPDXrUeXvKRlbRa QneYfaHF7tPz5ZBUeekBBEElv25LCL20Y8HY6KmqxJIkq7HN4iHRua5YE0GLNG0gjFBn U4iiGdzkYGwD9tDZGkSq0Tj8wbzC/TUWw/wTFY6Q/AuNvW114TUyu8rzOwMxdYP6NY13 tR+d70O1bb5BpXJ7bu6HtwTINDHVlUcY0oQXymLYQz5ubLdfyP9oWYn3Yl3sVZ5t07h0 u7ZRlp7FK1thVSF/MWAi4TwIx09xDBzdvfaCKCoG+rk1fiQoqrx9FISK/R70WGDh+GdM EaNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=agRDU6yW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g19-20020a1709065d1300b0072dec358d16si15280149ejt.524.2022.07.18.03.24.42; Mon, 18 Jul 2022 03:25:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=agRDU6yW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234037AbiGRJ12 (ORCPT + 99 others); Mon, 18 Jul 2022 05:27:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233907AbiGRJ11 (ORCPT ); Mon, 18 Jul 2022 05:27:27 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0169E19C15 for ; Mon, 18 Jul 2022 02:27:26 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id l23so20122980ejr.5 for ; Mon, 18 Jul 2022 02:27:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+icv+IJ1TJ8/3xu2M4sP7/7AeCsZ4gFWLPwS5u9SNFg=; b=agRDU6yWNC6T3uQoKsXpznz1Nlk4E3NowXCVh5Op296iiyVx9blby60QuJ42Nh8nGJ 23rlSGHxc2W2PI/uZQGe4hex0YLlie2DBijssE75xA67XCP59AOl0IWMf0JJse8KtbAn yjrwOUftMzLC4TAXDzV1JUNGEvxK7pZPPZp5F4UIO/MA2N6ugLyx+gdb1bbDCDVvOz9O n2FaZm4mUbuet201w1dpS00dzTpJLSqh6BbIngIAyrowzsCKOsU+pF2XucMpHq7wf9p0 nVXMwkcMN7uzxLKEB34PGkDsRJX7uMnhIR4HBDUBzqgt4rswVc55NvgQGLF+0CY8I/9m yEzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+icv+IJ1TJ8/3xu2M4sP7/7AeCsZ4gFWLPwS5u9SNFg=; b=UJ1jd+qM6lveTAN2durVQ2Iy1BeLv8JLWsB46SQm0/vMoKc2l/URKER8kWNBmMHBdY 2jfHVcmBGjHWcnaCez/Ysf6afx6I0pkiT8/pNChgopBbxI4pRUR0C0VP8V9a7RkmycrQ RGWc5qbSAc5DgGW6MLhO2ZwfgGrF5brQswu5LoaizlQLyF+udERbJdkp+7rJlLf4nInm pXxRE3jsG+yBZLZYY+ushgVLdFuaJ9eRcx2Lr2pJ/ti0a4KF5VeVvK40Ycfk4sfr7vRe +q6ENney3AOEmHWfHhopKJVEtyNzeLMZeCoQBQU76NAGzhH9Kg4wCflSv0tAYJNJ5s/v 8egg== X-Gm-Message-State: AJIora9duD0x8B/NW/XY7DdAZh1gNZ9qZ1qZDgpik/u1jdouxLosu6Te qGJ6w5U6YR39mGDBSjWQ0OCibARgvp5HTgS2gOljsg== X-Received: by 2002:a17:907:9612:b0:72e:56bd:2b9a with SMTP id gb18-20020a170907961200b0072e56bd2b9amr21685288ejc.526.1658136444582; Mon, 18 Jul 2022 02:27:24 -0700 (PDT) MIME-Version: 1.0 References: <20220713013721.68879-1-warthog618@gmail.com> <20220713013721.68879-2-warthog618@gmail.com> In-Reply-To: <20220713013721.68879-2-warthog618@gmail.com> From: Linus Walleij Date: Mon, 18 Jul 2022 11:27:13 +0200 Message-ID: Subject: Re: [PATCH 1/6] gpiolib: cdev: simplify linereq_free To: Kent Gibson Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, dipenp@nvidia.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2022 at 3:37 AM Kent Gibson wrote: > The edge detector is only ever started after the line desc has been > determined, so move edge_detector_stop() inside the line desc check, > and merge the two checked regions into one. > > Signed-off-by: Kent Gibson Reviewed-by: Linus Walleij Yours, Linus Walleij