Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1dbd95e8-e6d7-a611-32d0-ea974787ff5a@hartkopp.net>
Date:   Mon, 18 Jul 2022 12:23:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [RFC PATCH 2/5] can: slcan: remove legacy infrastructure
Content-Language: en-US
To:     Marc Kleine-Budde <mkl@pengutronix.de>
Cc:     Max Staudt <max@enpas.org>,
        Dario Binacchi <dario.binacchi@amarulasolutions.com>,
        linux-kernel@vger.kernel.org,
        Jeroen Hofstee <jhofstee@victronenergy.com>,
        michael@amarulasolutions.com,
        Amarula patchwork <linux-amarula@amarulasolutions.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
References: <20220716170007.2020037-1-dario.binacchi@amarulasolutions.com>
 <20220716170007.2020037-3-dario.binacchi@amarulasolutions.com>
 <20220717233842.1451e349.max@enpas.org>
 <6faf29c7-3e9d-bc21-9eac-710f901085d8@hartkopp.net>
 <20220718101507.eioy2bdcmjkgtacz@pengutronix.de>
From:   Oliver Hartkopp <socketcan@hartkopp.net>
In-Reply-To: <20220718101507.eioy2bdcmjkgtacz@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/18/22 12:15, Marc Kleine-Budde wrote:
> On 18.07.2022 08:57:21, Oliver Hartkopp wrote:
>>> What do the maintainers think of dropping the old "slcan" name, and
>>> just allowing this to be a normal canX device? These patches do bring
>>> it closer to that, after all. In this case, this name string magic
>>> could be dropped altogether.
>>>
>>
>> I'm fine with it in general. But we have to take into account that there
>> might be existing setups that still might use the slcan_attach or slcand
>> mechanic which will likely break after the kernel update.
>>
>> But in the end the slcan0 shows up everywhere - even in log files, etc.
>>
>> So we really should name it canX. When people really get in trouble with it,
>> they can rename the network interface name with the 'ip' tool ...
> 
> Don't break user space! If you don't like slcanX use udev to give it a
> proper name.

Ok. Fine with me too.

IMO it does not break user space when slcan gets the common naming 
schema for CAN interface names.

We had the same thing with 'eth0' which is now named enblablabla or 
'wlan0' now named wlp2s0.

But I have no strong opinion on that naming ...

Best regards,
Oliver