Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220712013632.7042-1-bingjingc@synology.com> <20220712145201.GA1074561@falcondesktop>
In-Reply-To: <20220712145201.GA1074561@falcondesktop>
From:   bingjing chang <bxxxjxxg@gmail.com>
Date:   Mon, 18 Jul 2022 18:39:12 +0800
Message-ID: <CAMmgxWGu9AJELK3hM10CoS8q38JfVB0yvbFr6=LpFqApXFqXVg@mail.gmail.com>
Subject: Re: [PATCH v2 0/2] btrfs: send: fix sending link commands for
 existing file paths
To:     Filipe Manana <fdmanana@kernel.org>
Cc:     bingjingc <bingjingc@synology.com>, Chris Mason <clm@fb.com>,
        David Sterba <dsterba@suse.com>,
        Josef Bacik <josef@toxicpanda.com>,
        linux-btrfs <linux-btrfs@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Robbie Ko <robbieko@synology.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Filipe Manana <fdmanana@kernel.org>=E6=96=BC 2022=E5=B9=B47=E6=9C=8812=E6=
=97=A5 =E9=80=B1=E4=BA=8C=EF=BC=8C=E4=B8=8B=E5=8D=8810:52=E5=AF=AB=E9=81=93=
=EF=BC=9A
>
> On Tue, Jul 12, 2022 at 09:36:30AM +0800, bingjingc wrote:
> > From: BingJing Chang <bingjingc@synology.com>
> >
> > There is a bug sending link commands for existing file paths. When we'r=
e
> > processing an inode, we go over all references. All the new file paths =
are
> > added to the "new_refs" list. And all the deleted file paths are added =
to
> > the "deleted_refs" list. In the end, when we finish processing the inod=
e,
> > we iterate over all the items in the "new_refs" list and send link comm=
ands
> > for those file paths. After that, we go over all the items in the
> > "deleted_refs" list and send unlink commands for them. If there are
> > duplicated file paths in both lists, we will try to create them before =
we
> > remove them. Then the receiver gets an -EEXIST error when trying the li=
nk
> > operations.
> >
> > BingJing Chang (2):
> >   btrfs: send: introduce recorded_ref_alloc and recorded_ref_free
> >   btrfs: send: fix sending link commands for existing file paths
> >
> >  fs/btrfs/send.c | 195 ++++++++++++++++++++++++++++++++++++++++++++----
> >  1 file changed, 181 insertions(+), 14 deletions(-)
>
> Looks good now, thanks.
>
> Reviewed-by: Filipe Manana <fdmanana@suse.com>
>
> Also, are you planning on submitting a test case for fstests too?

Sorry for my late reply. I will try to add a test case to fstests,
thanks for reminding me.

>
> >
> > --
> > 2.37.0
> >