Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: hpNYio37gaONyuSvvVM0/7xC9x7IKjD3egHnZXArWeJVt5esBQe5YIJU/bvT7zQNkapBL+pYxc
 cLuOtT+sn4pxboydczhzBiOhJ7eGlYzZoUwwh9kIuyydxZ4v7ATRchyEM18YupZLNpZxfX9ZWf
 KjXEbOT7VSqdL5imFbQxL+2hzP7017xyU6tJ1vOc30BqY5ft6WC9zf69NNbJ0wF5yTxJMo45no
 prPeHB7MXiJwzDdRARlSMUj/d3Zhop5m18icYDNZ7iEXL/y/lP4P8dv9zZ/QaQiX9jaiUpEw2i
 7BuwsW+v5cs4X13CrV2Po1ys
IronPort-SDR: 3C+nTYKoFHyuDxHZLy61YSnyERoDNnUSLMUWaL021KuKaE0uICb8f6K2rIOzGJht4gOy/WBbFB
 uWDH14tA8PS8U4kv1klrcEPqfxpQInG/DQMB72Ji0WDcA/4mtE5h/deabsKo5L4FxY/h9jYP9t
 o2xYcnMz45G6Suu8kzj38G4cveM9SYJltVqu710gl1QsTmcq4naId3CleZja8ufALc+rQLIg4n
 IYXWyO1X4S0x2jwfSbotoFY4VgUBn8UxsSX/V5lVSMUn6hZQDon0GseTmiJj4VDHclLoZuMmDd
 zeI=
WDCIronportException: Internal
Message-ID: <dad18548-8487-e059-9538-f34ed46d39c0@opensource.wdc.com>
Date:   Mon, 18 Jul 2022 19:47:57 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v6 5/6] scsi: scsi_transport_sas: Cap shost opt_sectors
 according to DMA optimal limit
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>, joro@8bytes.org,
        will@kernel.org, jejb@linux.ibm.com, martin.petersen@oracle.com,
        hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-ide@vger.kernel.org, iommu@lists.linux.dev,
        linux-scsi@vger.kernel.org, linuxarm@huawei.com
References: <1657797329-98541-1-git-send-email-john.garry@huawei.com>
 <1657797329-98541-6-git-send-email-john.garry@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <1657797329-98541-6-git-send-email-john.garry@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/14/22 20:15, John Garry wrote:
> Streaming DMA mappings may be considerably slower when mappings go through
> an IOMMU and the total mapping length is somewhat long. This is because the
> IOMMU IOVA code allocates and free an IOVA for each mapping, which may
> affect performance.
> 
> For performance reasons set the request queue max_sectors from
> dma_opt_mapping_size(), which knows this mapping limit.
> 
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
>  drivers/scsi/scsi_transport_sas.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c
> index 12bff64dade6..2f88c61216ee 100644
> --- a/drivers/scsi/scsi_transport_sas.c
> +++ b/drivers/scsi/scsi_transport_sas.c
> @@ -225,6 +225,7 @@ static int sas_host_setup(struct transport_container *tc, struct device *dev,
>  {
>  	struct Scsi_Host *shost = dev_to_shost(dev);
>  	struct sas_host_attrs *sas_host = to_sas_host_attrs(shost);
> +	struct device *dma_dev = shost->dma_dev;
>  
>  	INIT_LIST_HEAD(&sas_host->rphy_list);
>  	mutex_init(&sas_host->lock);
> @@ -236,6 +237,11 @@ static int sas_host_setup(struct transport_container *tc, struct device *dev,
>  		dev_printk(KERN_ERR, dev, "fail to a bsg device %d\n",
>  			   shost->host_no);
>  
> +	if (dma_dev->dma_mask) {
> +		shost->opt_sectors = min_t(unsigned int, shost->max_sectors,
> +				dma_opt_mapping_size(dma_dev) >> SECTOR_SHIFT);
> +	}
> +
>  	return 0;
>  }
>  

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research