Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Viswanath Boma (Temp)" <vboma@qti.qualcomm.com>
To:     "manivannan.sadhasivam@linaro.org" <manivannan.sadhasivam@linaro.org>,
        "Viswanath Boma (Temp) (QUIC)" <quic_vboma@quicinc.com>
CC:     "stanimir.varbanov@linaro.org" <stanimir.varbanov@linaro.org>,
        Andy Gross <agross@kernel.org>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/7] venus : Add default values for the control
 V4L2_CID_COLORIMETRY_HDR10_MASTERING_DISPLAY
Thread-Topic: [PATCH 1/7] venus : Add default values for the control
 V4L2_CID_COLORIMETRY_HDR10_MASTERING_DISPLAY
Thread-Index: AQHYlepOQnzhUypSuEKIITnLM9ogAq16q+GAgAlK7DA=
Date:   Mon, 18 Jul 2022 10:31:36 +0000
Message-ID: <SJ0PR02MB88488C32CD93DB22C56FC008858C9@SJ0PR02MB8848.namprd02.prod.outlook.com>
References: <20220712122347.6781-1-quic_vboma@quicinc.com>
 <20220712123523.GB21746@workstation>
In-Reply-To: <20220712123523.GB21746@workstation>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wlGr1xhTwcfRagbwGHchZjgrkQELzOWOqbcWaZa641IdDy9BlTN1rV9/nZII?=
 =?us-ascii?Q?Uz2ycT1xjbHLqZtN9iESb6+O4Efh6xLlNjV/5DiieJun/LN2YkQPsJxMJLBC?=
 =?us-ascii?Q?zD+0d/nYrr6+qaKsTWtNjkd5jYCcBxwUDE2gweAAHAxI5RJuJtKy8IZxRuba?=
 =?us-ascii?Q?RvImqzJK+MgfPbTFPkOv7iotCL1rv0xOYy5Rq9GGrQyUxePs/t6bk2Gy9w10?=
 =?us-ascii?Q?90aJHK/XGMWlSwJ1gDqoNcyiSmHq/OpNGq2rQ6YdF2kJd2ljKaxyNC/Arlbb?=
 =?us-ascii?Q?oeR0Batt71+kt211Fh1IzUH1JQiVzhqN7k+Ek/gxnRxvDLERgdSYE6Mj2+Mn?=
 =?us-ascii?Q?tA6GCxaESEf6rUV485fDSXCSX6yiqjzO3QM9VmZGfJr/ZcGZxul+0lfjmE5J?=
 =?us-ascii?Q?GGWsIF0EYJr9aVeFX8xStceBZczJRPid9vfATCPyikSBk5zg0vNPWa04bLEc?=
 =?us-ascii?Q?Idt2UBaOyUFCUUCj1uBKzNW9sv+STeLj9qDRtSrv5qUim/mY0vY0ithGxea0?=
 =?us-ascii?Q?9GVRfMiLeqb0oIGbqcZL3ga3ECkV+YSlHBwyIG4JjeO5bJ+1jRcOYKbUAD0v?=
 =?us-ascii?Q?DwVuUMqrE5g3qHMfhuMys5xXe5VG6q4pswSKsxHkvqNfYr8eZhR7o5+hbMXs?=
 =?us-ascii?Q?KhIhTs2NBusL/SmU0jD8wkH/1r5UjvQljT6VX+mFEhS6xPNu1X9wCYFNU1PG?=
 =?us-ascii?Q?PZNI6pl83yO1CgFiIxbPnNRqXntb/JI5WqOksUM6gVzeMDkeqJXSi9vaPqsu?=
 =?us-ascii?Q?wW7Dh8Q3ZxyXPBNcvSbtCYw3svmt0b/7dvymqDCJzieEix2Sf1AeHF1sMP7R?=
 =?us-ascii?Q?rgtouaWWOjHBGnSpHhkiumwtx+8fDoSVCU5PoWTaQ/JTXun3YNjDPjIPW36O?=
 =?us-ascii?Q?1qQpGaLaelTjZDMcvec7Gnhs+icU57lF+P41aVjJsy6vXXGjpxy4Y9z7JueU?=
 =?us-ascii?Q?Ld7fWo1qSAbakswtRGCFCeL7PRuT/8Tia1dYRNNg+iSyc5Bl5ykMg4J5o15y?=
 =?us-ascii?Q?QBVDoLCoRTzPpT0i27DvVI5r5r629N5q1OB0t+0HGHE095ugviWs88eXs4UY?=
 =?us-ascii?Q?yl4X0gRkY3NYv/sf9cSWRevCGpbKB5J/MA8Yw+tGKUYtyls6/YaZlE3uzKnf?=
 =?us-ascii?Q?t3Wm4mdCMy3Zr2fircaHmsvSFFUT2Ade9UH7NPCoOeOKPR8envJc7cFpJy2d?=
 =?us-ascii?Q?c5QgwMYKPhSA+mIPqzRnfCVQfXSxi0VjSyMubf8F4OilwZK3M+Lv1MBY+x9W?=
 =?us-ascii?Q?r47TST/zSAS3f93+UAQKWI/mrilGxet4GKCXHb85gRmGvvx9B539bxus1OCy?=
 =?us-ascii?Q?AES+862tNduaUfmtZeb/60y4CcKkevCxK4xDiSLqHti6Qzz0KHZ7n+my1ZTI?=
 =?us-ascii?Q?Y+r7WWvkejiwyNlZpL9CtOsBNNdEje98qUABfnlNRuywGAC3u/f/2/WCWEo4?=
 =?us-ascii?Q?Xj431VVIEzBOXAwAag56FRkz2WxdZkcOCh6b3ehvQuDvRkoVE6xPw9Uj2Lf8?=
 =?us-ascii?Q?nHZBJYYKFMEWyo8Ile86pByFbjEUdNbsiANhjnHwkv7E0lQttpJ/ujy4kwHB?=
 =?us-ascii?Q?tAoeWkkTFju8bgoJjwqongW2SkaHlbFQu7Ql47ZB?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: qti.qualcomm.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR02MB8848.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1172eb8-e2a8-4b72-3118-08da68a8b125
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 10:31:36.1678
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 98e9ba89-e1a1-4e38-9007-8bdabc25de1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1X0s3qm9YtUePAM+4tQKflod9vmsnDZJPKr9xkJPTBEVfL1ROl1PKJuOPhd981hDsFjvqzCcOGe1Wuk5vqNa8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB4089
X-Proofpoint-ORIG-GUID: 9cY9bndN5Iasnf5mz6N8O2zgDPHKL9S9
X-Proofpoint-GUID: 9cY9bndN5Iasnf5mz6N8O2zgDPHKL9S9
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-18_10,2022-07-15_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 spamscore=0 adultscore=0 phishscore=0 suspectscore=0 mlxlogscore=999
 lowpriorityscore=0 malwarescore=0 impostorscore=0 mlxscore=0 bulkscore=0
 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207180044
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


-----Original Message-----
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>=20
Sent: Tuesday, July 12, 2022 6:05 PM
To: Viswanath Boma (Temp) (QUIC) <quic_vboma@quicinc.com>
Cc: video.upstream.external <video.upstream.external@qti.qualcomm.com>; sta=
nimir.varbanov@linaro.org; Andy Gross <agross@kernel.org>; bjorn.andersson@=
linaro.org; Mauro Carvalho Chehab <mchehab@kernel.org>; linux-media@vger.ke=
rnel.org; linux-arm-msm@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] venus : Add default values for the control V4L2_CI=
D_COLORIMETRY_HDR10_MASTERING_DISPLAY

WARNING: This email originated from outside of Qualcomm. Please be wary of =
any links or attachments, and do not enable macros.

On Tue, Jul 12, 2022 at 05:53:41PM +0530, Viswanath Boma wrote:
> From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>
>  V4l2 encoder compliance expecting default values of colormetry for the c=
ontrol.
>
> Change-Id: I1db0d4940b54e033d646ce39d60dc488afba8d58

What does this represent here? I'm pretty sure it is meaningless to the ups=
tream kernel, so please get rid of it.
[vboma]
Will ensure with next patch set

> Signed-off-by: Viswanath Boma <quic_vboma@quicinc.com>

Since Stan is the original author of this and following patches, there shou=
ld be a s-o-b tag from him. After that you should add yours indicating that=
 you are carrying the patches from Stan.

Also, please add a cover letter stating the purpose of this series, how it =
is tested, and with any other relevant information.

Thanks,
Mani
[vboma]
Will ensure with next patch set
> ---
>  drivers/media/platform/qcom/venus/venc_ctrls.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/venus/venc_ctrls.c=20
> b/drivers/media/platform/qcom/venus/venc_ctrls.c
> index ea5805e71c143..37ba7d97f99b2 100644
> --- a/drivers/media/platform/qcom/venus/venc_ctrls.c
> +++ b/drivers/media/platform/qcom/venus/venc_ctrls.c
> @@ -352,6 +352,8 @@ static const struct v4l2_ctrl_ops venc_ctrl_ops =3D=20
> {  int venc_ctrl_init(struct venus_inst *inst)  {
>       int ret;
> +     struct v4l2_ctrl_hdr10_mastering_display p_hdr10_mastering =3D { {3=
4000, 13250, 7500 },
> +     { 16000, 34500, 3000 }, 15635,  16450, 10000000, 500 };
>
>       ret =3D v4l2_ctrl_handler_init(&inst->ctrl_handler, 58);
>       if (ret)
> @@ -580,7 +582,7 @@ int venc_ctrl_init(struct venus_inst *inst)
>
>       v4l2_ctrl_new_std_compound(&inst->ctrl_handler, &venc_ctrl_ops,
>                                  V4L2_CID_COLORIMETRY_HDR10_MASTERING_DIS=
PLAY,
> -                                v4l2_ctrl_ptr_create(NULL));
> +                                v4l2_ctrl_ptr_create((void=20
> + *)&p_hdr10_mastering));
>
>       v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops,
>                         V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD, 0,
> --
> 2.17.1
>