Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <80b413d1-287a-61a3-656d-9ea680f00a90@suse.com>
Date:   Mon, 18 Jul 2022 13:39:31 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT
 without MTRR
Content-Language: en-US
To:     Chuck Zmudzinski <brchuckz@netscape.net>
Cc:     Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Juergen Gross <jgross@suse.com>,
        xen-devel@lists.xenproject.org,
        Thorsten Leemhuis <regressions@leemhuis.info>,
        linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>
References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com>
 <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com>
 <5ea45b0d-32b5-1a13-de86-9988144c0dbe@leemhuis.info>
 <56a6ab5f-06fb-fa11-5966-cb23cb276fa6@netscape.net>
 <d3555a74-d0cb-ca73-eb2e-082f882b5c81@suse.com>
 <1309c3f5-86c7-e4f8-9f35-e0d430951d49@netscape.net>
 <764ea65f-269a-6f32-c780-cbdd7cf09120@suse.com>
 <8eb62e12-17cf-cce6-666a-8ebb7915f461@netscape.net>
From:   Jan Beulich <jbeulich@suse.com>
In-Reply-To: <8eb62e12-17cf-cce6-666a-8ebb7915f461@netscape.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnJFVTVNTHVHWTUyOCtPL2JvdkNCdGhNRHJDR25nbTNSOUdVZURkOVozM1Ji?=
 =?utf-8?B?NUlGNEphRkFRRFB6SG9FeHBIMW5iVmpRM20zRFNob01ONDFiSHpsY3BRRDJC?=
 =?utf-8?B?di9DY3Z0NVp2U0x5TUhoVWdqMHNFaWRLeWJKU2dEZmx0QXBxVks3MHlRRnJ0?=
 =?utf-8?B?TTJyTmVDa1NhbTFaME93a3BINjQ1aUdYMEtDcUx4TzQ0Q1E3RWRMN1FNSEk4?=
 =?utf-8?B?eVgrbWZiVlF5MjdqQzlWamFTRE41MWlOWDZpekhCKy9KdGltLzVXMFMxNisw?=
 =?utf-8?B?ZDJ3bkxQaW5lWE9RSGJaaE1wdTh1ZVR5UVQ0UEdyb2txNEdwOTlHcTc0Q0lK?=
 =?utf-8?B?eTVCVjZld2N6SlZqdmh6RGJNRUV1N29GcWdTQzR6VlZNUktQNjRaUmVuZklG?=
 =?utf-8?B?dHkzWlNEYVVQNk9jOUFEeDZYOVNOcFBSVjVqNk1MZDEyL3VoTHNRMWRuK0NK?=
 =?utf-8?B?WjBKNm41RlRFck5pUlJ5T05HNHR6WG5tUy81MytRaWxqbVBuNFRPMFFWY3pQ?=
 =?utf-8?B?Rm5YNit1RVFtbTRjSk5aRy9QRzRoSXllVEtmOW1aSGlKbFZSdGlpK29TUkR0?=
 =?utf-8?B?VjhBT0lLb1JJMVQzS0JxUmhyNjRpblJyVE9ZV0NPRVpXY0hiYlNQb2FSK2lW?=
 =?utf-8?B?a1IxV0FER0VKa0RIL3ptcGFlWDJKRHpYWHdkYmtlR3U2UVpZU2Jia1hrZVRW?=
 =?utf-8?B?UXFvM0hTcTVzUmgrUDhlU1NGSzJjWlgvWXltMGxRTERFS3pPZXpjVHQxWUFU?=
 =?utf-8?B?SHpNN0g4Y3JNL0NuQ3pIZFVQM3dKVnZ2emt3d2lLVmZvVmZ3OWFBQzZVWWU1?=
 =?utf-8?B?b3FFZTZ3MGhDMFg1WmgxQnlwV2gvdWx6eGtzQzBjZ3FuSDE1ZXYvQVI2V2hU?=
 =?utf-8?B?TzUrQTF2ZDVRdjBDM0kyQjBQU2dXaS9zTzJWaHR1Zm9TRVBhYUNIT3Z4Rmlx?=
 =?utf-8?B?SlJ1S09vSEF4V0xsQ2tEczB2MGJKZHVSZmtKSThwR1IxakRWTWdSTUdicVlC?=
 =?utf-8?B?OW8xek10bVVaNGE1ZDJ3Yk5iSWFBL1VPUEtpYWVKT25hMnpCR3lROEwyeHlw?=
 =?utf-8?B?cGVYWlJFb2xVZEdmcGZaeVlJcW85NGJKWXBNaTAzTEVJWHRSVXZxWGxOeHls?=
 =?utf-8?B?ZVVodEdmRk0yL2dDbHFTZGJSNTE5bVVqN25obllLTnBQOTZ6M2VnbmJlNVVp?=
 =?utf-8?B?VnEzUnRURTlnOSs4ckpzbnoyNzk5UkhZcHFQbElZNW5vcURCT2F3eFZiQk10?=
 =?utf-8?B?RWxJYytub2lZdmQ4RVlIMFcrY3NIZllzUmlJZ3IwZXZiZlJ4RTd4YVZZbWo3?=
 =?utf-8?B?K1pDL2RpRW84QU9JR0xqa3RpWnp0VEdIM2YwOTJBU085V0VKZ1Y3YjFqN0g5?=
 =?utf-8?B?Wk9EV2p1SUpLUnN1ZzJQVWphTDFjTDltMkZqK2FnekpNYkFDSzlUK2R6ZkVY?=
 =?utf-8?B?MWpDVWpoRHMvalJDUWVHYVlycmlDV3BhK0Q5bXptdlFHUTh4OHRaVXJQaXR3?=
 =?utf-8?B?YU9FUVd3ZFdScXhvWW9GZnlmRVM2bnptTXd2UHU3a2tOT3d3bW9FWTJqOFVv?=
 =?utf-8?B?Q1dva1ROQ1pPSzlNRFdFYXZVTjUxQm5KTklDMlZSOEFiL1JHaGY1RDNFSTVD?=
 =?utf-8?B?d3QyaGowRDJBWGpjcUxqa0ZpQUlyQy95VHdVaE5ldG5mK3VYOVRCbVpLZFlq?=
 =?utf-8?B?MVhENHJTWmZNcGVocG0wZGZMNDFhNnpEbFN5U2tpbmk5Tm9sbFM0QVUyYzdZ?=
 =?utf-8?B?dWVTelB6ZnpxTnFPSWd4eXh0TDRhbklyYkVkYTVEbWQ4YXJISXNlNkxpOGRs?=
 =?utf-8?B?SXpYVlE4OUFUc2l4M2ZDMGZSZmhRVHFpVTR3SmxlcFBNV1g5aFhlNytucDcv?=
 =?utf-8?B?ZE9pa25HNld2UFdkMGJRbDBQaHV4Q0JJM2dSUDd0N0htWGpHeVJoTWE0alB1?=
 =?utf-8?B?SDU4d0pLY3Q1L1hHYzNXUXZRT2tROENNbmJTWDNVWDJ2TDdEMC9QZCthZmM1?=
 =?utf-8?B?MjFLMFQwM0pKUDFxVVlmL1ZoZUtZTVhOYmNiRzJiK25FMmgyTzVMbm01RzJl?=
 =?utf-8?B?MkMwTERtR3grd2dtWi9EeDEvaWpPWUxyeXIySHBsekRPc3NwQXZYV1VRaTM2?=
 =?utf-8?Q?AyDM4F5P6V5WJgICtMYz3ag1s?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3566ad0c-d80d-4cf1-bbfe-08da68b22f73
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 11:39:33.7177
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tDbxqZ0XJwBlMRvNfqi87k5mzOpTYjZsV6nqX6ZUypy+SGxxBMp1W+6wx6KBP+JJdIRCR2u8+Jo3aOmN5eCalw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3528
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 18.07.2022 13:31, Chuck Zmudzinski wrote:
> On 7/18/2022 2:07 AM, Jan Beulich wrote:
>> On 15.07.2022 21:53, Chuck Zmudzinski wrote:
>>> Two things I see here in my efforts to get a patch to fix this regression:
>>>
>>> 1. Does Xen have plans to give Linux running in Dom0 write-access to the
>>> PAT MSR?
>>
>> No, as this is not technically feasible (all physical CPUs should run
>> with the same value in the MSR, or else other issues arise).
>>
>>> 2. Does Xen have plans to expose MTRRs to Linux running in Dom0?
>>
>> Yen does expose MTRRs to PV Dom0, but via a hypercall mechanism. I
>> don't think there are plans on the Xen side to support the MSR
>> interface (and hence to expose the CPUID bit), and iirc there are
>> no plans on the Linux side to use the MTRR interface. This also
>> wouldn't really make sense anymore now that it has become quite
>> clear that Linux wants to have PAT working without depending on
>> MTRR.
> 
> I am not so sure about that, given what Borislav Petkov
> said when commenting on your patch here:
> 
> https://lore.kernel.org/lkml/YsRjX%2FU1XN8rq+8u@zn.tnic/
> 
> Specifically, Borislav Petkov wrote on Tue, 5 Jul 2022 18:14:23 +0200:
> 
> Actually, the current goal is to adjust Xen dom0 because:
> 
> 1. it uses the PAT code
> 
> 2. but then it does something special and hides the MTRRs
> 
> which is not something real hardware does.
> 
> So this one-off thing should be prominent, visible and not get in the
> way.
> 
> --------------end of Borislav Petkov quote-----------

And then, a day later, he said

"So I'm being told that it would be generally beneficial for all kinds of
 virtualization solutions to be able to support PAT only, without MTRRs
 so it would be interesting to see how ugly it would become to decouple
 PAT from MTRRs in Linux..."

> Jan, can you explain this comment by Borislav Petkov about
> Xen being a "one-off thing" that hides MTRRs and needs
> to be "adjusted" so it does "not get in the way"?

I'm afraid this isn't the first time that you ask people to explain
what somebody else said. I don't follow why you think I could better
explain what Boris said and why than he could do himself.

Jan