Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Jul 2022 14:39:15 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Tong Zhang <ztong0001@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Colin Ian King <colin.king@intel.com>,
        Saurav Girepunje <saurav.girepunje@gmail.com>,
        Johan Hovold <johan@kernel.org>, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev, Zheyu Ma <zheyuma97@gmail.com>
Subject: Re: [PATCH] staging: rtl8192u: fix rmmod warn when wlan0 is renamed
Message-ID: <20220718113915.GB2338@kadam>
References: <CAMhUBjmX0BDh-35GQxf3-fXFa8_EKfh2fwYKZDgH4NzGGQHiSg@mail.gmail.com>
 <20220717070204.705878-1-ztong0001@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220717070204.705878-1-ztong0001@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aPJtmdvJXv/vS8qs5mFfBnmAYzuZq5zanaaKTetnbQinXNOt6NGCiX0vdREz?=
 =?us-ascii?Q?wDjbDppqddf6ZFJWVvdQFdqPeJPFfzSyY1d9BnZrJmKvEaPBnj7yFc4TIpuz?=
 =?us-ascii?Q?tO58BXBQRy1zXLJlqattVMZJsAV5MYSAq4EGi0e76Rov4i97npDo+iODI2oF?=
 =?us-ascii?Q?EkUgULDkxFsDqP7/kYBoru4MuA727tkU4VYKCdsDp9lM/Gcu8eZI89IPHC3k?=
 =?us-ascii?Q?rRUj0fIanroMNBLcaNdndFvKz+Og/z/8CJt/mIMgMTUYgwO/98kzcU+xthiO?=
 =?us-ascii?Q?6FSlCsUPkw5/zJVO1IZ+b7O3HocNuWijrrCXq1SNQtYgp8tG8w/q+a4rkY3m?=
 =?us-ascii?Q?EvOSYAjoVWpcYXEucv1gZKOUqzbizyXXkxDuLP0nTRi+VH4R4mkkn+pThoPN?=
 =?us-ascii?Q?URwVgW8BGoPzNJ8yL9Aci/as0itdsEK4gf8DxKdBR9q48BRrL2WIX3HRAt7q?=
 =?us-ascii?Q?kS4ByiFtEPlqnDdGnuW+wRK05rJ0mB3j2ytFOjSo83RQvU3ahVsUDC6H47Iv?=
 =?us-ascii?Q?+n3IX7gFIoiua7+UpUbP3eY9QQICGTQXa5cqz30hnh738SZuOr8gcrJhYau8?=
 =?us-ascii?Q?rHDq6ldzCsqx/ZIg06Vtx7xAMwNcbPQGh1HyXysGaNgyWAF6j2qodFBR52pV?=
 =?us-ascii?Q?7eRknE9ld4HDSOcIeJgSdFU6sq4RfDYhV9G8/EehnlevEScROcuqXQu8VTY8?=
 =?us-ascii?Q?kEFEDj75I35nLOFMksRx9B+Wk3icgh/3YVw+TP7uNy1VnPsBBajoOld21SKA?=
 =?us-ascii?Q?plCvWpCvfl37QuRN8daiXDBcZp7dBrBT5UweMGNcGhG55/s8AJyl8a8CsaaY?=
 =?us-ascii?Q?BW3ALFC1uBdFN3mTh+BNBWjqQxHbvUXGdDdO92/D0mc55PUv1307s3+qITod?=
 =?us-ascii?Q?SFjQTZv4tYa3+qukzuLPpMso7azsENfalpxqwMmjziKVfIf8KQosQAeQx4Nz?=
 =?us-ascii?Q?rHZgWjltjq2pHQ+wtVUaMImcZ5t26xlniksRLQNRa2IhatXycC5HNsVt6DAf?=
 =?us-ascii?Q?Auk7uKaJ0oMGiYd/uiAC9uELzz9ugJvTzD2KwR79feVH8qlNHXEsRxQ1rrrO?=
 =?us-ascii?Q?G70swbSNDYVxzIHiYRzL7/Meblb3WMtBNR0jIa4CsGvI1htiE9Ji5vHxNfy2?=
 =?us-ascii?Q?PQdLEs4h+VWprx/dud4lAB9PPFVKubWwW+R0dx8k3o0Qtpe3pfjJ6FUFbNe1?=
 =?us-ascii?Q?pxJA2kRf+3OlDqazIVTYxf1qjprixDfIJTo+ifASMgl17u1WSIpbbIJguppN?=
 =?us-ascii?Q?6NkYORYDeDZukGrBdStrQAt8iOymJJpAkaP/veKGe3PEfvExc/IOZ7q31AdR?=
 =?us-ascii?Q?z1UMV7geAeL4CCd12btpPTXwjZPmXLJ2QoZjg43uGeepTUtf3IpkI47ZZ9FG?=
 =?us-ascii?Q?8PqFFiEbLIJhvf+mym1rR08lzmLhkV4TuWQltMVAIew2d8VO5d6FySbdQmzt?=
 =?us-ascii?Q?8wDfpqRNFZGWJIonsw6aKwktn0w12XYngL+8d/U+Z2t9nVoCRfliHvMYoFyf?=
 =?us-ascii?Q?2Zvt8A05xpCEMDora4vzXN1jEZG0QT6lCtTK3J1RkyNebknANXe4xDjmAbyd?=
 =?us-ascii?Q?r+034+KTzaHvtjNB9bx07/Y96wbj0xujlskwmP19Som85G/Xb8Ih6g+5sgj9?=
 =?us-ascii?Q?Bw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0009a3a7-4840-4164-9406-08da68b22b03
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 11:39:26.6155
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T10wwY53w6TOPLRSAm8E7guz8T+lSGEVIUOdQetABLPIRtze80Ek9o/vXbWBarSGpMTJwCQQ7oonTwXF+qxBE40/xiAlW9mb3t7qQsnWRxo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1622
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-18_10,2022-07-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0
 suspectscore=0 mlxlogscore=842 adultscore=0 spamscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207180050
X-Proofpoint-ORIG-GUID: WeTPnxKEs2r5LGozr3Rkv5PC5wPHEXLU
X-Proofpoint-GUID: WeTPnxKEs2r5LGozr3Rkv5PC5wPHEXLU
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jul 17, 2022 at 12:01:57AM -0700, Tong Zhang wrote:
> There are 4 debug files created under /proc/net/[Devname]. Devname could
> be wlan0 initially, however it could be renamed later to e.g. enx00e04c000002.
> This will cause problem during debug file teardown since it uses
> netdev->name which is no longer wlan0. To solve this problem, add a
> notifier to handle device renaming.
> 
> Also, due to this is purely for debuging as files are created read only,
> move this to debugfs like other NIC drivers do instead of using procfs.
> 

You're doing too many things in one patch.  Maybe do it like this:
patch 1: Move the functions (no functional change).
patch 2: Change to debugfs instead of procfs
patch 3: Add the notifier

regards,
dan carpenter