Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Jul 2022 14:47:02 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Tong Zhang <ztong0001@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Colin Ian King <colin.king@intel.com>,
        Saurav Girepunje <saurav.girepunje@gmail.com>,
        Johan Hovold <johan@kernel.org>, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev, Zheyu Ma <zheyuma97@gmail.com>
Subject: Re: [PATCH] staging: rtl8192u: fix rmmod warn when wlan0 is renamed
Message-ID: <20220718114701.GC2338@kadam>
References: <CAMhUBjmX0BDh-35GQxf3-fXFa8_EKfh2fwYKZDgH4NzGGQHiSg@mail.gmail.com>
 <20220717070204.705878-1-ztong0001@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220717070204.705878-1-ztong0001@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2glJ6/EjIqYB0ko83IGAj5j4pjNHtBuXI1UKnurRy8YBDi46Btkfz77KrSWC?=
 =?us-ascii?Q?ieSt5w2jRTFY2VYZqQ+luESC1xGjCGCOyEWVX/ybOEHrNodszlBlhDR1ZbgJ?=
 =?us-ascii?Q?gDEA+kpfH+CTdQFIf+hRAvi7K+52wNHfTB/0+6X4q0T9cbsZ8+mtk4Zo/24d?=
 =?us-ascii?Q?1cbMPU27kbR85X+v+kp8D+/o6Vj3IC9+YJYa+i+TCs/q/DeBpvWApajAJ++3?=
 =?us-ascii?Q?6rMtvlLbPdyFaqpTw+/lJe17/K0k2N/+AXo5qngXjB/rJEU/IjwcfIJoAxBo?=
 =?us-ascii?Q?bK06oTW6jskohmAOQesXx3qEgCWwdi7/1SYKxA55yPHrMn8ODbB/Bifw95ao?=
 =?us-ascii?Q?On7Jc71MINjT+iWniIGg2hOBwFFR/5jnONL4dn/eioZF5qPfLKec26IhgXEu?=
 =?us-ascii?Q?PHAtmvYkcFKb4gLTVFOPWu2MpH/detZ33jGB39FRaKhbce5L1qXtRzix+SXE?=
 =?us-ascii?Q?1ga6BiBwFMFRfQsTkVTw8ynvNkPFQDM8I/iL+2FrzvIAUezWe3lGje6Yp4Hl?=
 =?us-ascii?Q?GcQX1hQXy8B58CFMLed7KOUkkO9hzEwJ+eHABO2087zlqaXOvi9iHhcVYDRC?=
 =?us-ascii?Q?fdp/xVT/v7NWkq3ThRkvBCXuc9+Pa5W0g2911Rosl6mMCyI3au08bGe3FEK/?=
 =?us-ascii?Q?CyF242YSojMbBwa67vRFjTQ/VkcmOjY1toz0zMOQDHVPZ0/NVu6qpSdnfZ38?=
 =?us-ascii?Q?WMASJz673wfexppE37WlxX/hEBYLN83Oqz3Aw8YuK0Xx3dn7KUI+qlSe7wWO?=
 =?us-ascii?Q?qZwn/Qi7sppNFckcpMjfPqy7wCIemUFMynhDu8iAGCwQIwR8c4Ic+oFAT39n?=
 =?us-ascii?Q?QUBnQ61epOe9KjqCDlH8QsHJzm0HXunRhCB9Ztpi3B6rZnEYN+SRi+jUR/NM?=
 =?us-ascii?Q?JdIztHegB7b5rsBJOp+wmSdNCYSEu0Nbzy6GUR/WczYtTj1J2/yqaDtMZWYH?=
 =?us-ascii?Q?bRcpDbQgaLmotqNLcgJoQMYiYN+1lTeXqt2VIq0hdOPxbN50bMtFGzYhOwoh?=
 =?us-ascii?Q?kote+l3njD4IEorTL1Iqvg7qr3xXdodfwdtLBaRQibYkJhGoR8Ltu0p+teaw?=
 =?us-ascii?Q?RyjmT+763ai/poLZXZZvWV7QRedTeM7Cb5QX3JGmCh+lOiYw0Ax3vfahq074?=
 =?us-ascii?Q?2WMIjhwM+AAnCHrCWeXbKgP0LqhQtMXPKUAkvOZyqdSOOCMcSM+r2FNCYGSQ?=
 =?us-ascii?Q?aR1oTbj63IUboZ7M3wYkU/QXiWYphkHxBEDZZDXguXQ+AzjWfOIbt0a9pP0u?=
 =?us-ascii?Q?ZpSZLd9ByhMXtRvVo4vB7EH5lvUVNkzVGq3Z/W6Xugs9MDyytY/hAWI4BPPR?=
 =?us-ascii?Q?fDPjskCFc4OsYphQ/2wvIp21afjkq5wvvU1uyLeuHHD3sUxR1/Q53U2CBXam?=
 =?us-ascii?Q?A8LTsNc6jk/Q+uniOtqnsMWpBPlgWboARJqRURsABK+lVFq3BoZm3B/GFAsK?=
 =?us-ascii?Q?sUuDeOyELFzzmBWLA3zhIjEkl0Y7sRw/dpdlxv1hdFbFAVj9gYs2usHpRlsX?=
 =?us-ascii?Q?TM5LIaRaU4zf82miqOCoYGE0PllgyypPjOFJVEwYEvlMvc8NQVXkxXzXDpxP?=
 =?us-ascii?Q?GICvR7lZM7hV658zonJrw/eothq0R6JxBhnI1z3AtsUlk2H8tj7BQIC8/ttu?=
 =?us-ascii?Q?Zw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a6bfe32-ae8b-4d86-7982-08da68b34704
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 11:47:23.1881
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6VUfZN1eNp38NtRFccgobqGTU/k+b6pa41zTFNoBU8zxFvyZbxvRYTN9OZwJZ4F0ACJvl9U+N1EqkASpc+28mLjNSRrMkhLZLWlUfyfyYXo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4909
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-18_10,2022-07-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 phishscore=0
 mlxlogscore=999 spamscore=0 malwarescore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207180050
X-Proofpoint-GUID: fFntxaqZ4Ud7FnZUe3iUH9_2lhzuN0_u
X-Proofpoint-ORIG-GUID: fFntxaqZ4Ud7FnZUe3iUH9_2lhzuN0_u
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jul 17, 2022 at 12:01:57AM -0700, Tong Zhang wrote:
> -static int __maybe_unused proc_get_stats_rx(struct seq_file *m, void *v)
> -{
> -	struct net_device *dev = m->private;
> -	struct r8192_priv *priv = (struct r8192_priv *)ieee80211_priv(dev);
> -
> -	seq_printf(m,
> -		   "RX packets: %lu\n"
> -		   "RX urb status error: %lu\n"
> -		   "RX invalid urb error: %lu\n",
> -		   priv->stats.rxoktotal,
> -		   priv->stats.rxstaterr,
> -		   priv->stats.rxurberr);
> -
> -	return 0;
> -}

> +static int rtl8192_usb_stats_rx_show(struct seq_file *m, void *v)
> +{
> +	struct net_device *dev = m->private;
> +	struct r8192_priv *priv = (struct r8192_priv *)ieee80211_priv(dev);
> +
> +	seq_printf(m,
> +			"RX packets: %lu\n"
> +			"RX urb status error: %lu\n"
> +			"RX invalid urb error: %lu\n",
> +			priv->stats.rxoktotal,
> +			priv->stats.rxstaterr,
> +			priv->stats.rxurberr);
> +
> +	return 0;
> +}

When you're moving function around, then try to avoid changing the white
space at all.  It just makes it more complicated to review.  But
especially in this case, the white space was correct-ish in the original
and now it is bad.

regards,
dan carpenter