Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Jul 2022 15:01:49 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Tong Zhang <ztong0001@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Colin Ian King <colin.king@intel.com>,
        Saurav Girepunje <saurav.girepunje@gmail.com>,
        Johan Hovold <johan@kernel.org>, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev, Zheyu Ma <zheyuma97@gmail.com>
Subject: Re: [PATCH] staging: rtl8192u: fix rmmod warn when wlan0 is renamed
Message-ID: <20220718120149.GD2338@kadam>
References: <CAMhUBjmX0BDh-35GQxf3-fXFa8_EKfh2fwYKZDgH4NzGGQHiSg@mail.gmail.com>
 <20220717070204.705878-1-ztong0001@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220717070204.705878-1-ztong0001@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?d4ip/f+lrKcWvPzy3LIoF6MvAecrvjbdXkClDq287Qaw/xyWz5O0CEGK75fm?=
 =?us-ascii?Q?OlASYpLUOyycbrXGYxbCzjIkbBO1h6lqChw7oAcWbLL+mHgsOmb/Gg8W0I2h?=
 =?us-ascii?Q?UrfEgqaZ+xcGPdCjg1Ve2hXbvYPZQQor9HmkaFepn+dQ0hM8pPuMGnKZigAN?=
 =?us-ascii?Q?kr86cRwp2RLvQR2V6qVVmagDpPVAUUNUvB/yhgvchu0JVFNXku1oI2EFsutR?=
 =?us-ascii?Q?bWSQqjyOU1mu0XAuea0LT59EqXFqqgfJD/CYLgIE/UW7Wdmn6JA/PDXzq+GU?=
 =?us-ascii?Q?5z/GkmYbMit2EsdETHnnBANEIIQ+ow4ynUJbpRKVubNx2a0Ft3HkUUha7mQH?=
 =?us-ascii?Q?63rlusyICiCf9zJ0H710aclrroJI4NFuLsr6L/fbbcfK/j76/MR00M0uDR+6?=
 =?us-ascii?Q?S7ahBGHhAcS/lLLDecth+EyxVxgiJx7z9cnkc5pP02jNSKsjtZtJmne0qijV?=
 =?us-ascii?Q?Z614n0DamKcuiIGfcHF1xECL82asamI8k8XblLi3B5qvhJfIKMC5NDYQ7359?=
 =?us-ascii?Q?eGk0lU1JA5FmjicbmDskd1f0bR8ZvoMFybf6GG4IZXiiMbWSoD/29DYumKvP?=
 =?us-ascii?Q?cGA3wpK3H9EB8gRK5VaMXkyRlUY4dun+IBqf3Id2MoI9YOQ5sA/9cX655hvH?=
 =?us-ascii?Q?ijKbkingg5IigGRYfk2lsrapy+D9/KjpuZTMY30O5T9oL23Y7gJs+rLk0ABC?=
 =?us-ascii?Q?GnIE3g9WMF0cmJVFpq7xOkIa9AC8surZiQ6jzyZ1gadE99pOMgdHvPqYgYCz?=
 =?us-ascii?Q?dVcpexzBRDMiL+zkitDRyKwQIAkThNw/e8GQEh+4yTh3wubxThDUfKU5idvE?=
 =?us-ascii?Q?5RGZ0cqTBN2Ed6wG/o+BhVNuc3El1Bme6DiJfWU9y78lHMhSHBs78NfEFBJk?=
 =?us-ascii?Q?PiKtKlu5rv7g2sAOWTUvdbuoXFsSCf9wzovrR/1HJ47vviTtREF9WsHz2nnC?=
 =?us-ascii?Q?GS628S+UoCaI6PgRUWg1w+WZl7ttYy6S2Dzyq/lyrmzvPJ5z2L42q8nv7sh3?=
 =?us-ascii?Q?3/3brwfNhFXPxf7URNgH/uvLglMiaVHlHB4mGRbONPiC896FYSsBLrBTuk3B?=
 =?us-ascii?Q?Mg+iDqQi1uI2KiT2axh3+VPjNk80SEjFwrGYV7wmNhRi1dfPz4j+Q35OK2tn?=
 =?us-ascii?Q?hZy8slcZSki0W/hXmPFudozYejrmld+yARBjpYcD3apzZSlWvW3RSG8RNXWX?=
 =?us-ascii?Q?kTKn11f2IFb9y991aiFX4bL4m+oPTWzfpyZkvJWYdhiDgijhgz0L/o+gPZit?=
 =?us-ascii?Q?sB9GRoCePDCBRPdsHWizRJ7MtluqM+re+5RZhgRoSyjKCWKZge2F2dHpGc+4?=
 =?us-ascii?Q?apYCjiaJpAuleigbNRhv4O1ZmVYxE6w2wgLbJBvYPLeb6PKMKf49utLbhrGU?=
 =?us-ascii?Q?fkzB9w9tJMDnjfsPji2AYBM0Ej7ST4F5hwicmyG4FaBj+LbVdrZiIAz4aeCY?=
 =?us-ascii?Q?37WwwdB5xNnN4NQ8yWz4+y5BtqoV06tC59Cg8BoNeauzscVTWH4Vlbp1MfvD?=
 =?us-ascii?Q?aPw5wcgMGHMCO3wsUAV/RrWalTVQ4gT4Flgub9x0pKogFE2cj/u0t+pizf//?=
 =?us-ascii?Q?pKYiBdyIrR5ny9O1TVjNKijMsFdKx9wrf4VV56l8R4un4F4JGxdMypS37uC2?=
 =?us-ascii?Q?5Q=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69011e93-321c-4007-cf6a-08da68b55233
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 12:02:00.7592
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0OUT715XhofBM3pqt8qurq66+umJIgRV1aydIl+MdhFtqHdVCE4ACR3WtAAmWaXcBa/MjJ/X6xykxuzcgmBBPC9zutHP4TO8PVYhnVxy7iw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3387
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-18_10,2022-07-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 phishscore=0 mlxlogscore=881 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207180052
X-Proofpoint-ORIG-GUID: 8oghklJucchcuWI32xKMoMHsgvHrCmKS
X-Proofpoint-GUID: 8oghklJucchcuWI32xKMoMHsgvHrCmKS
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jul 17, 2022 at 12:01:57AM -0700, Tong Zhang wrote:
> +static int rtl8192_usb_netdev_event(struct notifier_block *nb, unsigned long event,
> +		void *data)
> +{
> +	struct net_device *netdev = netdev_notifier_info_to_dev(data);
> +
> +	if (netdev->netdev_ops != &rtl8192_netdev_ops)
> +		goto out;
> +
> +	switch (event) {
> +		case NETDEV_CHANGENAME:
> +			rtl8192_debugfs_rename(netdev);
> +			break;
> +
> +		default:
> +			break;
> +	}

This isn't indented properly.  Don't forget to run ./scripts/checkpatch.pl
on your patch.

> +
> +out:
> +	return NOTIFY_DONE;
> +}
> +
> +static struct notifier_block rtl8192_usb_netdev_notifier = {
> +	.notifier_call = rtl8192_usb_netdev_event,
> +};
> +
> +

Here too.

>  static int __init rtl8192_usb_module_init(void)
>  {
>  	int ret;
> @@ -4788,10 +4638,14 @@ static int __init rtl8192_usb_module_init(void)

[ snip ]

> +void rtl8192_debugfs_init(struct net_device *dev)
> +{
> +	struct dentry *dir;
> +	struct r8192_priv *priv = (struct r8192_priv *)ieee80211_priv(dev);
> +
> +	dir = debugfs_create_dir(dev->name, NULL);
> +	if (IS_ERR_OR_NULL(dir))
> +		return;

In olden times the debugfs_create_dir() function used to return a mix
of error pointers and NULL.  But the idea with that function is that
most people are not supposed to check for errors.  But instead of that
they added all kind of *buggy* checks.  So then we made it just return
error pointers.

This code *does* care about it because it uses the
priv->debugfs_dir->d_name.name in rtl8192_debugfs_rename().

But caring about the debugfs dir and creating a rtl8192_debugfs_rename()
function is really unusual.  And normally when we have to do something
unusual that means we are doing something wrong...  :/

Anyway, just check for if (IS_ERR(dir)) {

> +
> +	debugfs_create_file("stats-rx", 0444, dir, dev, &rtl8192_usb_stats_rx_fops);
> +	debugfs_create_file("stats-tx", 0444, dir, dev, &rtl8192_usb_stats_tx_fops);
> +	debugfs_create_file("stats-ap", 0444, dir, dev, &rtl8192_usb_stats_ap_fops);
> +	debugfs_create_file("registers", 0444, dir, dev, &rtl8192_usb_registers_fops);
> +
> +	priv->debugfs_dir = dir;
> +}
> +
> +void rtl8192_debugfs_exit(struct net_device *dev)
> +{
> +	struct r8192_priv *priv = (struct r8192_priv *)ieee80211_priv(dev);
> +	if (!priv->debugfs_dir)
> +		return;
> +	debugfs_remove_recursive(priv->debugfs_dir);
> +	priv->debugfs_dir = NULL;
> +}
> +
> +void rtl8192_debugfs_rename(struct net_device *dev)
> +{
> +	struct r8192_priv *priv = (struct r8192_priv *)ieee80211_priv(dev);
> +
> +	if (!priv->debugfs_dir)
> +		return;
> +
> +	if (!strcmp(priv->debugfs_dir->d_name.name, dev->name))
> +		return;
> +
> +	debugfs_rename(priv->debugfs_dir->d_parent, priv->debugfs_dir,
> +			priv->debugfs_dir->d_parent, dev->name);
> +}
> +

regards,
dan carpenter