Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3302784imw; Mon, 18 Jul 2022 05:54:47 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uejT6yewK822KA2GGE1UqrUvGMfVDgcIFdXSFEVTOXU8EIceptJzGn1a9QN2zkg0KDo24R X-Received: by 2002:a05:6808:1885:b0:33a:74ac:8b79 with SMTP id bi5-20020a056808188500b0033a74ac8b79mr2585163oib.237.1658148887011; Mon, 18 Jul 2022 05:54:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658148887; cv=none; d=google.com; s=arc-20160816; b=Dz8kca9GOFwhRwPZ25SdvUVjfQxuNNVeyiuL5I7051XaCsnuGcGiPpINj24pBdrv8V KoruwkjTZRB1M1FNP6kHVuD84r3GCGljcUpDPS3O1N9zDh/wx16xuiyMplAHSdd6O4z6 GrvdKvyoslCLBQ+k7VD/lJn0fep8jt7Ti4/pfhYMAN7MGMJ57iw7EsGTcfMdoN3Y0czs NhqI+3GNv6NK0YViIiEp7kNnDUoFp580jCDeHMsmOZ9eMQwRAFvx6Z5nh2Xd0x0TQQ9q uscoa+XI31J8xIJTQNz2y950otPShT7h+6BjdBtDnnhPPrQD3GyEBh6qogFXLBxTPasz TJog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=YUsHaSIKv5mhVert20B83ArzxD5bMsOqQGQm2WfFNQY=; b=HhdnxjbnaEyFBo3Oq7KarwqpKg/aLSSvSB/JDYJ9YylR8h80zh7nM77rovch5qZlrR LzVuJyVU1mQvpmJUOfvElX83EyfElKmhtxgssOnvGUkHprWhq5Dqp9HTVRP4Pm+kKb6w PD6G0WfupQ7ZaaRtvgPEVJkE1+OxY3RoI5+y7IAgMyPUVRTHb8mDw+SIfCTXU0XhI6hw 6LNGKIZpLrRAXYog65kuefQEYhvnkho9KE6E2Ug98Q+sk/dw1OeiBfQ+X0u5ZBgWb5Cv hJ4ZyAKioM78oJ87/xpkjU+Y7cHc2AwSK5hkRUvKbNUUtzcRAbu5ih7vgCEFS9u+4HOq zYqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Ga6lTw52; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 5-20020aca0b05000000b0033a7968c394si2311810oil.224.2022.07.18.05.54.34; Mon, 18 Jul 2022 05:54:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Ga6lTw52; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235032AbiGRMUq (ORCPT + 99 others); Mon, 18 Jul 2022 08:20:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234365AbiGRMUn (ORCPT ); Mon, 18 Jul 2022 08:20:43 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61B4511A3A; Mon, 18 Jul 2022 05:20:41 -0700 (PDT) Received: from zn.tnic (p200300ea972976d7329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9729:76d7:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id EC8681EC04F0; Mon, 18 Jul 2022 14:20:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1658146836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=YUsHaSIKv5mhVert20B83ArzxD5bMsOqQGQm2WfFNQY=; b=Ga6lTw52ypWNCa7ANAt/KfjkmVyY188H+6CK9mutryTo0MlTHD49tBVIAgvT3rAxlb5hBH x//kdGxXjpUKs4jyHamB06xu9+kdpmUNNZGYHG5m8FEI0HMZ9vzqjGmulqnxN1BfUIp9QQ dKivWsgLjUwBv94Pm38Ha6t5kSXbj9s= Date: Mon, 18 Jul 2022 14:20:32 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, brchuckz@netscape.net, jbeulich@suse.com, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , stable@vger.kernel.org Subject: Re: [PATCH 1/3] x86: move some code out of arch/x86/kernel/cpu/mtrr Message-ID: References: <20220715142549.25223-1-jgross@suse.com> <20220715142549.25223-2-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220715142549.25223-2-jgross@suse.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 15, 2022 at 04:25:47PM +0200, Juergen Gross wrote: > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c > index 736262a76a12..e43322f8a4ef 100644 > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c I guess the move's ok but not into cpu/common.c pls. That thing is huuuge and is a dumping ground for everything. arch/x86/kernel/cpu/cacheinfo.c looks like a more viable candidate for all things cache. Rest looks trivial. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette