Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Jul 2022 15:41:37 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc:     Forest Bond <forest@alittletooquiet.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] staging: vt6655: Replace MACvReceive1 with function
 vt6655_mac_dma_ctl
Message-ID: <20220718124136.GE2338@kadam>
References: <cover.1658094708.git.philipp.g.hortmann@gmail.com>
 <c433e54f0fae051fc8ba9050aa094d6f7141e8d4.1658094708.git.philipp.g.hortmann@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c433e54f0fae051fc8ba9050aa094d6f7141e8d4.1658094708.git.philipp.g.hortmann@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bXN6sx9wYJNXIKAbjySnIFxkT5Pdvi6+AVz/dqhrXYAWLIQ32P7IQQ1I4gqn?=
 =?us-ascii?Q?QFn5CzjvJ1mRTyTmcKFBUFqpKDocs4oGnZjnmC5981jNj/m/P4877WOvvC4W?=
 =?us-ascii?Q?3QgiYFJRaRlxmkqQlsZKPQ8qp/LJaxOzJRymyT1prqDTaihy5kKIxJDjN0kC?=
 =?us-ascii?Q?h9wV9ROFD7uWZBKVWyp1FhN0bvip/IV6glLaxnf6Pi4Su5orYgKo4eoYjynb?=
 =?us-ascii?Q?OR+xok1iqU40bOccBDDHFKC2aljFgq/f+QVGll/pivlmNQBzKFiV5mXoW+JV?=
 =?us-ascii?Q?YXu94CT6fLSDx/nCDAbtBvKCaFI1QRuyfomo8f9h+3inHqBPS+8mx6XqMiAK?=
 =?us-ascii?Q?4HHUywZ3JZ8xbDJFGtK28vA1TanUWtysprMzNUrolmFqv7P7exIScQX/fUQp?=
 =?us-ascii?Q?qwSq+yjz68Bcd348WkmRv1pC/sJkWzEL9K3ESZQ979SzUVgCDtekDm/WH/Kb?=
 =?us-ascii?Q?s4SrEG7nLDgunJMpIwxKCiHXILKxoQb2g4eDt5XW2t80xWGlKBjfWFKwDHGb?=
 =?us-ascii?Q?y0Uzbg4AfjkqmqA3K3/wbvwRiHVMtEBVqI7L9il90m4vUeqo51A84GGBGZK8?=
 =?us-ascii?Q?nupM35mixEcNYzvwOzEEf/fobjupeyzq5AeaEYJd2GBjKOm34KI0rUVrQkXE?=
 =?us-ascii?Q?GvfAz4dojqIHzcKp/uYxWxLp7yTofBxGtCfoZQkuKEE6Z5ue2ut1j93vIUxu?=
 =?us-ascii?Q?mchxmssWYtPC12YJIMFy3vjIpeldtBqUVj01Miy1ykonQfTYYp15NPt+djjj?=
 =?us-ascii?Q?sMtM3OM/OCIdO6n9iY2nxmcFlDGGswYw9bBvOSK1AVnQGIL1Vv40kqyup0On?=
 =?us-ascii?Q?giDezaMzQx3Z+CtEOCQ5+CQFuTghjVKprheGZX76s4TSQZt1KwpzWGeaxyNC?=
 =?us-ascii?Q?gGXRkX/ugIRjW8KzX9V8HhlwPMGEEXCzjlmhLa0CLT7A1MK9hsjJqyf9lrb5?=
 =?us-ascii?Q?AysVBqJGQnk84jdYM+koA8wVi+JqzQbqr2Vu7HsQNnSWMAT/EXr9uY+DheNx?=
 =?us-ascii?Q?Kxj6mZtYP7BzyUzCWOBosjwymiHvc/Wyz4eJEZPxEqcAB927fPIpRwJiM+3M?=
 =?us-ascii?Q?4fLSdJKwt8YS0DY1tZR8Bs+3kO2iddzzvaQXreCIRK2HQNavgjeWOkNRt08h?=
 =?us-ascii?Q?PV5vZqb3LXGaF4nfkaWYkb7A+5iucPTPrjmze5M0dUmXIfgnC0t7THTj8jmF?=
 =?us-ascii?Q?2/CaD65R7vQvqfmjDWQFWHjjj313y6ohmbErjENJzw1XLz0QvhA4UEnPtKbQ?=
 =?us-ascii?Q?lpKVAsLlamASEQlL/mG4Ct7vmEtDnI1pr4N5UVZWm36bCRdl3hVgStf/7Tuf?=
 =?us-ascii?Q?y0LnBk/avz3TsqajBvDzJu1whtYaSuKhDutrcPxXhCCb0YNRMb8r0FZ43tGl?=
 =?us-ascii?Q?Vj80UOVMbHYQnI2KdqlRWKdZIgiIRX5NKox8Ve6MT2JIr9gEHEm2H0jzZ5KW?=
 =?us-ascii?Q?FSAei7wj6+z/qm6RzxChVsCq8Y+y4SOThpB7gmFpG+yn2IluK6yEdbJvJsIN?=
 =?us-ascii?Q?SHTfV8iDVzZW3uREhpxyvkMjrxaDLUAefccu7nHncz+Um9iUIc9hp0GEAvi/?=
 =?us-ascii?Q?LWNcWz4Ez1sBGOt4tOQf1qp+E5z8uSIqfMc1SwjbP5UYZrIjB2orgohEtSTC?=
 =?us-ascii?Q?xA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eed5413d-2fa2-4726-36c4-08da68bae012
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 12:41:47.2903
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dpm7e12YlpYWSaAmExXnx37iegeV9Q+B5vE6ObpIX1ZhWDriwKRQywTPHcjVWRpOi+Gozq6Kgs533YiMC1XadY6CVojks4PVFWm6HfrW47A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5201
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-18_12,2022-07-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=757 spamscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207180054
X-Proofpoint-GUID: Thfig4HmsifiPF5Xua50SahK6N2Mrp98
X-Proofpoint-ORIG-GUID: Thfig4HmsifiPF5Xua50SahK6N2Mrp98
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 18, 2022 at 12:20:25AM +0200, Philipp Hortmann wrote:
> checkpatch.pl does not accept multiline macros.
>

What?  Really?

I tested this to see if was true and it just complained about potential
side effects on iobase.

regads,
dan carpenter

> diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> index 5747de436911..129a6602f6f0 100644
> --- a/drivers/staging/vt6655/mac.h
> +++ b/drivers/staging/vt6655/mac.h
> @@ -537,16 +537,6 @@
>  
>  /*---------------------  Export Macros ------------------------------*/
>  
> -#define MACvReceive1(iobase)						\
> -do {									\
> -	unsigned long reg_value;					\
> -	reg_value = ioread32(iobase + MAC_REG_RXDMACTL1);		\
> -	if (reg_value & DMACTL_RUN)					\
> -		iowrite32(DMACTL_WAKE, iobase + MAC_REG_RXDMACTL1);	\
> -	else								\
> -		iowrite32(DMACTL_RUN, iobase + MAC_REG_RXDMACTL1);	\
> -} while (0)
> -
>  #define MACvTransmit0(iobase)						\
>  do {									\
>  	unsigned long reg_value;					\