Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Jul 2022 16:17:17 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: [PATCH] tools/power/x86/intel-speed-select: Fix off by one check
Message-ID: <YtVdXen0K8KH0kwu@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bc2SM6kWSzSiv1i+YsR0Gak0w2hWhsF9OwuvA0dpOVTBmk9hxXrwBg2sYR12?=
 =?us-ascii?Q?GQkGodjRAkqKPNWjXHMjUrtmRhrUS34Ish3AdyrInV35CsVmbFDF5wmSoJIA?=
 =?us-ascii?Q?aFWlloP5m5ONtHmyF85CANTinJbDWcSJFCriscBRbB0mPRHF5BotXJEfH8l+?=
 =?us-ascii?Q?s7juwqIgJRjJCEnJm+7SRcIDJZGECBCRae8gs/DOBivn4X+5kh34hxRObaZ5?=
 =?us-ascii?Q?H6qoNS5n6thIGAgHx/fhMM90toXJ7OGiDfZflRdK02ZSHr+YoCBqJUFldNxd?=
 =?us-ascii?Q?hcVtkQJSX+sPwIb5hxbOCTORjH+Kj9ijpFYcGncd1+Wjsy+wEs03HE2cra/L?=
 =?us-ascii?Q?yjBmuUkY+66X52ESYSx8dUHzYimzFYz0MDFdKomLnLTcgHxYomDLj/xwdT9S?=
 =?us-ascii?Q?YY8Yx8HxWmsKCyLFJ6GJOLg7yHdY9xIzL0pjgTWKhs7qQup+F9CJ7Il7Pe2A?=
 =?us-ascii?Q?/maTJ68/ZzCU5E28Imc4WlX7Dl6jCHYjnAqlkPD7JcHLSsE3BiIDxQ4tDl9g?=
 =?us-ascii?Q?Tr0BhA+aTk1qGIi+QwlifuzxMQQSrIJvkNU77eion5fnrZFqTdefQfUWmM5L?=
 =?us-ascii?Q?zCPOuO7Zm1KScj3aZZpGEHpLIDJP+uWQnSfyDp2XQwlkCTGL377KGNblB1My?=
 =?us-ascii?Q?zHRovO40e5jqYIKOWIvlcqlyhxl8R7RZT3kUB+cI4HzEMoHkkV7QLR0oblos?=
 =?us-ascii?Q?rBJbyR3rBIPg2V2ZpFnGMcT5QnQTWTAJ/THKcy0cTPSsaIvCIAOwty2LcKTd?=
 =?us-ascii?Q?Ko65DRVgBXa8r9rTggqSLcATGNjRCuIO1y9U05ezcZvWs8E/pTlOKV6zOnKm?=
 =?us-ascii?Q?QXGv7pfAYyLX2ay1YuHUViJh8NPxiDQRNzI0/kS0QuBtJnzsWt6qrOOtOaFh?=
 =?us-ascii?Q?yqndtTYBv8IXXjqMedlGFaABGRyzu+YJC06pAsnyyPIQfBYgm1xf7PDIyM8V?=
 =?us-ascii?Q?8Ac/cHYZiHo9cA9MvThXHHyF6++RA3PsV/9/kerzyQ8gmmBCYIMbpeAw6Gnn?=
 =?us-ascii?Q?dE46HPP2cBIUAdh1ftObVsILp4yZsbo5xigdSmA2mh8bE/Z53O6VYFKdIF5n?=
 =?us-ascii?Q?D/RMMk5UxTeBC+Yw/fueYPK1qzgonnDPUjgN+8x3v7cUiWDjoAizTMUH2v3K?=
 =?us-ascii?Q?TavLlSDI8DuzJk0a3qhSIibgYEZa2bi01bEge/RXt8ASUHBYhfX69bIo+wcS?=
 =?us-ascii?Q?4S/fElixo5lZ+rubg6Gd/N1pWzMk7zLlIqpDYFtU7CSG39IMErL2g/kNqWiZ?=
 =?us-ascii?Q?6tB7olyfR5lGb1DVgwiXAQz+mfK1xhg4uA8yN/37Ip+dhn/tyk+Zr71xDi2S?=
 =?us-ascii?Q?/0xSRuVH13uAGrd1H8mizApJrdkIhQSA6VKUWGNhWA5fjSn5te/AyP2poj0w?=
 =?us-ascii?Q?XgzSSyItKYiydDhn5StwyTw3YeXecnCLqxnoBJWPu1aWH2cP9Af3Sp3sCnKq?=
 =?us-ascii?Q?NjkAumaCj2k82BJtnaZQX7D7LWU0vZWk86OZ4QJahoIvsPIz8J62On+rfqga?=
 =?us-ascii?Q?q9xtP+rLRevaviAUWDfh/mUaWZXg6nqZhf5gdswLtd5I2rm6cUJRpFxo1sHs?=
 =?us-ascii?Q?apbV3ejTBAZMJWYYAjkaeeIF6z5i/WoyOzNQzr+IzpkSQE1Ion5IjYfMHLNf?=
 =?us-ascii?Q?6Q=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6958f62e-843a-47b7-e18b-08da68bfdccd
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 13:17:27.9806
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UjuSHKW/w96VF54aEapCl3Fh6Ol4Nxto3QufjD/zcajTVlf9jepaLz6y30BB6OBZ2ij3cLik0vF9+ZFWR//z1Bg3UfpQ9DfkjrcrnMC7Iww=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1001MB2201
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-18_12,2022-07-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207180058
X-Proofpoint-ORIG-GUID: CV7kMtPwJGwxKti8k6EqFIISqy5uGYq4
X-Proofpoint-GUID: CV7kMtPwJGwxKti8k6EqFIISqy5uGYq4
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Change > MAX_DIE_PER_PACKAGE to >= MAX_DIE_PER_PACKAGE to prevent
accessing one element beyond the end of the array.

Fixes: 7fd786dfbd2c ("tools/power/x86/intel-speed-select: OOB daemon mode")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 tools/power/x86/intel-speed-select/isst-daemon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/x86/intel-speed-select/isst-daemon.c b/tools/power/x86/intel-speed-select/isst-daemon.c
index dd372924bc82..d0400c6684ba 100644
--- a/tools/power/x86/intel-speed-select/isst-daemon.c
+++ b/tools/power/x86/intel-speed-select/isst-daemon.c
@@ -41,7 +41,7 @@ void process_level_change(int cpu)
 	time_t tm;
 	int ret;
 
-	if (pkg_id >= MAX_PACKAGE_COUNT || die_id > MAX_DIE_PER_PACKAGE) {
+	if (pkg_id >= MAX_PACKAGE_COUNT || die_id >= MAX_DIE_PER_PACKAGE) {
 		debug_printf("Invalid package/die info for cpu:%d\n", cpu);
 		return;
 	}
-- 
2.35.1