Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <49a8099eb7dd01e9d2d190056171341d87cd442b.camel@perches.com>
Subject: Re: [PATCH] nbd: add missing definition of pr_fmt
From:   Joe Perches <joe@perches.com>
To:     Yu Kuai <yukuai1@huaweicloud.com>, josef@toxicpanda.com,
        axboe@kernel.dk, houtao1@huawei.com
Cc:     linux-block@vger.kernel.org, nbd@other.debian.org,
        linux-kernel@vger.kernel.org, yi.zhang@huawei.com
Date:   Mon, 18 Jul 2022 07:32:21 -0700
In-Reply-To: <853a5164-78cf-1ccb-8e18-cff5b5bce4ff@huaweicloud.com>
References: <20220706093320.1962871-1-yukuai1@huaweicloud.com>
         <853a5164-78cf-1ccb-8e18-cff5b5bce4ff@huaweicloud.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.44.1-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-07-18 at 21:52 +0800, Yu Kuai wrote:
> 在 2022/07/06 17:33, Yu Kuai 写道:
> > From: Yu Kuai <yukuai3@huawei.com>
> > 
> > commit 1243172d5894 ("nbd: use pr_err to output error message") tries
> > to define pr_fmt and use short pr_err() to output error message,
> > however, the definition is missed.
> 
> friendly ping ...
[]
> > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
[]
> > @@ -44,6 +44,9 @@
> >   #include <linux/nbd-netlink.h>
> >   #include <net/genetlink.h>
> >   
> > +#undef pr_fmt
> > +#define pr_fmt(fmt) "nbd: " fmt
> > +

Typically, this #define is place before all #include lines
so there is no need for an #undef