Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220718114748.6365-1-andriy.shevchenko@linux.intel.com> <aa9e27c7-e4cf-00f1-e88a-8d6c3857eb71@redhat.com>
In-Reply-To: <aa9e27c7-e4cf-00f1-e88a-8d6c3857eb71@redhat.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 18 Jul 2022 16:55:06 +0200
Message-ID: <CAHp75Vfez=qECDuVdsDpWu4qjOt6U_xBrMC3P-O--V2EQprB8w@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] platform/x86: p2sb: Move out of
 X86_PLATFORM_DEVICES dependency
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Kate Hsuan <hpa@redhat.com>,
        Jonathan Yong <jonathan.yong@intel.com>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Mark Gross <markgross@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jul 18, 2022 at 4:18 PM Hans de Goede <hdegoede@redhat.com> wrote:
> On 7/18/22 13:47, Andy Shevchenko wrote:

...

> >  endif # X86_PLATFORM_DEVICES
> >
> > +config P2SB
> > +     bool "Primary to Sideband (P2SB) bridge access support"
> > +     depends on PCI
>
> This needs to become "PCI && X86" to avoid this possible getting
> enabled on other platforms.

Indeed.

> With that added you may add my:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Thanks!
Amended and sent a v2.

> and this also counts as my ack for merging this through
> Lee's MFD tree together with the rest of the series.


-- 
With Best Regards,
Andy Shevchenko