Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b7540ac17d28cee09f6f9cce65b696248e545ae1.camel@pengutronix.de>
Subject: Re: [PATCH v2 03/12] reset: add polarfire soc reset support
From:   Philipp Zabel <p.zabel@pengutronix.de>
To:     Conor.Dooley@microchip.com
Cc:     paul.walmsley@sifive.com, Daire.McNamara@microchip.com,
        sboyd@kernel.org, aou@eecs.berkeley.edu, robh+dt@kernel.org,
        palmer@dabbelt.com, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, mturquette@baylibre.com,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
        krzysztof.kozlowski+dt@linaro.org
Date:   Mon, 18 Jul 2022 17:42:08 +0200
In-Reply-To: <22d3a11b-a603-8406-77ec-51ec038560fc@microchip.com>
References: <20220704121558.2088698-1-conor.dooley@microchip.com>
         <20220704121558.2088698-4-conor.dooley@microchip.com>
         <22d3a11b-a603-8406-77ec-51ec038560fc@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
Precedence: bulk

Hi Conor,

On Mo, 2022-07-18 at 11:34 +0000, Conor.Dooley@microchip.com wrote:
[...]
> > +config RESET_POLARFIRE_SOC
> > +	bool "Microchip PolarFire SoC (MPFS) Reset Driver"
> > +	depends on AUXILIARY_BUS && MCHP_CLK_MPFS
> > +	default MCHP_CLK_MPFS
> > +	help
> > +	  This driver supports peripheral reset for the Microchip PolarFire SoC
> > +

Please sort alphabetically by config option.

> >   config RESET_MESON
> >   	tristate "Meson Reset Driver"
> >   	depends on ARCH_MESON || COMPILE_TEST
> > diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
> > index a80a9c4008a7..5fac3a753858 100644
> > --- a/drivers/reset/Makefile
> > +++ b/drivers/reset/Makefile
> > @@ -17,6 +17,7 @@ obj-$(CONFIG_RESET_K210) += reset-k210.o
> >   obj-$(CONFIG_RESET_LANTIQ) += reset-lantiq.o
> >   obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o
> >   obj-$(CONFIG_RESET_MCHP_SPARX5) += reset-microchip-sparx5.o
> > +obj-$(CONFIG_RESET_POLARFIRE_SOC) += reset-mpfs.o

Same here. Otherwise,

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

and

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

to merge this together with the other patches.

regards
Philipp