Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Jul 2022 09:24:12 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-gpio@vger.kernel.org,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        UNGLinuxDriver@microchip.com,
        Linus Walleij <linus.walleij@linaro.org>,
        Wolfram Sang <wsa@kernel.org>,
        Terry Bowman <terry.bowman@amd.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        katie.morris@in-advantage.com
Subject: Re: [PATCH v13 net-next 9/9] mfd: ocelot: add support for the
 vsc7512 chip via spi
Message-ID: <YtWJLIUepiKA4S4u@COLIN-DESKTOP1.localdomain>
References: <20220705204743.3224692-1-colin.foster@in-advantage.com>
 <20220705204743.3224692-10-colin.foster@in-advantage.com>
 <YtVrtOHy3lAeKCRH@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YtVrtOHy3lAeKCRH@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1HHpELiRfpe1edSw9fMcPcLgLcCKCdW13qiqYj9kPAolpCsLconjysTkutja?=
 =?us-ascii?Q?1GocL0iCZi60vdGk/hHgehMFhilcQ++DqozRS7F+rEImAYV7WA1obgw496vG?=
 =?us-ascii?Q?6uvK+fz1Kjb0E8+pOLnZ0xQlzvfnAtdXDDSMWfxiepd0gn3yO/e8fhyLtPRb?=
 =?us-ascii?Q?kEqQNXPwpU/+/T1CnT2veEgbtA3wUo9zhYjRC2PXV6b0FyOinrsgFVp/p/1p?=
 =?us-ascii?Q?aQlsMMQKTSJFQhkF9FU4OXxGLTw5jlZjSr6rlm7FxjXcXehbF/8QRD981GOs?=
 =?us-ascii?Q?X3oFdtbWEJaI5wEe+wBEF/a0qk0YlAfqYX+p7cdpQIfjihY9Mj21vpcBYHnu?=
 =?us-ascii?Q?tIzl/5EBpBsJ15vyUGmoghxRf7K6OR4k5ZwMHPnQjsmdmj21uf5u+Hpxkv/L?=
 =?us-ascii?Q?GtXu6pg710+5nCJqyZyePcsfHRgixEqx6VpOR5UqdWVwoEiLRWXp0x9h6VQu?=
 =?us-ascii?Q?bPXUZNN5W3/ILXAGPEaUP63a68WRNNnh2Hrorsau/VTqmbLlXdJ3ecOQU3rL?=
 =?us-ascii?Q?XXq3FzsKgdB9s1tJ8dvb5g8fNE+Ax/uAdkq7gXKNG7KjasOreThCr6d9nm+L?=
 =?us-ascii?Q?RWt0csWLdECTObYAJeJPOhS5y0gryVfKTD1aBRjBwh+s7EybcIJOHsYzU9GQ?=
 =?us-ascii?Q?hvTjON+V587B+MPmjnIBvcaR+Mnw2WkXDR7R3oRu7+z6FG9r/CEb+bDIiRF4?=
 =?us-ascii?Q?wBudLyZt7LOonk25+zIP8C/lfGXp8vKuEBxSD8+qXaQsmsqufDOTWuAn+SAw?=
 =?us-ascii?Q?j/R3z+LSPuecYiFuNQqlYto2kdfcYSLva6fMl9g+USUPGnK1ZeObdNtmJ5rF?=
 =?us-ascii?Q?8rnG52xZpMFZX4pNbUK0Asmq/3Q/zXZbSojD/xQBYEGPNt4XmtbG6X4ihU2X?=
 =?us-ascii?Q?iy4qvwUObkqf2qPymSCju9SKJCFl7ZSZT8c+F7FayHa5wC3oi3+sjaFxs78a?=
 =?us-ascii?Q?nWm7zhlhXCX0QLF9CajStQt2XOvE4JfWDMNQaHRIXsSAYNAav1YuyoxQtieB?=
 =?us-ascii?Q?6H/m//Oeez1HihtcLII7vtMC1TqxzrAJ6K6Uo6cy7wZvNfwF64DU8M1K9RrC?=
 =?us-ascii?Q?wT4tJDozXhQsUHSvZ7JcNs6D6dJgKXM2npzG7D6/xivz30xLhmgk1ae9g94I?=
 =?us-ascii?Q?NPBT49VaipTruUP259pTXmXruC4iMUTsmh8PWenDycJShB2lNVcpNeO8LtE7?=
 =?us-ascii?Q?QrpgvdkaJFJpAQXClurYLwjaoBob0Ex9x5Lg1uAuzT0to86zAWkM/TBxDBh+?=
 =?us-ascii?Q?4WBLZIEUakaJpV3iMImpkl4CErQKCVKOORUtT9qesFG9azeyplU5aIxMwaXw?=
 =?us-ascii?Q?2NPsWyaOZYFyTT3FNjMtTJWdxsJaGiQHGmKU7rUcIm/xoW/ScyEne96p6ptQ?=
 =?us-ascii?Q?NbOGlU2JZQb1jPLGSgTzv2S3EYQHPV7hRtIfEKyEQTySkgSg3hZOh7CZS8JD?=
 =?us-ascii?Q?U7hovDeTDNDgJbkRG+T8Mkr8n97xNdiLhi/2kdGk1LMHj+xVm/3Ei/hhdK/l?=
 =?us-ascii?Q?YAuCeKlV/m6VH4YtehxMYg8BcnspkmBdEhrRFodUHIoEJyUefIWcKCbM7Zo5?=
 =?us-ascii?Q?dxk/zQUm/ytYwCzQNkYwZzRgtROwSeslHH16wkpfrIlnMNpR3qHghGwaQjJo?=
 =?us-ascii?Q?lQ=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5926f836-c665-4490-233b-08da68d9f5c6
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 16:24:18.3971
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4Lmbpc1cn3nFk/XoCPn+OfXy5vxNr7onseFWu8YfjmdkEDgnp/Y2LE1TqhMHHG6YAlXd5G9rlCGaI0DrO/mloXV8+LJUxZZPv4yoJAr4+sU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1642
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 18, 2022 at 03:18:28PM +0100, Lee Jones wrote:
> On Tue, 05 Jul 2022, Colin Foster wrote:
> 
> > The VSC7512 is a networking chip that contains several peripherals. Many of
> > these peripherals are currently supported by the VSC7513 and VSC7514 chips,
> > but those run on an internal CPU. The VSC7512 lacks this CPU, and must be
> > controlled externally.
> > 
> > Utilize the existing drivers by referencing the chip as an MFD. Add support
> > for the two MDIO buses, the internal phys, pinctrl, and serial GPIO.
> > 
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > ---
> >  MAINTAINERS               |   1 +
> >  drivers/mfd/Kconfig       |  21 +++
> >  drivers/mfd/Makefile      |   3 +
> >  drivers/mfd/ocelot-core.c | 169 ++++++++++++++++++++
> >  drivers/mfd/ocelot-spi.c  | 317 ++++++++++++++++++++++++++++++++++++++
> >  drivers/mfd/ocelot.h      |  34 ++++
> >  6 files changed, 545 insertions(+)
> >  create mode 100644 drivers/mfd/ocelot-core.c
> >  create mode 100644 drivers/mfd/ocelot-spi.c
> >  create mode 100644 drivers/mfd/ocelot.h
> 
> Generally this is looking much better.
> 
> Almost ready for inclusion with just a few nits.
> 

Hi Lee,

Thanks for the feedback. I'll get these fixes done this week!