Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH net-next v3 08/47] net: phylink: Support differing link
 speeds and interface speeds
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     "Russell King (Oracle)" <linux@armlinux.org.uk>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>, netdev@vger.kernel.org,
        Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Alexandru Marginean <alexandru.marginean@nxp.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>
References: <20220715215954.1449214-1-sean.anderson@seco.com>
 <20220715215954.1449214-9-sean.anderson@seco.com> <YtMaKWZyC/lgAQ0i@lunn.ch>
 <YtWFAfu1nSE6vCfx@shell.armlinux.org.uk>
 <b1c3fc9f-71af-6610-6f58-64a0297347dd@seco.com> <YtWYWhAm/n5mnw4I@lunn.ch>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <0275eb0c-1311-2b3b-1e37-d5297ba1a443@seco.com>
Date:   Mon, 18 Jul 2022 13:40:45 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <YtWYWhAm/n5mnw4I@lunn.ch>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wm1TV1FacDlsa25wVXY2TWVxOXZwOFJ1SFRSZ1NwbDNrODRiQjZlUUxONWw5?=
 =?utf-8?B?UDlOeEs4a1RSZnRuamkzb2g4UWhoVDBCd3FMakY4WjZ2b28zYlhDQW5uWFpx?=
 =?utf-8?B?V2dkbDBabVJsMHZUL25PMjNGQTUvRlVWREduYlFaMGdaZm5VeG5ITm16S2VI?=
 =?utf-8?B?K0xOcytxNEFzc1o4MWQ2YkpGTWdMUVZsTHNzR2lKUzhFUUdmNGxXdDQ2aWlx?=
 =?utf-8?B?U0NobGszYVVxaUZpQzZvdjJvUUNDZzh4MTdQZDU0cGhzNHh3cjhWMFlLMUxl?=
 =?utf-8?B?azdGSWRmeUtsR3I3MVVsL1pTdlpHV2hjTVhHazM2eCtoWUhiZnZCRE5odXJH?=
 =?utf-8?B?L2k1UkgvdzgyUjh1d3VqbjByODdpN2hPMEpzYTJsYmFabjk4eDNNejNNdDJB?=
 =?utf-8?B?RDZ2TEFMQlFZOUk0azhkTmwyTmttdm1FUXBTYzBCcW9MbXZ5UFFlcXUwVDhq?=
 =?utf-8?B?cUF5QVdIR0Z6REw2MlEwdGxFRXBUMStCdER3OFVMenV1b2J3K0lSWU1Yd3hO?=
 =?utf-8?B?bm1udTJ3a244aUd5REx6amlDazVJR2NNT1VvVVlOWUdIcFFQNkJjQXdJcloz?=
 =?utf-8?B?RURENklwNmNqKytjcWpFWXRyU21TOFFWMDRJdWdTNldHYnAwT2RCa3U4aEl4?=
 =?utf-8?B?NWhHWlpBRVpLMkhBODdZOVhndXlWTEhzaUoxMkZjMlF3UEVWRVdKbWlydkEy?=
 =?utf-8?B?YUVYTmwrK0tIcWNudWFQQU5xcThuL01LM0xyWEx3SkU5Vno2amh5eHk5TWI0?=
 =?utf-8?B?UmxaZVFjMUlZaFZZcTVTbHpxWS8zYkxrZElYZlR3a3VlK29NcWNqMzlCWFYv?=
 =?utf-8?B?L2hMRDRMMVFVaDZHMVRjbDJvZkoxYUdSaE1GcDF6WDlqaG1DeGNGYnhheVBz?=
 =?utf-8?B?YlpBaE1UN25KczI3QVpiZGNBb2lLMDFLMkZrNk8rR3M4L2YvUWo2eU9UUks2?=
 =?utf-8?B?M21HU0lUNnV1dHo4OXNRdWwydmtyUitEQXBTRVQ2a2NUcmdRQnhtRWpUYjhw?=
 =?utf-8?B?eTltQ2NHY3REQXcvNWJzWWE0ZDBKcm1JcnBIaTBwTG1lRnRNaEdnSUVYVDNT?=
 =?utf-8?B?ZXdrU1hCSE9vdlEvK3RnMm1nK2Y1RGtrUXM1b1BIenh2UVlHU1F1dW9NVE0v?=
 =?utf-8?B?cHVWNStScXlRK1hyRDJkV3RRVE5IWUVqK3Y1VmNqenFDeDNFMWFkSXZxZDZ2?=
 =?utf-8?B?QnFyYjBaazNWRS9CcXppZXNVNmxiZWJ4ZWEvWStWbk9jQmdzUW9WQ1pUNTRG?=
 =?utf-8?B?cUFhcFY4ZE9pcm92RkxJdUYydGlhSjNaM2lVazJ2Y0kzYlhUM1BOcHBuZHE4?=
 =?utf-8?B?UG12Q291bGFuMjYzV3J6Y21RV2t1OFIzTzlqaHJsc3Nqd1BReXYrbC8vc1kx?=
 =?utf-8?B?UXEyY1pPbE1vaGowK0kyVEJPRFVVM1FlWU8ralB1T2d2Sk9UU1c3Q2J6UFJk?=
 =?utf-8?B?amdhMWFxSENRaCtDdzdrSHFuOWtVdjFDTEJUaktyQ1VQL3RqYlJacWNpUi9K?=
 =?utf-8?B?UGZpaFFBLzRXd3dhSVFWbDZFQXRKdS9yaTNKT2x3dENaZUpaUE41UmRySWE0?=
 =?utf-8?B?Y2ZWMlBWbDB0NVp2bkZHSFV1RXBZa2ZGUFFKMURXbm9GZDhzVVRaeHZpSi8z?=
 =?utf-8?B?MmwvR1FHS09FZE5RZnNSTjVOQTlaVlhvc2dlYWN1V3JvVmh5N2xVSU9JN1kz?=
 =?utf-8?B?ZTFoODZOVHdrZGNWUlp2MVZsYkdkOVpRSlF0UGs2M2NBZEhPbDNnK1NxZVRN?=
 =?utf-8?B?NmpRUE1ZQkxLMXVoV28zUWdTcWtsWFkyYTRKb2E4ZXlRWG9YcDRGTllxNEg0?=
 =?utf-8?B?VEJqNlBzOHgzUWwyd08vNlRTTjloMW9sRlZkemV4OWk1U2xVRmFzMG4xd08y?=
 =?utf-8?B?cHlBaGtEYzVVR01wT01FeUFDVWJhMjBvczZnZ0hSRGZXWHVwTUk2alZFZmxx?=
 =?utf-8?B?Y0kyY29BWHJZZEViS2U0aHZTVnkvSTdrdkxKTnRwanYwYi9HbkNxRys1eUox?=
 =?utf-8?B?MkN0bEZVSVJxZ2t0YWV6RFlPWmpMd0pSYnRFT0ZQdTBWd2NheGc1TmVRL2Vx?=
 =?utf-8?B?dHBlUHNrZTF5cXpmdXVzaERhY094WXZFdVRnZ3VFdDMzejRuZFJDWkZVV0h3?=
 =?utf-8?B?Y1ppbGx1WDhJeWplL1FESG5COFAvRE9BTVZ2dXhENGVTZ0FHdGh6MU9Ka291?=
 =?utf-8?B?aEE9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fff6c969-5b31-49bf-f130-08da68e4a851
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 17:40:51.3214
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kYj8C3E3UNXSJM0LIntX2ayKDsb1ZiksiNIIXEwxr6guoQLup8zPdofTmDpi9l95Ug4Cjxv4SGQtlt0awl8A1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR03MB8503
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/18/22 1:28 PM, Andrew Lunn wrote:
>> > I am rather worried that we have drivers using ->speed today in their
>> > mac_config and we're redefining what that means in this patch.
>> 
>> Well, kind of. Previously, interface speed was defined to be link speed,
>> and both were just "speed". The MAC driver doesn't really care what the
>> link speed is if there is a phy, just how fast the phy interface mode
>> speed is.
> 
> I'm not sure that is true. At least for SGMII, the MAC is passed the
> line side speed, which can be 10, 100, or 1G. The PHY interface mode
> speed is fixed at 1G, since it is SGMII, but the MAC needs to know if
> it needs to repeat symbols because the line side speed is lower than
> the host side speed.

Right. In this case the phy interface speed is changing, so the MAC
needs to know about it. I suppose a more precise definition would be
something like

> The data rate of the media-independent interface between the MAC and
> the phy, without taking into account protocol overhead or flow control,
> but including encoding overhead.

as opposed to the link speed which is

> The data rate of the medium between the local device and the link
> partner, without ...

--Sean